| Message ID | 1642337235-8618-20-git-send-email-quic_mpubbise@quicinc.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | add support for WCN6750 | expand |
Manikanta Pubbisetty <quic_mpubbise@quicinc.com> writes: > Add WCN6750 wireless driver support, its based on ath11k driver. > > Signed-off-by: Manikanta Pubbisetty <quic_mpubbise@quicinc.com> Device tree bindings should be first in the patchset. I'm no DT expert, but you have a lot of changes in the bindings and it would be nice to have some kind of description what you are doing here.
On Sun, Jan 16, 2022 at 06:17:15PM +0530, Manikanta Pubbisetty wrote: > Add WCN6750 wireless driver support, its based on ath11k driver. As mentioned, provide a better commit message answering 'why'? > > Signed-off-by: Manikanta Pubbisetty <quic_mpubbise@quicinc.com> > --- > .../bindings/net/wireless/qcom,ath11k.yaml | 365 +++++++++++++++------ > 1 file changed, 257 insertions(+), 108 deletions(-) > > diff --git a/Documentation/devicetree/bindings/net/wireless/qcom,ath11k.yaml b/Documentation/devicetree/bindings/net/wireless/qcom,ath11k.yaml > index cdf7b87..dba1434 100644 > --- a/Documentation/devicetree/bindings/net/wireless/qcom,ath11k.yaml > +++ b/Documentation/devicetree/bindings/net/wireless/qcom,ath11k.yaml > @@ -20,120 +20,21 @@ properties: > enum: > - qcom,ipq8074-wifi > - qcom,ipq6018-wifi > + - qcom,wcn6750-wifi > > reg: > maxItems: 1 > > - interrupts: > - items: > - - description: misc-pulse1 interrupt events > - - description: misc-latch interrupt events > - - description: sw exception interrupt events > - - description: watchdog interrupt events > - - description: interrupt event for ring CE0 > - - description: interrupt event for ring CE1 > - - description: interrupt event for ring CE2 > - - description: interrupt event for ring CE3 > - - description: interrupt event for ring CE4 > - - description: interrupt event for ring CE5 > - - description: interrupt event for ring CE6 > - - description: interrupt event for ring CE7 > - - description: interrupt event for ring CE8 > - - description: interrupt event for ring CE9 > - - description: interrupt event for ring CE10 > - - description: interrupt event for ring CE11 > - - description: interrupt event for ring host2wbm-desc-feed > - - description: interrupt event for ring host2reo-re-injection > - - description: interrupt event for ring host2reo-command > - - description: interrupt event for ring host2rxdma-monitor-ring3 > - - description: interrupt event for ring host2rxdma-monitor-ring2 > - - description: interrupt event for ring host2rxdma-monitor-ring1 > - - description: interrupt event for ring reo2ost-exception > - - description: interrupt event for ring wbm2host-rx-release > - - description: interrupt event for ring reo2host-status > - - description: interrupt event for ring reo2host-destination-ring4 > - - description: interrupt event for ring reo2host-destination-ring3 > - - description: interrupt event for ring reo2host-destination-ring2 > - - description: interrupt event for ring reo2host-destination-ring1 > - - description: interrupt event for ring rxdma2host-monitor-destination-mac3 > - - description: interrupt event for ring rxdma2host-monitor-destination-mac2 > - - description: interrupt event for ring rxdma2host-monitor-destination-mac1 > - - description: interrupt event for ring ppdu-end-interrupts-mac3 > - - description: interrupt event for ring ppdu-end-interrupts-mac2 > - - description: interrupt event for ring ppdu-end-interrupts-mac1 > - - description: interrupt event for ring rxdma2host-monitor-status-ring-mac3 > - - description: interrupt event for ring rxdma2host-monitor-status-ring-mac2 > - - description: interrupt event for ring rxdma2host-monitor-status-ring-mac1 > - - description: interrupt event for ring host2rxdma-host-buf-ring-mac3 > - - description: interrupt event for ring host2rxdma-host-buf-ring-mac2 > - - description: interrupt event for ring host2rxdma-host-buf-ring-mac1 > - - description: interrupt event for ring rxdma2host-destination-ring-mac3 > - - description: interrupt event for ring rxdma2host-destination-ring-mac2 > - - description: interrupt event for ring rxdma2host-destination-ring-mac1 > - - description: interrupt event for ring host2tcl-input-ring4 > - - description: interrupt event for ring host2tcl-input-ring3 > - - description: interrupt event for ring host2tcl-input-ring2 > - - description: interrupt event for ring host2tcl-input-ring1 > - - description: interrupt event for ring wbm2host-tx-completions-ring3 > - - description: interrupt event for ring wbm2host-tx-completions-ring2 > - - description: interrupt event for ring wbm2host-tx-completions-ring1 > - - description: interrupt event for ring tcl2host-status-ring > + reg-names: > + maxItems: 1 Need to define the names though for 1 entry, -names is kind of pointless. > > + interrupts: > + minItems: 32 > + maxItems: 52 > > interrupt-names: > - items: > - - const: misc-pulse1 > - - const: misc-latch > - - const: sw-exception > - - const: watchdog > - - const: ce0 > - - const: ce1 > - - const: ce2 > - - const: ce3 > - - const: ce4 > - - const: ce5 > - - const: ce6 > - - const: ce7 > - - const: ce8 > - - const: ce9 > - - const: ce10 > - - const: ce11 > - - const: host2wbm-desc-feed > - - const: host2reo-re-injection > - - const: host2reo-command > - - const: host2rxdma-monitor-ring3 > - - const: host2rxdma-monitor-ring2 > - - const: host2rxdma-monitor-ring1 > - - const: reo2ost-exception > - - const: wbm2host-rx-release > - - const: reo2host-status > - - const: reo2host-destination-ring4 > - - const: reo2host-destination-ring3 > - - const: reo2host-destination-ring2 > - - const: reo2host-destination-ring1 > - - const: rxdma2host-monitor-destination-mac3 > - - const: rxdma2host-monitor-destination-mac2 > - - const: rxdma2host-monitor-destination-mac1 > - - const: ppdu-end-interrupts-mac3 > - - const: ppdu-end-interrupts-mac2 > - - const: ppdu-end-interrupts-mac1 > - - const: rxdma2host-monitor-status-ring-mac3 > - - const: rxdma2host-monitor-status-ring-mac2 > - - const: rxdma2host-monitor-status-ring-mac1 > - - const: host2rxdma-host-buf-ring-mac3 > - - const: host2rxdma-host-buf-ring-mac2 > - - const: host2rxdma-host-buf-ring-mac1 > - - const: rxdma2host-destination-ring-mac3 > - - const: rxdma2host-destination-ring-mac2 > - - const: rxdma2host-destination-ring-mac1 > - - const: host2tcl-input-ring4 > - - const: host2tcl-input-ring3 > - - const: host2tcl-input-ring2 > - - const: host2tcl-input-ring1 > - - const: wbm2host-tx-completions-ring3 > - - const: wbm2host-tx-completions-ring2 > - - const: wbm2host-tx-completions-ring1 > - - const: tcl2host-status-ring > + minItems: 32 > + maxItems: 52 But you didn't define any names for the new chip. > > qcom,rproc: > $ref: /schemas/types.yaml#/definitions/phandle > @@ -156,15 +57,201 @@ properties: > phandle to a node describing reserved memory (System RAM memory) > used by ath11k firmware (see bindings/reserved-memory/reserved-memory.txt) > > + iommus: > + maxItems: 1 > + > + wifi-firmware: > + type: object > + description: | > + WCN6750 wifi node can contain one optional firmware subnode. > + Firmware subnode is needed when the platform does not have TustZone. Trustzone > + properties: > + iommus: > + maxItems: 1 If this is the only property, then just make parent 'iommus' 1 or 2 entries. > + required: > + - iommus > + > required: > - compatible > - reg > - interrupts > - - interrupt-names > - qcom,rproc > > additionalProperties: false > > +allOf: > + - if: > + properties: > + compatible: > + contains: > + enum: > + - qcom,ipq8074-wifi > + - qcom,ipq6018-wifi > + then: > + properties: > + interrupts: > + items: > + - description: misc-pulse1 interrupt events > + - description: misc-latch interrupt events > + - description: sw exception interrupt events > + - description: watchdog interrupt events > + - description: interrupt event for ring CE0 > + - description: interrupt event for ring CE1 > + - description: interrupt event for ring CE2 > + - description: interrupt event for ring CE3 > + - description: interrupt event for ring CE4 > + - description: interrupt event for ring CE5 > + - description: interrupt event for ring CE6 > + - description: interrupt event for ring CE7 > + - description: interrupt event for ring CE8 > + - description: interrupt event for ring CE9 > + - description: interrupt event for ring CE10 > + - description: interrupt event for ring CE11 > + - description: interrupt event for ring host2wbm-desc-feed > + - description: interrupt event for ring host2reo-re-injection > + - description: interrupt event for ring host2reo-command > + - description: interrupt event for ring host2rxdma-monitor-ring3 > + - description: interrupt event for ring host2rxdma-monitor-ring2 > + - description: interrupt event for ring host2rxdma-monitor-ring1 > + - description: interrupt event for ring reo2ost-exception > + - description: interrupt event for ring wbm2host-rx-release > + - description: interrupt event for ring reo2host-status > + - description: interrupt event for ring reo2host-destination-ring4 > + - description: interrupt event for ring reo2host-destination-ring3 > + - description: interrupt event for ring reo2host-destination-ring2 > + - description: interrupt event for ring reo2host-destination-ring1 > + - description: interrupt event for ring rxdma2host-monitor-destination-mac3 > + - description: interrupt event for ring rxdma2host-monitor-destination-mac2 > + - description: interrupt event for ring rxdma2host-monitor-destination-mac1 > + - description: interrupt event for ring ppdu-end-interrupts-mac3 > + - description: interrupt event for ring ppdu-end-interrupts-mac2 > + - description: interrupt event for ring ppdu-end-interrupts-mac1 > + - description: interrupt event for ring rxdma2host-monitor-status-ring-mac3 > + - description: interrupt event for ring rxdma2host-monitor-status-ring-mac2 > + - description: interrupt event for ring rxdma2host-monitor-status-ring-mac1 > + - description: interrupt event for ring host2rxdma-host-buf-ring-mac3 > + - description: interrupt event for ring host2rxdma-host-buf-ring-mac2 > + - description: interrupt event for ring host2rxdma-host-buf-ring-mac1 > + - description: interrupt event for ring rxdma2host-destination-ring-mac3 > + - description: interrupt event for ring rxdma2host-destination-ring-mac2 > + - description: interrupt event for ring rxdma2host-destination-ring-mac1 > + - description: interrupt event for ring host2tcl-input-ring4 > + - description: interrupt event for ring host2tcl-input-ring3 > + - description: interrupt event for ring host2tcl-input-ring2 > + - description: interrupt event for ring host2tcl-input-ring1 > + - description: interrupt event for ring wbm2host-tx-completions-ring3 > + - description: interrupt event for ring wbm2host-tx-completions-ring2 > + - description: interrupt event for ring wbm2host-tx-completions-ring1 > + - description: interrupt event for ring tcl2host-status-ring > + interrupt-names: > + items: > + - const: misc-pulse1 > + - const: misc-latch > + - const: sw-exception > + - const: watchdog > + - const: ce0 > + - const: ce1 > + - const: ce2 > + - const: ce3 > + - const: ce4 > + - const: ce5 > + - const: ce6 > + - const: ce7 > + - const: ce8 > + - const: ce9 > + - const: ce10 > + - const: ce11 > + - const: host2wbm-desc-feed > + - const: host2reo-re-injection > + - const: host2reo-command > + - const: host2rxdma-monitor-ring3 > + - const: host2rxdma-monitor-ring2 > + - const: host2rxdma-monitor-ring1 > + - const: reo2ost-exception > + - const: wbm2host-rx-release > + - const: reo2host-status > + - const: reo2host-destination-ring4 > + - const: reo2host-destination-ring3 > + - const: reo2host-destination-ring2 > + - const: reo2host-destination-ring1 > + - const: rxdma2host-monitor-destination-mac3 > + - const: rxdma2host-monitor-destination-mac2 > + - const: rxdma2host-monitor-destination-mac1 > + - const: ppdu-end-interrupts-mac3 > + - const: ppdu-end-interrupts-mac2 > + - const: ppdu-end-interrupts-mac1 > + - const: rxdma2host-monitor-status-ring-mac3 > + - const: rxdma2host-monitor-status-ring-mac2 > + - const: rxdma2host-monitor-status-ring-mac1 > + - const: host2rxdma-host-buf-ring-mac3 > + - const: host2rxdma-host-buf-ring-mac2 > + - const: host2rxdma-host-buf-ring-mac1 > + - const: rxdma2host-destination-ring-mac3 > + - const: rxdma2host-destination-ring-mac2 > + - const: rxdma2host-destination-ring-mac1 > + - const: host2tcl-input-ring4 > + - const: host2tcl-input-ring3 > + - const: host2tcl-input-ring2 > + - const: host2tcl-input-ring1 > + - const: wbm2host-tx-completions-ring3 > + - const: wbm2host-tx-completions-ring2 > + - const: wbm2host-tx-completions-ring1 > + - const: tcl2host-status-ring > + > + - if: > + properties: > + compatible: > + contains: > + enum: > + - qcom,ipq8074-wifi > + - qcom,ipq6018-wifi > + then: > + required: > + - interrupt-names > + > + - if: > + properties: > + compatible: > + contains: > + enum: > + - qcom,wcn6750-wifi > + then: > + properties: > + interrupts: > + items: > + - description: interrupt event for ring CE1 > + - description: interrupt event for ring CE2 > + - description: interrupt event for ring CE3 > + - description: interrupt event for ring CE4 > + - description: interrupt event for ring CE5 > + - description: interrupt event for ring CE6 > + - description: interrupt event for ring CE7 > + - description: interrupt event for ring CE8 > + - description: interrupt event for ring CE9 > + - description: interrupt event for ring CE10 > + - description: interrupt event for ring DP1 > + - description: interrupt event for ring DP2 > + - description: interrupt event for ring DP3 > + - description: interrupt event for ring DP4 > + - description: interrupt event for ring DP5 > + - description: interrupt event for ring DP6 > + - description: interrupt event for ring DP7 > + - description: interrupt event for ring DP8 > + - description: interrupt event for ring DP9 > + - description: interrupt event for ring DP10 > + - description: interrupt event for ring DP11 > + - description: interrupt event for ring DP12 > + - description: interrupt event for ring DP13 > + - description: interrupt event for ring DP14 > + - description: interrupt event for ring DP15 > + - description: interrupt event for ring DP16 > + - description: interrupt event for ring DP17 > + - description: interrupt event for ring DP18 > + - description: interrupt event for ring DP19 > + - description: interrupt event for ring DP20 > + - description: interrupt event for ring DP21 > + - description: interrupt event for ring DP22 > + > examples: > - | > > @@ -309,3 +396,65 @@ examples: > }; > }; > }; > + > + - | > + #include <dt-bindings/interrupt-controller/arm-gic.h> > + > + reserved-memory { > + #address-cells = <2>; > + #size-cells = <2>; > + > + wlan_ce_mem: wlan_ce_mem@4cd000 { > + no-map; > + reg = <0x0 0x4cd000 0x0 0x1000>; > + }; > + > + wlan_fw_mem: wlan_fw_mem@80c00000 { > + no-map; > + reg = <0x0 0x80c00000 0x0 0xc00000>; > + }; > + }; > + > + wifi: wifi@17a10040 { > + compatible = "qcom,wcn6750-wifi"; > + reg = <0x17A10040 0x0>; > + reg-names = "msi_addr"; > + iommus = <&apps_smmu 0x1C00 0x1>; > + interrupts = <GIC_SPI 768 IRQ_TYPE_EDGE_RISING>, > + <GIC_SPI 769 IRQ_TYPE_EDGE_RISING>, > + <GIC_SPI 770 IRQ_TYPE_EDGE_RISING>, > + <GIC_SPI 771 IRQ_TYPE_EDGE_RISING>, > + <GIC_SPI 772 IRQ_TYPE_EDGE_RISING>, > + <GIC_SPI 773 IRQ_TYPE_EDGE_RISING>, > + <GIC_SPI 774 IRQ_TYPE_EDGE_RISING>, > + <GIC_SPI 775 IRQ_TYPE_EDGE_RISING>, > + <GIC_SPI 776 IRQ_TYPE_EDGE_RISING>, > + <GIC_SPI 777 IRQ_TYPE_EDGE_RISING>, > + <GIC_SPI 778 IRQ_TYPE_EDGE_RISING>, > + <GIC_SPI 779 IRQ_TYPE_EDGE_RISING>, > + <GIC_SPI 780 IRQ_TYPE_EDGE_RISING>, > + <GIC_SPI 781 IRQ_TYPE_EDGE_RISING>, > + <GIC_SPI 782 IRQ_TYPE_EDGE_RISING>, > + <GIC_SPI 783 IRQ_TYPE_EDGE_RISING>, > + <GIC_SPI 784 IRQ_TYPE_EDGE_RISING>, > + <GIC_SPI 785 IRQ_TYPE_EDGE_RISING>, > + <GIC_SPI 786 IRQ_TYPE_EDGE_RISING>, > + <GIC_SPI 787 IRQ_TYPE_EDGE_RISING>, > + <GIC_SPI 788 IRQ_TYPE_EDGE_RISING>, > + <GIC_SPI 789 IRQ_TYPE_EDGE_RISING>, > + <GIC_SPI 790 IRQ_TYPE_EDGE_RISING>, > + <GIC_SPI 791 IRQ_TYPE_EDGE_RISING>, > + <GIC_SPI 792 IRQ_TYPE_EDGE_RISING>, > + <GIC_SPI 793 IRQ_TYPE_EDGE_RISING>, > + <GIC_SPI 794 IRQ_TYPE_EDGE_RISING>, > + <GIC_SPI 795 IRQ_TYPE_EDGE_RISING>, > + <GIC_SPI 796 IRQ_TYPE_EDGE_RISING>, > + <GIC_SPI 797 IRQ_TYPE_EDGE_RISING>, > + <GIC_SPI 798 IRQ_TYPE_EDGE_RISING>, > + <GIC_SPI 799 IRQ_TYPE_EDGE_RISING>; > + qcom,rproc = <&remoteproc_wpss>; > + memory-region = <&wlan_fw_mem &wlan_ce_mem>; memory-region = <&wlan_fw_mem>, <&wlan_ce_mem>; > + wifi-firmware { > + iommus = <&apps_smmu 0x1C02 0x1>; > + }; > + }; > -- > 2.7.4 > >
On 1/28/2022 4:09 PM, Kalle Valo wrote: > Manikanta Pubbisetty <quic_mpubbise@quicinc.com> writes: > >> Add WCN6750 wireless driver support, its based on ath11k driver. >> >> Signed-off-by: Manikanta Pubbisetty <quic_mpubbise@quicinc.com> > > Device tree bindings should be first in the patchset. > > I'm no DT expert, but you have a lot of changes in the bindings and it > would be nice to have some kind of description what you are doing here. > Sure.
On 2/8/2022 3:43 AM, Rob Herring wrote: > On Sun, Jan 16, 2022 at 06:17:15PM +0530, Manikanta Pubbisetty wrote: >> Add WCN6750 wireless driver support, its based on ath11k driver. > > As mentioned, provide a better commit message answering 'why'? > >> >> Signed-off-by: Manikanta Pubbisetty <quic_mpubbise@quicinc.com> >> --- >> .../bindings/net/wireless/qcom,ath11k.yaml | 365 +++++++++++++++------ >> 1 file changed, 257 insertions(+), 108 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/net/wireless/qcom,ath11k.yaml b/Documentation/devicetree/bindings/net/wireless/qcom,ath11k.yaml >> index cdf7b87..dba1434 100644 >> --- a/Documentation/devicetree/bindings/net/wireless/qcom,ath11k.yaml >> +++ b/Documentation/devicetree/bindings/net/wireless/qcom,ath11k.yaml >> @@ -20,120 +20,21 @@ properties: >> enum: >> - qcom,ipq8074-wifi >> - qcom,ipq6018-wifi >> + - qcom,wcn6750-wifi >> >> reg: >> maxItems: 1 >> >> - interrupts: >> - items: >> - - description: misc-pulse1 interrupt events >> - - description: misc-latch interrupt events >> - - description: sw exception interrupt events >> - - description: watchdog interrupt events >> - - description: interrupt event for ring CE0 >> - - description: interrupt event for ring CE1 >> - - description: interrupt event for ring CE2 >> - - description: interrupt event for ring CE3 >> - - description: interrupt event for ring CE4 >> - - description: interrupt event for ring CE5 >> - - description: interrupt event for ring CE6 >> - - description: interrupt event for ring CE7 >> - - description: interrupt event for ring CE8 >> - - description: interrupt event for ring CE9 >> - - description: interrupt event for ring CE10 >> - - description: interrupt event for ring CE11 >> - - description: interrupt event for ring host2wbm-desc-feed >> - - description: interrupt event for ring host2reo-re-injection >> - - description: interrupt event for ring host2reo-command >> - - description: interrupt event for ring host2rxdma-monitor-ring3 >> - - description: interrupt event for ring host2rxdma-monitor-ring2 >> - - description: interrupt event for ring host2rxdma-monitor-ring1 >> - - description: interrupt event for ring reo2ost-exception >> - - description: interrupt event for ring wbm2host-rx-release >> - - description: interrupt event for ring reo2host-status >> - - description: interrupt event for ring reo2host-destination-ring4 >> - - description: interrupt event for ring reo2host-destination-ring3 >> - - description: interrupt event for ring reo2host-destination-ring2 >> - - description: interrupt event for ring reo2host-destination-ring1 >> - - description: interrupt event for ring rxdma2host-monitor-destination-mac3 >> - - description: interrupt event for ring rxdma2host-monitor-destination-mac2 >> - - description: interrupt event for ring rxdma2host-monitor-destination-mac1 >> - - description: interrupt event for ring ppdu-end-interrupts-mac3 >> - - description: interrupt event for ring ppdu-end-interrupts-mac2 >> - - description: interrupt event for ring ppdu-end-interrupts-mac1 >> - - description: interrupt event for ring rxdma2host-monitor-status-ring-mac3 >> - - description: interrupt event for ring rxdma2host-monitor-status-ring-mac2 >> - - description: interrupt event for ring rxdma2host-monitor-status-ring-mac1 >> - - description: interrupt event for ring host2rxdma-host-buf-ring-mac3 >> - - description: interrupt event for ring host2rxdma-host-buf-ring-mac2 >> - - description: interrupt event for ring host2rxdma-host-buf-ring-mac1 >> - - description: interrupt event for ring rxdma2host-destination-ring-mac3 >> - - description: interrupt event for ring rxdma2host-destination-ring-mac2 >> - - description: interrupt event for ring rxdma2host-destination-ring-mac1 >> - - description: interrupt event for ring host2tcl-input-ring4 >> - - description: interrupt event for ring host2tcl-input-ring3 >> - - description: interrupt event for ring host2tcl-input-ring2 >> - - description: interrupt event for ring host2tcl-input-ring1 >> - - description: interrupt event for ring wbm2host-tx-completions-ring3 >> - - description: interrupt event for ring wbm2host-tx-completions-ring2 >> - - description: interrupt event for ring wbm2host-tx-completions-ring1 >> - - description: interrupt event for ring tcl2host-status-ring >> + reg-names: >> + maxItems: 1 > > Need to define the names though for 1 entry, -names is kind of > pointless. Makes sense, I'll remove this in the next revision. > >> >> + interrupts: >> + minItems: 32 >> + maxItems: 52 >> >> interrupt-names: >> - items: >> - - const: misc-pulse1 >> - - const: misc-latch >> - - const: sw-exception >> - - const: watchdog >> - - const: ce0 >> - - const: ce1 >> - - const: ce2 >> - - const: ce3 >> - - const: ce4 >> - - const: ce5 >> - - const: ce6 >> - - const: ce7 >> - - const: ce8 >> - - const: ce9 >> - - const: ce10 >> - - const: ce11 >> - - const: host2wbm-desc-feed >> - - const: host2reo-re-injection >> - - const: host2reo-command >> - - const: host2rxdma-monitor-ring3 >> - - const: host2rxdma-monitor-ring2 >> - - const: host2rxdma-monitor-ring1 >> - - const: reo2ost-exception >> - - const: wbm2host-rx-release >> - - const: reo2host-status >> - - const: reo2host-destination-ring4 >> - - const: reo2host-destination-ring3 >> - - const: reo2host-destination-ring2 >> - - const: reo2host-destination-ring1 >> - - const: rxdma2host-monitor-destination-mac3 >> - - const: rxdma2host-monitor-destination-mac2 >> - - const: rxdma2host-monitor-destination-mac1 >> - - const: ppdu-end-interrupts-mac3 >> - - const: ppdu-end-interrupts-mac2 >> - - const: ppdu-end-interrupts-mac1 >> - - const: rxdma2host-monitor-status-ring-mac3 >> - - const: rxdma2host-monitor-status-ring-mac2 >> - - const: rxdma2host-monitor-status-ring-mac1 >> - - const: host2rxdma-host-buf-ring-mac3 >> - - const: host2rxdma-host-buf-ring-mac2 >> - - const: host2rxdma-host-buf-ring-mac1 >> - - const: rxdma2host-destination-ring-mac3 >> - - const: rxdma2host-destination-ring-mac2 >> - - const: rxdma2host-destination-ring-mac1 >> - - const: host2tcl-input-ring4 >> - - const: host2tcl-input-ring3 >> - - const: host2tcl-input-ring2 >> - - const: host2tcl-input-ring1 >> - - const: wbm2host-tx-completions-ring3 >> - - const: wbm2host-tx-completions-ring2 >> - - const: wbm2host-tx-completions-ring1 >> - - const: tcl2host-status-ring >> + minItems: 32 >> + maxItems: 52 > > But you didn't define any names for the new chip. > In the case of new chip, interrupts are not tied for a specific purpose unlike the case of IPQ8074/IPQ6018 where the driver searches an IRQ based on name. That is the reason why interrupt-names are omitted for the new chip. >> >> qcom,rproc: >> $ref: /schemas/types.yaml#/definitions/phandle >> @@ -156,15 +57,201 @@ properties: >> phandle to a node describing reserved memory (System RAM memory) >> used by ath11k firmware (see bindings/reserved-memory/reserved-memory.txt) >> >> + iommus: >> + maxItems: 1 >> + >> + wifi-firmware: >> + type: object >> + description: | >> + WCN6750 wifi node can contain one optional firmware subnode. >> + Firmware subnode is needed when the platform does not have TustZone. > > Trustzone > I'll change it. >> + properties: >> + iommus: >> + maxItems: 1 > > If this is the only property, then just make parent 'iommus' 1 or 2 > entries. > You mean something like this shown below? iommus: minItems: 1 maxItems: 2 wifi-firmware: type: object description: | WCN6750 wifi node can contain one optional firmware subnode. Firmware subnode is needed when the platform does not have Tustzone. required: - iommus >> + required: >> + - iommus >> + >> required: >> - compatible >> - reg >> - interrupts >> - - interrupt-names >> - qcom,rproc >> >> additionalProperties: false >> >> +allOf: >> + - if: >> + properties: >> + compatible: >> + contains: >> + enum: >> + - qcom,ipq8074-wifi >> + - qcom,ipq6018-wifi >> + then: >> + properties: >> + interrupts: >> + items: >> + - description: misc-pulse1 interrupt events >> + - description: misc-latch interrupt events >> + - description: sw exception interrupt events >> + - description: watchdog interrupt events >> + - description: interrupt event for ring CE0 >> + - description: interrupt event for ring CE1 >> + - description: interrupt event for ring CE2 >> + - description: interrupt event for ring CE3 >> + - description: interrupt event for ring CE4 >> + - description: interrupt event for ring CE5 >> + - description: interrupt event for ring CE6 >> + - description: interrupt event for ring CE7 >> + - description: interrupt event for ring CE8 >> + - description: interrupt event for ring CE9 >> + - description: interrupt event for ring CE10 >> + - description: interrupt event for ring CE11 >> + - description: interrupt event for ring host2wbm-desc-feed >> + - description: interrupt event for ring host2reo-re-injection >> + - description: interrupt event for ring host2reo-command >> + - description: interrupt event for ring host2rxdma-monitor-ring3 >> + - description: interrupt event for ring host2rxdma-monitor-ring2 >> + - description: interrupt event for ring host2rxdma-monitor-ring1 >> + - description: interrupt event for ring reo2ost-exception >> + - description: interrupt event for ring wbm2host-rx-release >> + - description: interrupt event for ring reo2host-status >> + - description: interrupt event for ring reo2host-destination-ring4 >> + - description: interrupt event for ring reo2host-destination-ring3 >> + - description: interrupt event for ring reo2host-destination-ring2 >> + - description: interrupt event for ring reo2host-destination-ring1 >> + - description: interrupt event for ring rxdma2host-monitor-destination-mac3 >> + - description: interrupt event for ring rxdma2host-monitor-destination-mac2 >> + - description: interrupt event for ring rxdma2host-monitor-destination-mac1 >> + - description: interrupt event for ring ppdu-end-interrupts-mac3 >> + - description: interrupt event for ring ppdu-end-interrupts-mac2 >> + - description: interrupt event for ring ppdu-end-interrupts-mac1 >> + - description: interrupt event for ring rxdma2host-monitor-status-ring-mac3 >> + - description: interrupt event for ring rxdma2host-monitor-status-ring-mac2 >> + - description: interrupt event for ring rxdma2host-monitor-status-ring-mac1 >> + - description: interrupt event for ring host2rxdma-host-buf-ring-mac3 >> + - description: interrupt event for ring host2rxdma-host-buf-ring-mac2 >> + - description: interrupt event for ring host2rxdma-host-buf-ring-mac1 >> + - description: interrupt event for ring rxdma2host-destination-ring-mac3 >> + - description: interrupt event for ring rxdma2host-destination-ring-mac2 >> + - description: interrupt event for ring rxdma2host-destination-ring-mac1 >> + - description: interrupt event for ring host2tcl-input-ring4 >> + - description: interrupt event for ring host2tcl-input-ring3 >> + - description: interrupt event for ring host2tcl-input-ring2 >> + - description: interrupt event for ring host2tcl-input-ring1 >> + - description: interrupt event for ring wbm2host-tx-completions-ring3 >> + - description: interrupt event for ring wbm2host-tx-completions-ring2 >> + - description: interrupt event for ring wbm2host-tx-completions-ring1 >> + - description: interrupt event for ring tcl2host-status-ring >> + interrupt-names: >> + items: >> + - const: misc-pulse1 >> + - const: misc-latch >> + - const: sw-exception >> + - const: watchdog >> + - const: ce0 >> + - const: ce1 >> + - const: ce2 >> + - const: ce3 >> + - const: ce4 >> + - const: ce5 >> + - const: ce6 >> + - const: ce7 >> + - const: ce8 >> + - const: ce9 >> + - const: ce10 >> + - const: ce11 >> + - const: host2wbm-desc-feed >> + - const: host2reo-re-injection >> + - const: host2reo-command >> + - const: host2rxdma-monitor-ring3 >> + - const: host2rxdma-monitor-ring2 >> + - const: host2rxdma-monitor-ring1 >> + - const: reo2ost-exception >> + - const: wbm2host-rx-release >> + - const: reo2host-status >> + - const: reo2host-destination-ring4 >> + - const: reo2host-destination-ring3 >> + - const: reo2host-destination-ring2 >> + - const: reo2host-destination-ring1 >> + - const: rxdma2host-monitor-destination-mac3 >> + - const: rxdma2host-monitor-destination-mac2 >> + - const: rxdma2host-monitor-destination-mac1 >> + - const: ppdu-end-interrupts-mac3 >> + - const: ppdu-end-interrupts-mac2 >> + - const: ppdu-end-interrupts-mac1 >> + - const: rxdma2host-monitor-status-ring-mac3 >> + - const: rxdma2host-monitor-status-ring-mac2 >> + - const: rxdma2host-monitor-status-ring-mac1 >> + - const: host2rxdma-host-buf-ring-mac3 >> + - const: host2rxdma-host-buf-ring-mac2 >> + - const: host2rxdma-host-buf-ring-mac1 >> + - const: rxdma2host-destination-ring-mac3 >> + - const: rxdma2host-destination-ring-mac2 >> + - const: rxdma2host-destination-ring-mac1 >> + - const: host2tcl-input-ring4 >> + - const: host2tcl-input-ring3 >> + - const: host2tcl-input-ring2 >> + - const: host2tcl-input-ring1 >> + - const: wbm2host-tx-completions-ring3 >> + - const: wbm2host-tx-completions-ring2 >> + - const: wbm2host-tx-completions-ring1 >> + - const: tcl2host-status-ring >> + >> + - if: >> + properties: >> + compatible: >> + contains: >> + enum: >> + - qcom,ipq8074-wifi >> + - qcom,ipq6018-wifi >> + then: >> + required: >> + - interrupt-names >> + >> + - if: >> + properties: >> + compatible: >> + contains: >> + enum: >> + - qcom,wcn6750-wifi >> + then: >> + properties: >> + interrupts: >> + items: >> + - description: interrupt event for ring CE1 >> + - description: interrupt event for ring CE2 >> + - description: interrupt event for ring CE3 >> + - description: interrupt event for ring CE4 >> + - description: interrupt event for ring CE5 >> + - description: interrupt event for ring CE6 >> + - description: interrupt event for ring CE7 >> + - description: interrupt event for ring CE8 >> + - description: interrupt event for ring CE9 >> + - description: interrupt event for ring CE10 >> + - description: interrupt event for ring DP1 >> + - description: interrupt event for ring DP2 >> + - description: interrupt event for ring DP3 >> + - description: interrupt event for ring DP4 >> + - description: interrupt event for ring DP5 >> + - description: interrupt event for ring DP6 >> + - description: interrupt event for ring DP7 >> + - description: interrupt event for ring DP8 >> + - description: interrupt event for ring DP9 >> + - description: interrupt event for ring DP10 >> + - description: interrupt event for ring DP11 >> + - description: interrupt event for ring DP12 >> + - description: interrupt event for ring DP13 >> + - description: interrupt event for ring DP14 >> + - description: interrupt event for ring DP15 >> + - description: interrupt event for ring DP16 >> + - description: interrupt event for ring DP17 >> + - description: interrupt event for ring DP18 >> + - description: interrupt event for ring DP19 >> + - description: interrupt event for ring DP20 >> + - description: interrupt event for ring DP21 >> + - description: interrupt event for ring DP22 >> + >> examples: >> - | >> >> @@ -309,3 +396,65 @@ examples: >> }; >> }; >> }; >> + >> + - | >> + #include <dt-bindings/interrupt-controller/arm-gic.h> >> + >> + reserved-memory { >> + #address-cells = <2>; >> + #size-cells = <2>; >> + >> + wlan_ce_mem: wlan_ce_mem@4cd000 { >> + no-map; >> + reg = <0x0 0x4cd000 0x0 0x1000>; >> + }; >> + >> + wlan_fw_mem: wlan_fw_mem@80c00000 { >> + no-map; >> + reg = <0x0 0x80c00000 0x0 0xc00000>; >> + }; >> + }; >> + >> + wifi: wifi@17a10040 { >> + compatible = "qcom,wcn6750-wifi"; >> + reg = <0x17A10040 0x0>; >> + reg-names = "msi_addr"; >> + iommus = <&apps_smmu 0x1C00 0x1>; >> + interrupts = <GIC_SPI 768 IRQ_TYPE_EDGE_RISING>, >> + <GIC_SPI 769 IRQ_TYPE_EDGE_RISING>, >> + <GIC_SPI 770 IRQ_TYPE_EDGE_RISING>, >> + <GIC_SPI 771 IRQ_TYPE_EDGE_RISING>, >> + <GIC_SPI 772 IRQ_TYPE_EDGE_RISING>, >> + <GIC_SPI 773 IRQ_TYPE_EDGE_RISING>, >> + <GIC_SPI 774 IRQ_TYPE_EDGE_RISING>, >> + <GIC_SPI 775 IRQ_TYPE_EDGE_RISING>, >> + <GIC_SPI 776 IRQ_TYPE_EDGE_RISING>, >> + <GIC_SPI 777 IRQ_TYPE_EDGE_RISING>, >> + <GIC_SPI 778 IRQ_TYPE_EDGE_RISING>, >> + <GIC_SPI 779 IRQ_TYPE_EDGE_RISING>, >> + <GIC_SPI 780 IRQ_TYPE_EDGE_RISING>, >> + <GIC_SPI 781 IRQ_TYPE_EDGE_RISING>, >> + <GIC_SPI 782 IRQ_TYPE_EDGE_RISING>, >> + <GIC_SPI 783 IRQ_TYPE_EDGE_RISING>, >> + <GIC_SPI 784 IRQ_TYPE_EDGE_RISING>, >> + <GIC_SPI 785 IRQ_TYPE_EDGE_RISING>, >> + <GIC_SPI 786 IRQ_TYPE_EDGE_RISING>, >> + <GIC_SPI 787 IRQ_TYPE_EDGE_RISING>, >> + <GIC_SPI 788 IRQ_TYPE_EDGE_RISING>, >> + <GIC_SPI 789 IRQ_TYPE_EDGE_RISING>, >> + <GIC_SPI 790 IRQ_TYPE_EDGE_RISING>, >> + <GIC_SPI 791 IRQ_TYPE_EDGE_RISING>, >> + <GIC_SPI 792 IRQ_TYPE_EDGE_RISING>, >> + <GIC_SPI 793 IRQ_TYPE_EDGE_RISING>, >> + <GIC_SPI 794 IRQ_TYPE_EDGE_RISING>, >> + <GIC_SPI 795 IRQ_TYPE_EDGE_RISING>, >> + <GIC_SPI 796 IRQ_TYPE_EDGE_RISING>, >> + <GIC_SPI 797 IRQ_TYPE_EDGE_RISING>, >> + <GIC_SPI 798 IRQ_TYPE_EDGE_RISING>, >> + <GIC_SPI 799 IRQ_TYPE_EDGE_RISING>; >> + qcom,rproc = <&remoteproc_wpss>; >> + memory-region = <&wlan_fw_mem &wlan_ce_mem>; > > memory-region = <&wlan_fw_mem>, <&wlan_ce_mem>; > Okay. >> + wifi-firmware { >> + iommus = <&apps_smmu 0x1C02 0x1>; >> + }; >> + }; >> -- >> 2.7.4 >> >>
diff --git a/Documentation/devicetree/bindings/net/wireless/qcom,ath11k.yaml b/Documentation/devicetree/bindings/net/wireless/qcom,ath11k.yaml index cdf7b87..dba1434 100644 --- a/Documentation/devicetree/bindings/net/wireless/qcom,ath11k.yaml +++ b/Documentation/devicetree/bindings/net/wireless/qcom,ath11k.yaml @@ -20,120 +20,21 @@ properties: enum: - qcom,ipq8074-wifi - qcom,ipq6018-wifi + - qcom,wcn6750-wifi reg: maxItems: 1 - interrupts: - items: - - description: misc-pulse1 interrupt events - - description: misc-latch interrupt events - - description: sw exception interrupt events - - description: watchdog interrupt events - - description: interrupt event for ring CE0 - - description: interrupt event for ring CE1 - - description: interrupt event for ring CE2 - - description: interrupt event for ring CE3 - - description: interrupt event for ring CE4 - - description: interrupt event for ring CE5 - - description: interrupt event for ring CE6 - - description: interrupt event for ring CE7 - - description: interrupt event for ring CE8 - - description: interrupt event for ring CE9 - - description: interrupt event for ring CE10 - - description: interrupt event for ring CE11 - - description: interrupt event for ring host2wbm-desc-feed - - description: interrupt event for ring host2reo-re-injection - - description: interrupt event for ring host2reo-command - - description: interrupt event for ring host2rxdma-monitor-ring3 - - description: interrupt event for ring host2rxdma-monitor-ring2 - - description: interrupt event for ring host2rxdma-monitor-ring1 - - description: interrupt event for ring reo2ost-exception - - description: interrupt event for ring wbm2host-rx-release - - description: interrupt event for ring reo2host-status - - description: interrupt event for ring reo2host-destination-ring4 - - description: interrupt event for ring reo2host-destination-ring3 - - description: interrupt event for ring reo2host-destination-ring2 - - description: interrupt event for ring reo2host-destination-ring1 - - description: interrupt event for ring rxdma2host-monitor-destination-mac3 - - description: interrupt event for ring rxdma2host-monitor-destination-mac2 - - description: interrupt event for ring rxdma2host-monitor-destination-mac1 - - description: interrupt event for ring ppdu-end-interrupts-mac3 - - description: interrupt event for ring ppdu-end-interrupts-mac2 - - description: interrupt event for ring ppdu-end-interrupts-mac1 - - description: interrupt event for ring rxdma2host-monitor-status-ring-mac3 - - description: interrupt event for ring rxdma2host-monitor-status-ring-mac2 - - description: interrupt event for ring rxdma2host-monitor-status-ring-mac1 - - description: interrupt event for ring host2rxdma-host-buf-ring-mac3 - - description: interrupt event for ring host2rxdma-host-buf-ring-mac2 - - description: interrupt event for ring host2rxdma-host-buf-ring-mac1 - - description: interrupt event for ring rxdma2host-destination-ring-mac3 - - description: interrupt event for ring rxdma2host-destination-ring-mac2 - - description: interrupt event for ring rxdma2host-destination-ring-mac1 - - description: interrupt event for ring host2tcl-input-ring4 - - description: interrupt event for ring host2tcl-input-ring3 - - description: interrupt event for ring host2tcl-input-ring2 - - description: interrupt event for ring host2tcl-input-ring1 - - description: interrupt event for ring wbm2host-tx-completions-ring3 - - description: interrupt event for ring wbm2host-tx-completions-ring2 - - description: interrupt event for ring wbm2host-tx-completions-ring1 - - description: interrupt event for ring tcl2host-status-ring + reg-names: + maxItems: 1 + interrupts: + minItems: 32 + maxItems: 52 interrupt-names: - items: - - const: misc-pulse1 - - const: misc-latch - - const: sw-exception - - const: watchdog - - const: ce0 - - const: ce1 - - const: ce2 - - const: ce3 - - const: ce4 - - const: ce5 - - const: ce6 - - const: ce7 - - const: ce8 - - const: ce9 - - const: ce10 - - const: ce11 - - const: host2wbm-desc-feed - - const: host2reo-re-injection - - const: host2reo-command - - const: host2rxdma-monitor-ring3 - - const: host2rxdma-monitor-ring2 - - const: host2rxdma-monitor-ring1 - - const: reo2ost-exception - - const: wbm2host-rx-release - - const: reo2host-status - - const: reo2host-destination-ring4 - - const: reo2host-destination-ring3 - - const: reo2host-destination-ring2 - - const: reo2host-destination-ring1 - - const: rxdma2host-monitor-destination-mac3 - - const: rxdma2host-monitor-destination-mac2 - - const: rxdma2host-monitor-destination-mac1 - - const: ppdu-end-interrupts-mac3 - - const: ppdu-end-interrupts-mac2 - - const: ppdu-end-interrupts-mac1 - - const: rxdma2host-monitor-status-ring-mac3 - - const: rxdma2host-monitor-status-ring-mac2 - - const: rxdma2host-monitor-status-ring-mac1 - - const: host2rxdma-host-buf-ring-mac3 - - const: host2rxdma-host-buf-ring-mac2 - - const: host2rxdma-host-buf-ring-mac1 - - const: rxdma2host-destination-ring-mac3 - - const: rxdma2host-destination-ring-mac2 - - const: rxdma2host-destination-ring-mac1 - - const: host2tcl-input-ring4 - - const: host2tcl-input-ring3 - - const: host2tcl-input-ring2 - - const: host2tcl-input-ring1 - - const: wbm2host-tx-completions-ring3 - - const: wbm2host-tx-completions-ring2 - - const: wbm2host-tx-completions-ring1 - - const: tcl2host-status-ring + minItems: 32 + maxItems: 52 qcom,rproc: $ref: /schemas/types.yaml#/definitions/phandle @@ -156,15 +57,201 @@ properties: phandle to a node describing reserved memory (System RAM memory) used by ath11k firmware (see bindings/reserved-memory/reserved-memory.txt) + iommus: + maxItems: 1 + + wifi-firmware: + type: object + description: | + WCN6750 wifi node can contain one optional firmware subnode. + Firmware subnode is needed when the platform does not have TustZone. + properties: + iommus: + maxItems: 1 + required: + - iommus + required: - compatible - reg - interrupts - - interrupt-names - qcom,rproc additionalProperties: false +allOf: + - if: + properties: + compatible: + contains: + enum: + - qcom,ipq8074-wifi + - qcom,ipq6018-wifi + then: + properties: + interrupts: + items: + - description: misc-pulse1 interrupt events + - description: misc-latch interrupt events + - description: sw exception interrupt events + - description: watchdog interrupt events + - description: interrupt event for ring CE0 + - description: interrupt event for ring CE1 + - description: interrupt event for ring CE2 + - description: interrupt event for ring CE3 + - description: interrupt event for ring CE4 + - description: interrupt event for ring CE5 + - description: interrupt event for ring CE6 + - description: interrupt event for ring CE7 + - description: interrupt event for ring CE8 + - description: interrupt event for ring CE9 + - description: interrupt event for ring CE10 + - description: interrupt event for ring CE11 + - description: interrupt event for ring host2wbm-desc-feed + - description: interrupt event for ring host2reo-re-injection + - description: interrupt event for ring host2reo-command + - description: interrupt event for ring host2rxdma-monitor-ring3 + - description: interrupt event for ring host2rxdma-monitor-ring2 + - description: interrupt event for ring host2rxdma-monitor-ring1 + - description: interrupt event for ring reo2ost-exception + - description: interrupt event for ring wbm2host-rx-release + - description: interrupt event for ring reo2host-status + - description: interrupt event for ring reo2host-destination-ring4 + - description: interrupt event for ring reo2host-destination-ring3 + - description: interrupt event for ring reo2host-destination-ring2 + - description: interrupt event for ring reo2host-destination-ring1 + - description: interrupt event for ring rxdma2host-monitor-destination-mac3 + - description: interrupt event for ring rxdma2host-monitor-destination-mac2 + - description: interrupt event for ring rxdma2host-monitor-destination-mac1 + - description: interrupt event for ring ppdu-end-interrupts-mac3 + - description: interrupt event for ring ppdu-end-interrupts-mac2 + - description: interrupt event for ring ppdu-end-interrupts-mac1 + - description: interrupt event for ring rxdma2host-monitor-status-ring-mac3 + - description: interrupt event for ring rxdma2host-monitor-status-ring-mac2 + - description: interrupt event for ring rxdma2host-monitor-status-ring-mac1 + - description: interrupt event for ring host2rxdma-host-buf-ring-mac3 + - description: interrupt event for ring host2rxdma-host-buf-ring-mac2 + - description: interrupt event for ring host2rxdma-host-buf-ring-mac1 + - description: interrupt event for ring rxdma2host-destination-ring-mac3 + - description: interrupt event for ring rxdma2host-destination-ring-mac2 + - description: interrupt event for ring rxdma2host-destination-ring-mac1 + - description: interrupt event for ring host2tcl-input-ring4 + - description: interrupt event for ring host2tcl-input-ring3 + - description: interrupt event for ring host2tcl-input-ring2 + - description: interrupt event for ring host2tcl-input-ring1 + - description: interrupt event for ring wbm2host-tx-completions-ring3 + - description: interrupt event for ring wbm2host-tx-completions-ring2 + - description: interrupt event for ring wbm2host-tx-completions-ring1 + - description: interrupt event for ring tcl2host-status-ring + interrupt-names: + items: + - const: misc-pulse1 + - const: misc-latch + - const: sw-exception + - const: watchdog + - const: ce0 + - const: ce1 + - const: ce2 + - const: ce3 + - const: ce4 + - const: ce5 + - const: ce6 + - const: ce7 + - const: ce8 + - const: ce9 + - const: ce10 + - const: ce11 + - const: host2wbm-desc-feed + - const: host2reo-re-injection + - const: host2reo-command + - const: host2rxdma-monitor-ring3 + - const: host2rxdma-monitor-ring2 + - const: host2rxdma-monitor-ring1 + - const: reo2ost-exception + - const: wbm2host-rx-release + - const: reo2host-status + - const: reo2host-destination-ring4 + - const: reo2host-destination-ring3 + - const: reo2host-destination-ring2 + - const: reo2host-destination-ring1 + - const: rxdma2host-monitor-destination-mac3 + - const: rxdma2host-monitor-destination-mac2 + - const: rxdma2host-monitor-destination-mac1 + - const: ppdu-end-interrupts-mac3 + - const: ppdu-end-interrupts-mac2 + - const: ppdu-end-interrupts-mac1 + - const: rxdma2host-monitor-status-ring-mac3 + - const: rxdma2host-monitor-status-ring-mac2 + - const: rxdma2host-monitor-status-ring-mac1 + - const: host2rxdma-host-buf-ring-mac3 + - const: host2rxdma-host-buf-ring-mac2 + - const: host2rxdma-host-buf-ring-mac1 + - const: rxdma2host-destination-ring-mac3 + - const: rxdma2host-destination-ring-mac2 + - const: rxdma2host-destination-ring-mac1 + - const: host2tcl-input-ring4 + - const: host2tcl-input-ring3 + - const: host2tcl-input-ring2 + - const: host2tcl-input-ring1 + - const: wbm2host-tx-completions-ring3 + - const: wbm2host-tx-completions-ring2 + - const: wbm2host-tx-completions-ring1 + - const: tcl2host-status-ring + + - if: + properties: + compatible: + contains: + enum: + - qcom,ipq8074-wifi + - qcom,ipq6018-wifi + then: + required: + - interrupt-names + + - if: + properties: + compatible: + contains: + enum: + - qcom,wcn6750-wifi + then: + properties: + interrupts: + items: + - description: interrupt event for ring CE1 + - description: interrupt event for ring CE2 + - description: interrupt event for ring CE3 + - description: interrupt event for ring CE4 + - description: interrupt event for ring CE5 + - description: interrupt event for ring CE6 + - description: interrupt event for ring CE7 + - description: interrupt event for ring CE8 + - description: interrupt event for ring CE9 + - description: interrupt event for ring CE10 + - description: interrupt event for ring DP1 + - description: interrupt event for ring DP2 + - description: interrupt event for ring DP3 + - description: interrupt event for ring DP4 + - description: interrupt event for ring DP5 + - description: interrupt event for ring DP6 + - description: interrupt event for ring DP7 + - description: interrupt event for ring DP8 + - description: interrupt event for ring DP9 + - description: interrupt event for ring DP10 + - description: interrupt event for ring DP11 + - description: interrupt event for ring DP12 + - description: interrupt event for ring DP13 + - description: interrupt event for ring DP14 + - description: interrupt event for ring DP15 + - description: interrupt event for ring DP16 + - description: interrupt event for ring DP17 + - description: interrupt event for ring DP18 + - description: interrupt event for ring DP19 + - description: interrupt event for ring DP20 + - description: interrupt event for ring DP21 + - description: interrupt event for ring DP22 + examples: - | @@ -309,3 +396,65 @@ examples: }; }; }; + + - | + #include <dt-bindings/interrupt-controller/arm-gic.h> + + reserved-memory { + #address-cells = <2>; + #size-cells = <2>; + + wlan_ce_mem: wlan_ce_mem@4cd000 { + no-map; + reg = <0x0 0x4cd000 0x0 0x1000>; + }; + + wlan_fw_mem: wlan_fw_mem@80c00000 { + no-map; + reg = <0x0 0x80c00000 0x0 0xc00000>; + }; + }; + + wifi: wifi@17a10040 { + compatible = "qcom,wcn6750-wifi"; + reg = <0x17A10040 0x0>; + reg-names = "msi_addr"; + iommus = <&apps_smmu 0x1C00 0x1>; + interrupts = <GIC_SPI 768 IRQ_TYPE_EDGE_RISING>, + <GIC_SPI 769 IRQ_TYPE_EDGE_RISING>, + <GIC_SPI 770 IRQ_TYPE_EDGE_RISING>, + <GIC_SPI 771 IRQ_TYPE_EDGE_RISING>, + <GIC_SPI 772 IRQ_TYPE_EDGE_RISING>, + <GIC_SPI 773 IRQ_TYPE_EDGE_RISING>, + <GIC_SPI 774 IRQ_TYPE_EDGE_RISING>, + <GIC_SPI 775 IRQ_TYPE_EDGE_RISING>, + <GIC_SPI 776 IRQ_TYPE_EDGE_RISING>, + <GIC_SPI 777 IRQ_TYPE_EDGE_RISING>, + <GIC_SPI 778 IRQ_TYPE_EDGE_RISING>, + <GIC_SPI 779 IRQ_TYPE_EDGE_RISING>, + <GIC_SPI 780 IRQ_TYPE_EDGE_RISING>, + <GIC_SPI 781 IRQ_TYPE_EDGE_RISING>, + <GIC_SPI 782 IRQ_TYPE_EDGE_RISING>, + <GIC_SPI 783 IRQ_TYPE_EDGE_RISING>, + <GIC_SPI 784 IRQ_TYPE_EDGE_RISING>, + <GIC_SPI 785 IRQ_TYPE_EDGE_RISING>, + <GIC_SPI 786 IRQ_TYPE_EDGE_RISING>, + <GIC_SPI 787 IRQ_TYPE_EDGE_RISING>, + <GIC_SPI 788 IRQ_TYPE_EDGE_RISING>, + <GIC_SPI 789 IRQ_TYPE_EDGE_RISING>, + <GIC_SPI 790 IRQ_TYPE_EDGE_RISING>, + <GIC_SPI 791 IRQ_TYPE_EDGE_RISING>, + <GIC_SPI 792 IRQ_TYPE_EDGE_RISING>, + <GIC_SPI 793 IRQ_TYPE_EDGE_RISING>, + <GIC_SPI 794 IRQ_TYPE_EDGE_RISING>, + <GIC_SPI 795 IRQ_TYPE_EDGE_RISING>, + <GIC_SPI 796 IRQ_TYPE_EDGE_RISING>, + <GIC_SPI 797 IRQ_TYPE_EDGE_RISING>, + <GIC_SPI 798 IRQ_TYPE_EDGE_RISING>, + <GIC_SPI 799 IRQ_TYPE_EDGE_RISING>; + qcom,rproc = <&remoteproc_wpss>; + memory-region = <&wlan_fw_mem &wlan_ce_mem>; + wifi-firmware { + iommus = <&apps_smmu 0x1C02 0x1>; + }; + };
Add WCN6750 wireless driver support, its based on ath11k driver. Signed-off-by: Manikanta Pubbisetty <quic_mpubbise@quicinc.com> --- .../bindings/net/wireless/qcom,ath11k.yaml | 365 +++++++++++++++------ 1 file changed, 257 insertions(+), 108 deletions(-)