| Message ID | 20220302225411.2456001-2-dmitry.baryshkov@linaro.org (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [v2,1/6] arm64: dts: qcom: msm8996: Drop flags for mdss irqs | expand |
On 3/2/2022 2:54 PM, Dmitry Baryshkov wrote: > The number of interrupt cells for the mdss interrupt controller is 1, > meaning there should only be one cell for the interrupt number, not two. > Drop the second cell containing (unused) irq flags. > > Reviewed-by: Stephen Boyd <swboyd@chromium.org> > Fixes: b52555d590d1 ("arm64: dts: qcom: sdm630: Add MDSS nodes") > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com> > --- > arch/arm64/boot/dts/qcom/sdm630.dtsi | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/sdm630.dtsi b/arch/arm64/boot/dts/qcom/sdm630.dtsi > index 240293592ef9..7f875bf9390a 100644 > --- a/arch/arm64/boot/dts/qcom/sdm630.dtsi > +++ b/arch/arm64/boot/dts/qcom/sdm630.dtsi > @@ -1453,7 +1453,7 @@ mdp: mdp@c901000 { > reg-names = "mdp_phys"; > > interrupt-parent = <&mdss>; > - interrupts = <0 IRQ_TYPE_LEVEL_HIGH>; > + interrupts = <0>; > > assigned-clocks = <&mmcc MDSS_MDP_CLK>, > <&mmcc MDSS_VSYNC_CLK>; > @@ -1530,7 +1530,7 @@ dsi0: dsi@c994000 { > power-domains = <&rpmpd SDM660_VDDCX>; > > interrupt-parent = <&mdss>; > - interrupts = <4 IRQ_TYPE_LEVEL_HIGH>; > + interrupts = <4>; > > assigned-clocks = <&mmcc BYTE0_CLK_SRC>, > <&mmcc PCLK0_CLK_SRC>;
On 2022-03-03 01:54:07, Dmitry Baryshkov wrote: > The number of interrupt cells for the mdss interrupt controller is 1, > meaning there should only be one cell for the interrupt number, not two. > Drop the second cell containing (unused) irq flags. > > Reviewed-by: Stephen Boyd <swboyd@chromium.org> > Fixes: b52555d590d1 ("arm64: dts: qcom: sdm630: Add MDSS nodes") > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> Thanks for adding the Fixes: tag. Reviewed-by: Marijn Suijten <marijn.suijten@somainline.org> Nit: Robh also removed the trailing empty newline in his patch: https://lore.kernel.org/linux-arm-msm/20220302013339.2354076-1-robh@kernel.org/ > --- > arch/arm64/boot/dts/qcom/sdm630.dtsi | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/sdm630.dtsi b/arch/arm64/boot/dts/qcom/sdm630.dtsi > index 240293592ef9..7f875bf9390a 100644 > --- a/arch/arm64/boot/dts/qcom/sdm630.dtsi > +++ b/arch/arm64/boot/dts/qcom/sdm630.dtsi > @@ -1453,7 +1453,7 @@ mdp: mdp@c901000 { > reg-names = "mdp_phys"; > > interrupt-parent = <&mdss>; > - interrupts = <0 IRQ_TYPE_LEVEL_HIGH>; > + interrupts = <0>; > > assigned-clocks = <&mmcc MDSS_MDP_CLK>, > <&mmcc MDSS_VSYNC_CLK>; > @@ -1530,7 +1530,7 @@ dsi0: dsi@c994000 { > power-domains = <&rpmpd SDM660_VDDCX>; > > interrupt-parent = <&mdss>; > - interrupts = <4 IRQ_TYPE_LEVEL_HIGH>; > + interrupts = <4>; > > assigned-clocks = <&mmcc BYTE0_CLK_SRC>, > <&mmcc PCLK0_CLK_SRC>; > -- > 2.34.1 >
diff --git a/arch/arm64/boot/dts/qcom/sdm630.dtsi b/arch/arm64/boot/dts/qcom/sdm630.dtsi index 240293592ef9..7f875bf9390a 100644 --- a/arch/arm64/boot/dts/qcom/sdm630.dtsi +++ b/arch/arm64/boot/dts/qcom/sdm630.dtsi @@ -1453,7 +1453,7 @@ mdp: mdp@c901000 { reg-names = "mdp_phys"; interrupt-parent = <&mdss>; - interrupts = <0 IRQ_TYPE_LEVEL_HIGH>; + interrupts = <0>; assigned-clocks = <&mmcc MDSS_MDP_CLK>, <&mmcc MDSS_VSYNC_CLK>; @@ -1530,7 +1530,7 @@ dsi0: dsi@c994000 { power-domains = <&rpmpd SDM660_VDDCX>; interrupt-parent = <&mdss>; - interrupts = <4 IRQ_TYPE_LEVEL_HIGH>; + interrupts = <4>; assigned-clocks = <&mmcc BYTE0_CLK_SRC>, <&mmcc PCLK0_CLK_SRC>;