mbox series

[v2,0/2] rtl8xxxu: Fill up more TX information

Message ID 20220318024216.42204-1-chris.chiu@canonical.com (mailing list archive)
Headers show
Series rtl8xxxu: Fill up more TX information | expand

Message

Chris Chiu March 18, 2022, 2:42 a.m. UTC 
The antenna information is missing in rtl8xxxu and txrate is NULL
in 8188cu and 8192cu. Fill up the missing information for iw
commands.

Chris Chiu (2):
  rtl8xxxu: feed antenna information for cfg80211
  rtl8xxxu: fill up txrate info for gen1 chips

 .../wireless/realtek/rtl8xxxu/rtl8xxxu_core.c | 75 +++++++++++++++++++
 1 file changed, 75 insertions(+)

Comments

Reto Schneider March 18, 2022, 6:55 a.m. UTC | #1 
Hi

On 18.03.22 03:42, Chris Chiu wrote:
> The antenna information is missing in rtl8xxxu and txrate is NULL
> in 8188cu and 8192cu. Fill up the missing information for iw
> commands.

I tested older versions of this and it worked well. Will give this set a 
try during next week.

Kind regards,
Reto
Reto Schneider March 24, 2022, 4:32 p.m. UTC | #2 
On 18.03.22 03:42, Chris Chiu wrote:
> The antenna information is missing in rtl8xxxu and txrate is NULL
> in 8188cu and 8192cu. Fill up the missing information for iw
> commands.
> 
> Chris Chiu (2):
>    rtl8xxxu: feed antenna information for cfg80211
>    rtl8xxxu: fill up txrate info for gen1 chips
> 
>   .../wireless/realtek/rtl8xxxu/rtl8xxxu_core.c | 75 +++++++++++++++++++
>   1 file changed, 75 insertions(+)
> 

Those two patches applied to most recent master 
(v5.17-4443-ged4643521e6a) do not compile as rtl8xxxu_legacy_ratetable[] 
and rtl8xxxu_desc_to_mcsrate() are defined twice.

Kind regards,
Reto
Chris Chiu March 25, 2022, 4:02 a.m. UTC | #3 
On Fri, Mar 25, 2022 at 12:32 AM Reto Schneider <code@reto-schneider.ch> wrote:
>
>
> On 18.03.22 03:42, Chris Chiu wrote:
> > The antenna information is missing in rtl8xxxu and txrate is NULL
> > in 8188cu and 8192cu. Fill up the missing information for iw
> > commands.
> >
> > Chris Chiu (2):
> >    rtl8xxxu: feed antenna information for cfg80211
> >    rtl8xxxu: fill up txrate info for gen1 chips
> >
> >   .../wireless/realtek/rtl8xxxu/rtl8xxxu_core.c | 75 +++++++++++++++++++
> >   1 file changed, 75 insertions(+)
> >
>
> Those two patches applied to most recent master
> (v5.17-4443-ged4643521e6a) do not compile as rtl8xxxu_legacy_ratetable[]
> and rtl8xxxu_desc_to_mcsrate() are defined twice.
>
> Kind regards,
> Reto

Thanks for pointing this out. I'll fix it in v3.

Chris