| Message ID | 20220216195030.GA904170@embeddedor (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | c5f675748cf0e1db5ba5514e1f34360dfb95a6ba |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | [next] iwlwifi: mei: Replace zero-length array with flexible-array member | expand |
On Wed, Feb 16, 2022 at 01:50:30PM -0600, Gustavo A. R. Silva wrote: > There is a regular need in the kernel to provide a way to declare > having a dynamically sized set of trailing elements in a structure. > Kernel code should always use “flexible array members”[1] for these > cases. The older style of one-element or zero-length arrays should > no longer be used[2]. > > [1] https://en.wikipedia.org/wiki/Flexible_array_member > [2] https://www.kernel.org/doc/html/v5.16/process/deprecated.html#zero-length-and-one-element-arrays > > Link: https://github.com/KSPP/linux/issues/78 > Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org> Reviewed-by: Kees Cook <keescook@chromium.org>
On Wed, Feb 16, 2022 at 12:35:22PM -0800, Kees Cook wrote: > On Wed, Feb 16, 2022 at 01:50:30PM -0600, Gustavo A. R. Silva wrote: > > There is a regular need in the kernel to provide a way to declare > > having a dynamically sized set of trailing elements in a structure. > > Kernel code should always use “flexible array members”[1] for these > > cases. The older style of one-element or zero-length arrays should > > no longer be used[2]. > > > > [1] https://en.wikipedia.org/wiki/Flexible_array_member > > [2] https://www.kernel.org/doc/html/v5.16/process/deprecated.html#zero-length-and-one-element-arrays > > > > Link: https://github.com/KSPP/linux/issues/78 > > Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org> > > Reviewed-by: Kees Cook <keescook@chromium.org> Hi all, Friendly ping: can someone take this, please? ...I can take this in my -next tree in the meantime. Thanks -- Gustavo
"Gustavo A. R. Silva" <gustavoars@kernel.org> writes: > On Wed, Feb 16, 2022 at 12:35:22PM -0800, Kees Cook wrote: >> On Wed, Feb 16, 2022 at 01:50:30PM -0600, Gustavo A. R. Silva wrote: >> > There is a regular need in the kernel to provide a way to declare >> > having a dynamically sized set of trailing elements in a structure. >> > Kernel code should always use “flexible array members”[1] for these >> > cases. The older style of one-element or zero-length arrays should >> > no longer be used[2]. >> > >> > [1] https://en.wikipedia.org/wiki/Flexible_array_member >> > [2] >> > https://www.kernel.org/doc/html/v5.16/process/deprecated.html#zero-length-and-one-element-arrays >> > >> > Link: https://github.com/KSPP/linux/issues/78 >> > Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org> >> >> Reviewed-by: Kees Cook <keescook@chromium.org> > > Hi all, > > Friendly ping: can someone take this, please? > > ...I can take this in my -next tree in the meantime. I'll take this. Luca, ack?
On Mon, 2022-03-28 at 08:48 +0300, Kalle Valo wrote: > "Gustavo A. R. Silva" <gustavoars@kernel.org> writes: > > > On Wed, Feb 16, 2022 at 12:35:22PM -0800, Kees Cook wrote: > > > On Wed, Feb 16, 2022 at 01:50:30PM -0600, Gustavo A. R. Silva wrote: > > > > There is a regular need in the kernel to provide a way to declare > > > > having a dynamically sized set of trailing elements in a structure. > > > > Kernel code should always use “flexible array members”[1] for these > > > > cases. The older style of one-element or zero-length arrays should > > > > no longer be used[2]. > > > > > > > > [1] https://en.wikipedia.org/wiki/Flexible_array_member > > > > [2] > > > > https://www.kernel.org/doc/html/v5.16/process/deprecated.html#zero-length-and-one-element-arrays > > > > > > > > Link: https://github.com/KSPP/linux/issues/78 > > > > Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org> > > > > > > Reviewed-by: Kees Cook <keescook@chromium.org> > > > > Hi all, > > > > Friendly ping: can someone take this, please? > > > > ...I can take this in my -next tree in the meantime. > > I'll take this. Luca, ack? Acked-by: Luca Coelho <luciano.coelho@intel.com> -- Cheers, Luca.
"Gustavo A. R. Silva" <gustavoars@kernel.org> wrote: > There is a regular need in the kernel to provide a way to declare > having a dynamically sized set of trailing elements in a structure. > Kernel code should always use “flexible array members”[1] for these > cases. The older style of one-element or zero-length arrays should > no longer be used[2]. > > [1] https://en.wikipedia.org/wiki/Flexible_array_member > [2] https://www.kernel.org/doc/html/v5.16/process/deprecated.html#zero-length-and-one-element-arrays > > Link: https://github.com/KSPP/linux/issues/78 > Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org> > Reviewed-by: Kees Cook <keescook@chromium.org> > Acked-by: Luca Coelho <luciano.coelho@intel.com> Patch applied to wireless-next.git, thanks. c5f675748cf0 iwlwifi: mei: Replace zero-length array with flexible-array member
diff --git a/drivers/net/wireless/intel/iwlwifi/mei/sap.h b/drivers/net/wireless/intel/iwlwifi/mei/sap.h index 11e3009121cc..be1456dea484 100644 --- a/drivers/net/wireless/intel/iwlwifi/mei/sap.h +++ b/drivers/net/wireless/intel/iwlwifi/mei/sap.h @@ -298,7 +298,7 @@ struct iwl_sap_hdr { __le16 type; __le16 len; __le32 seq_num; - u8 payload[0]; + u8 payload[]; }; /**
There is a regular need in the kernel to provide a way to declare having a dynamically sized set of trailing elements in a structure. Kernel code should always use “flexible array members”[1] for these cases. The older style of one-element or zero-length arrays should no longer be used[2]. [1] https://en.wikipedia.org/wiki/Flexible_array_member [2] https://www.kernel.org/doc/html/v5.16/process/deprecated.html#zero-length-and-one-element-arrays Link: https://github.com/KSPP/linux/issues/78 Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org> --- drivers/net/wireless/intel/iwlwifi/mei/sap.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)