| Message ID | 20220328232449.132550-1-eng.alaamohamedsoliman.am@gmail.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Delegated to: | Toke Høiland-Jørgensen |
| Headers | show |
| Series | First Patch: Add Printk to pci.c | expand |
On Tue, Mar 29, 2022 at 01:24:49AM +0200, Alaa Mohamed wrote: > This patch for adding Printk line to ath9k probe function as a task > for Outreachy internship > > Signed-off-by: Alaa Mohamed <eng.alaamohamedsoliman.am@gmail.com> Hi Alaa, Based on your 'CC to outreachy I can guess you are following out 'First Patch Tutorial'. A patch for this step does not need to be sent out to the maintainers and lists, since it's not something we actually want to change in the Linux Kernel. Your next patch, a cleanup patch in drivers/staging/ does need to get sent. I guess we'll see that soon! Thanks & welcome to this round of Outreachy, Alison > --- > drivers/net/wireless/ath/ath9k/pci.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/wireless/ath/ath9k/pci.c b/drivers/net/wireless/ath/ath9k/pci.c > index a074e23013c5..e16bdf343a2f 100644 > --- a/drivers/net/wireless/ath/ath9k/pci.c > +++ b/drivers/net/wireless/ath/ath9k/pci.c > @@ -892,6 +892,7 @@ static int ath_pci_probe(struct pci_dev *pdev, const struct pci_device_id *id) > int ret = 0; > char hw_name[64]; > int msi_enabled = 0; > + printk(KERN_DEBUG "I can modify the Linux kernel!\n"); > > if (pcim_enable_device(pdev)) > return -EIO; > -- > 2.35.1 > >
On Tue, Mar 29, 2022 at 01:24:49AM +0200, Alaa Mohamed wrote: > This patch for adding Printk line to ath9k probe function as a task > for Outreachy internship > > Signed-off-by: Alaa Mohamed <eng.alaamohamedsoliman.am@gmail.com> > --- > drivers/net/wireless/ath/ath9k/pci.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/wireless/ath/ath9k/pci.c b/drivers/net/wireless/ath/ath9k/pci.c > index a074e23013c5..e16bdf343a2f 100644 > --- a/drivers/net/wireless/ath/ath9k/pci.c > +++ b/drivers/net/wireless/ath/ath9k/pci.c > @@ -892,6 +892,7 @@ static int ath_pci_probe(struct pci_dev *pdev, const struct pci_device_id *id) > int ret = 0; > char hw_name[64]; > int msi_enabled = 0; > + printk(KERN_DEBUG "I can modify the Linux kernel!\n"); Hi Alaa Nice first patch. Everybody has to start somewhere. The description is good, it explains 'why', which is the important thing. The signed-off-by is there, and it looks like it did not get mangled by your mailer. I suspect if you run ./scripts/checkpatch.pl on the patch it will ask you to use something other than printk(KERN_DEBUG). I guess this comes later in the Outreach internship program, so don't worry about it. But it is a useful script to know about. Andrew
diff --git a/drivers/net/wireless/ath/ath9k/pci.c b/drivers/net/wireless/ath/ath9k/pci.c index a074e23013c5..e16bdf343a2f 100644 --- a/drivers/net/wireless/ath/ath9k/pci.c +++ b/drivers/net/wireless/ath/ath9k/pci.c @@ -892,6 +892,7 @@ static int ath_pci_probe(struct pci_dev *pdev, const struct pci_device_id *id) int ret = 0; char hw_name[64]; int msi_enabled = 0; + printk(KERN_DEBUG "I can modify the Linux kernel!\n"); if (pcim_enable_device(pdev)) return -EIO;
This patch for adding Printk line to ath9k probe function as a task for Outreachy internship Signed-off-by: Alaa Mohamed <eng.alaamohamedsoliman.am@gmail.com> --- drivers/net/wireless/ath/ath9k/pci.c | 1 + 1 file changed, 1 insertion(+)