| Message ID | 20220325074141.17446-1-tangmeng@uniontech.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | ipw2200: Fix permissions setted by DEVICE_ATTR | expand |
On Fri, Mar 25, 2022 at 03:41:41PM +0800, Meng Tang wrote: > Because xcode_version and rtc only implement the show function > and do not provide the store function, so ucode_version and rtc > only need the read permission, not need the write permission more. > > So, remove the write permission from xcode_version and rtc. > > Signed-off-by: Meng Tang <tangmeng@uniontech.com> > --- > drivers/net/wireless/intel/ipw2x00/ipw2200.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/wireless/intel/ipw2x00/ipw2200.c b/drivers/net/wireless/intel/ipw2x00/ipw2200.c > index 6830e88c4ed6..fa4f38d54d0a 100644 > --- a/drivers/net/wireless/intel/ipw2x00/ipw2200.c > +++ b/drivers/net/wireless/intel/ipw2x00/ipw2200.c > @@ -1578,7 +1578,7 @@ static ssize_t show_ucode_version(struct device *d, > return sprintf(buf, "0x%08x\n", tmp); > } > > -static DEVICE_ATTR(ucode_version, 0644, show_ucode_version, NULL); > +static DEVICE_ATTR(ucode_version, 0444, show_ucode_version, NULL); DEVICE_ATTR_RO() exists to make this more obvious. But it looks like you would need to rename the show_ucode_version() to ucode_version_show() in order to use it. Andrew
On Fri, 25 Mar 2022 at 03:42, Meng Tang <tangmeng@uniontech.com> wrote: > > Because xcode_version and rtc only implement the show function > and do not provide the store function, so ucode_version and rtc > only need the read permission, not need the write permission more. > > So, remove the write permission from xcode_version and rtc. > > Signed-off-by: Meng Tang <tangmeng@uniontech.com> > --- > drivers/net/wireless/intel/ipw2x00/ipw2200.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > Looks fine, thanks! Stanislav.
diff --git a/drivers/net/wireless/intel/ipw2x00/ipw2200.c b/drivers/net/wireless/intel/ipw2x00/ipw2200.c index 6830e88c4ed6..fa4f38d54d0a 100644 --- a/drivers/net/wireless/intel/ipw2x00/ipw2200.c +++ b/drivers/net/wireless/intel/ipw2x00/ipw2200.c @@ -1578,7 +1578,7 @@ static ssize_t show_ucode_version(struct device *d, return sprintf(buf, "0x%08x\n", tmp); } -static DEVICE_ATTR(ucode_version, 0644, show_ucode_version, NULL); +static DEVICE_ATTR(ucode_version, 0444, show_ucode_version, NULL); static ssize_t show_rtc(struct device *d, struct device_attribute *attr, char *buf) @@ -1592,7 +1592,7 @@ static ssize_t show_rtc(struct device *d, struct device_attribute *attr, return sprintf(buf, "0x%08x\n", tmp); } -static DEVICE_ATTR(rtc, 0644, show_rtc, NULL); +static DEVICE_ATTR(rtc, 0444, show_rtc, NULL); /* * Add a device attribute to view/control the delay between eeprom
Because xcode_version and rtc only implement the show function and do not provide the store function, so ucode_version and rtc only need the read permission, not need the write permission more. So, remove the write permission from xcode_version and rtc. Signed-off-by: Meng Tang <tangmeng@uniontech.com> --- drivers/net/wireless/intel/ipw2x00/ipw2200.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)