| Message ID | 1648701477-16367-1-git-send-email-quic_akolli@quicinc.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 10cb21f4ff3f9cb36d1e1c39bf80426f02f4986a |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | [v5.18] Revert "ath11k: mesh: add support for 256 bitmap in blockack frames in 11ax" | expand |
Anilkumar Kolli <quic_akolli@quicinc.com> wrote: > This reverts commit 743b9065fe6348a5f8f5ce04869ce2d701e5e1bc. > > The original commit breaks the 256 bitmap in blockack frames in AP > mode. After reverting the commit the feature works again in both AP and > mesh modes > > Tested-on: IPQ8074 hw2.0 PCI WLAN.HK.2.6.0.1-00786-QCAHKSWPL_SILICONZ-1 > > Signed-off-by: Anilkumar Kolli <quic_akolli@quicinc.com> I'll add: Fixes: 743b9065fe63 ("ath11k: mesh: add support for 256 bitmap in blockack frames in 11ax") It's not clear for me if reverts should have the Fixes tag, but to be on the safe side I'll add it.
Anilkumar Kolli <quic_akolli@quicinc.com> wrote: > This reverts commit 743b9065fe6348a5f8f5ce04869ce2d701e5e1bc. > > The original commit breaks the 256 bitmap in blockack frames in AP > mode. After reverting the commit the feature works again in both AP and > mesh modes > > Tested-on: IPQ8074 hw2.0 PCI WLAN.HK.2.6.0.1-00786-QCAHKSWPL_SILICONZ-1 > > Fixes: 743b9065fe63 ("ath11k: mesh: add support for 256 bitmap in blockack frames in 11ax") > Signed-off-by: Anilkumar Kolli <quic_akolli@quicinc.com> Patch applied to wireless.git, thanks. 10cb21f4ff3f Revert "ath11k: mesh: add support for 256 bitmap in blockack frames in 11ax"
diff --git a/drivers/net/wireless/ath/ath11k/mac.c b/drivers/net/wireless/ath/ath11k/mac.c index 175a4ae752f3..ca998fb13b62 100644 --- a/drivers/net/wireless/ath/ath11k/mac.c +++ b/drivers/net/wireless/ath/ath11k/mac.c @@ -3150,6 +3150,20 @@ static void ath11k_mac_op_bss_info_changed(struct ieee80211_hw *hw, arvif->do_not_send_tmpl = true; else arvif->do_not_send_tmpl = false; + + if (vif->bss_conf.he_support) { + ret = ath11k_wmi_vdev_set_param_cmd(ar, arvif->vdev_id, + WMI_VDEV_PARAM_BA_MODE, + WMI_BA_MODE_BUFFER_SIZE_256); + if (ret) + ath11k_warn(ar->ab, + "failed to set BA BUFFER SIZE 256 for vdev: %d\n", + arvif->vdev_id); + else + ath11k_dbg(ar->ab, ATH11K_DBG_MAC, + "Set BA BUFFER SIZE 256 for VDEV: %d\n", + arvif->vdev_id); + } } if (changed & (BSS_CHANGED_BEACON_INFO | BSS_CHANGED_BEACON)) { @@ -3185,14 +3199,6 @@ static void ath11k_mac_op_bss_info_changed(struct ieee80211_hw *hw, if (arvif->is_up && vif->bss_conf.he_support && vif->bss_conf.he_oper.params) { - ret = ath11k_wmi_vdev_set_param_cmd(ar, arvif->vdev_id, - WMI_VDEV_PARAM_BA_MODE, - WMI_BA_MODE_BUFFER_SIZE_256); - if (ret) - ath11k_warn(ar->ab, - "failed to set BA BUFFER SIZE 256 for vdev: %d\n", - arvif->vdev_id); - param_id = WMI_VDEV_PARAM_HEOPS_0_31; param_value = vif->bss_conf.he_oper.params; ret = ath11k_wmi_vdev_set_param_cmd(ar, arvif->vdev_id,
This reverts commit 743b9065fe6348a5f8f5ce04869ce2d701e5e1bc. The original commit breaks the 256 bitmap in blockack frames in AP mode. After reverting the commit the feature works again in both AP and mesh modes Tested-on: IPQ8074 hw2.0 PCI WLAN.HK.2.6.0.1-00786-QCAHKSWPL_SILICONZ-1 Signed-off-by: Anilkumar Kolli <quic_akolli@quicinc.com> --- drivers/net/wireless/ath/ath11k/mac.c | 22 ++++++++++++++-------- 1 file changed, 14 insertions(+), 8 deletions(-)