diff mbox series

drm/i915/uncore: Warn on previous unclaimed accesses

Message ID 20220405001149.2675226-1-lucas.demarchi@intel.com (mailing list archive)
State New, archived
Headers show
Series drm/i915/uncore: Warn on previous unclaimed accesses | expand

Commit Message

Lucas De Marchi April 5, 2022, 12:11 a.m. UTC
Since gen6 we use FPGA_DBG register to detect unclaimed MMIO registers.
This register is in the display engine IP and can only ever detect
unclaimed accesses to registers in this area. However sometimes there
are reports of this triggering for registers in other areas, which
should not be possible.

Right now we always warn after the read/write of registers going through
unclaimed_reg_debug(). However places using __raw_uncore_* may be
triggering the unclaimed access and those being later accounted to a
different register. Let's warn both before and after the read/write
with a slightly different message, so it's clear if the register
reported in the warning is actually the culprit.

Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
---
 drivers/gpu/drm/i915/intel_uncore.c | 29 +++++++++++++++++++++--------
 1 file changed, 21 insertions(+), 8 deletions(-)

Comments

Lucas De Marchi April 5, 2022, 3:19 p.m. UTC | #1
On Tue, Apr 05, 2022 at 09:43:58AM +0000, Patchwork wrote:
>== Series Details ==
>
>Series: drm/i915/uncore: Warn on previous unclaimed accesses
>URL   : https://patchwork.freedesktop.org/series/102167/
>State : failure
>
>== Summary ==
>
>CI Bug Log - changes from CI_DRM_11452_full -> Patchwork_22778_full
>====================================================
>
>Summary
>-------
>
>  **FAILURE**
>
>  Serious unknown changes coming with Patchwork_22778_full absolutely need to be
>  verified manually.
>
>  If you think the reported changes have nothing to do with the changes
>  introduced in Patchwork_22778_full, please notify your bug team to allow them
>  to document this new failure mode, which will reduce false positives in CI.
>
>
>
>Participating hosts (12 -> 13)
>------------------------------
>
>  Additional (1): shard-dg1
>
>Possible new issues
>-------------------
>
>  Here are the unknown changes that may have been introduced in Patchwork_22778_full:
>
>### IGT changes ###
>
>#### Possible regressions ####
>
>  * igt@gen9_exec_parse@allowed-all:
>    - shard-skl:          [PASS][1] -> [DMESG-WARN][2]
>   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11452/shard-skl1/igt@gen9_exec_parse@allowed-all.html
>   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-skl4/igt@gen9_exec_parse@allowed-all.html
>    - shard-apl:          [PASS][3] -> [DMESG-WARN][4]
>   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11452/shard-apl4/igt@gen9_exec_parse@allowed-all.html
>   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-apl7/igt@gen9_exec_parse@allowed-all.html
>    - shard-glk:          [PASS][5] -> [DMESG-WARN][6]
>   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11452/shard-glk1/igt@gen9_exec_parse@allowed-all.html
>   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-glk8/igt@gen9_exec_parse@allowed-all.html
>    - shard-kbl:          [PASS][7] -> [DMESG-WARN][8]
>   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11452/shard-kbl6/igt@gen9_exec_parse@allowed-all.html
>   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-kbl7/igt@gen9_exec_parse@allowed-all.html

don't shoot the messenger :)

Lakshmi, these need to be mapped to previous failures. Here we are just
changing the message logged to make clear they aren't caused by the
register we are currently reading/writting, but it's rather cause by a
previous read/write.

All of these should have a previous issue already with the different
message, not being caused by this patch.

Lucas De Marchi

>
>
>#### Suppressed ####
>
>  The following results come from untrusted machines, tests, or statuses.
>  They do not affect the overall result.
>
>  * igt@i915_pm_rpm@system-suspend-devices:
>    - {shard-rkl}:        [PASS][9] -> [FAIL][10]
>   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11452/shard-rkl-1/igt@i915_pm_rpm@system-suspend-devices.html
>   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-rkl-5/igt@i915_pm_rpm@system-suspend-devices.html
>
>
>Known issues
>------------
>
>  Here are the changes found in Patchwork_22778_full that come from known issues:
>
>### CI changes ###
>
>#### Issues hit ####
>
>  * boot:
>    - shard-skl:          ([PASS][11], [PASS][12], [PASS][13], [PASS][14], [PASS][15], [PASS][16], [PASS][17], [PASS][18], [PASS][19], [PASS][20], [PASS][21], [PASS][22], [PASS][23], [PASS][24], [PASS][25], [PASS][26], [PASS][27], [PASS][28], [PASS][29], [PASS][30], [PASS][31], [PASS][32], [PASS][33], [PASS][34], [PASS][35]) -> ([PASS][36], [PASS][37], [PASS][38], [PASS][39], [PASS][40], [PASS][41], [PASS][42], [PASS][43], [PASS][44], [PASS][45], [PASS][46], [FAIL][47], [PASS][48], [PASS][49], [PASS][50], [PASS][51], [PASS][52], [PASS][53], [PASS][54], [PASS][55], [PASS][56], [PASS][57]) ([i915#5032])
>   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11452/shard-skl9/boot.html
>   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11452/shard-skl9/boot.html
>   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11452/shard-skl9/boot.html
>   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11452/shard-skl8/boot.html
>   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11452/shard-skl8/boot.html
>   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11452/shard-skl8/boot.html
>   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11452/shard-skl7/boot.html
>   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11452/shard-skl7/boot.html
>   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11452/shard-skl7/boot.html
>   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11452/shard-skl7/boot.html
>   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11452/shard-skl6/boot.html
>   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11452/shard-skl6/boot.html
>   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11452/shard-skl6/boot.html
>   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11452/shard-skl6/boot.html
>   [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11452/shard-skl4/boot.html
>   [26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11452/shard-skl4/boot.html
>   [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11452/shard-skl4/boot.html
>   [28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11452/shard-skl4/boot.html
>   [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11452/shard-skl1/boot.html
>   [30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11452/shard-skl1/boot.html
>   [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11452/shard-skl1/boot.html
>   [32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11452/shard-skl1/boot.html
>   [33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11452/shard-skl10/boot.html
>   [34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11452/shard-skl10/boot.html
>   [35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11452/shard-skl10/boot.html
>   [36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-skl9/boot.html
>   [37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-skl9/boot.html
>   [38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-skl8/boot.html
>   [39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-skl8/boot.html
>   [40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-skl8/boot.html
>   [41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-skl7/boot.html
>   [42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-skl7/boot.html
>   [43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-skl7/boot.html
>   [44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-skl6/boot.html
>   [45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-skl6/boot.html
>   [46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-skl5/boot.html
>   [47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-skl5/boot.html
>   [48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-skl4/boot.html
>   [49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-skl4/boot.html
>   [50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-skl4/boot.html
>   [51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-skl2/boot.html
>   [52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-skl1/boot.html
>   [53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-skl1/boot.html
>   [54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-skl1/boot.html
>   [55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-skl10/boot.html
>   [56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-skl10/boot.html
>   [57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-skl10/boot.html
>
>
>
>### IGT changes ###
>
>#### Issues hit ####
>
>  * igt@gem_exec_balancer@parallel:
>    - shard-kbl:          NOTRUN -> [DMESG-WARN][58] ([i915#5076])
>   [58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-kbl6/igt@gem_exec_balancer@parallel.html
>
>  * igt@gem_exec_fair@basic-deadline:
>    - shard-glk:          [PASS][59] -> [FAIL][60] ([i915#2846])
>   [59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11452/shard-glk2/igt@gem_exec_fair@basic-deadline.html
>   [60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-glk8/igt@gem_exec_fair@basic-deadline.html
>
>  * igt@gem_exec_fair@basic-none-share@rcs0:
>    - shard-kbl:          [PASS][61] -> [FAIL][62] ([i915#2842]) +2 similar issues
>   [61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11452/shard-kbl3/igt@gem_exec_fair@basic-none-share@rcs0.html
>   [62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-kbl3/igt@gem_exec_fair@basic-none-share@rcs0.html
>    - shard-iclb:         [PASS][63] -> [FAIL][64] ([i915#2842])
>   [63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11452/shard-iclb7/igt@gem_exec_fair@basic-none-share@rcs0.html
>   [64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-iclb2/igt@gem_exec_fair@basic-none-share@rcs0.html
>
>  * igt@gem_exec_fair@basic-none-solo@rcs0:
>    - shard-apl:          [PASS][65] -> [FAIL][66] ([i915#2842]) +1 similar issue
>   [65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11452/shard-apl3/igt@gem_exec_fair@basic-none-solo@rcs0.html
>   [66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-apl4/igt@gem_exec_fair@basic-none-solo@rcs0.html
>
>  * igt@gem_exec_fair@basic-pace@bcs0:
>    - shard-apl:          NOTRUN -> [SKIP][67] ([fdo#109271]) +47 similar issues
>   [67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-apl7/igt@gem_exec_fair@basic-pace@bcs0.html
>
>  * igt@gem_exec_fair@basic-pace@rcs0:
>    - shard-glk:          [PASS][68] -> [FAIL][69] ([i915#2842])
>   [68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11452/shard-glk5/igt@gem_exec_fair@basic-pace@rcs0.html
>   [69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-glk1/igt@gem_exec_fair@basic-pace@rcs0.html
>
>  * igt@gem_lmem_swapping@heavy-random:
>    - shard-iclb:         NOTRUN -> [SKIP][70] ([i915#4613])
>   [70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-iclb5/igt@gem_lmem_swapping@heavy-random.html
>
>  * igt@gem_ppgtt@flink-and-close-vma-leak:
>    - shard-glk:          [PASS][71] -> [FAIL][72] ([i915#644])
>   [71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11452/shard-glk3/igt@gem_ppgtt@flink-and-close-vma-leak.html
>   [72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-glk5/igt@gem_ppgtt@flink-and-close-vma-leak.html
>
>  * igt@gem_pxp@verify-pxp-key-change-after-suspend-resume:
>    - shard-iclb:         NOTRUN -> [SKIP][73] ([i915#4270])
>   [73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-iclb5/igt@gem_pxp@verify-pxp-key-change-after-suspend-resume.html
>
>  * igt@gem_render_copy@linear-to-vebox-yf-tiled:
>    - shard-kbl:          NOTRUN -> [SKIP][74] ([fdo#109271]) +9 similar issues
>   [74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-kbl6/igt@gem_render_copy@linear-to-vebox-yf-tiled.html
>
>  * igt@gem_userptr_blits@access-control:
>    - shard-iclb:         NOTRUN -> [SKIP][75] ([i915#3297]) +1 similar issue
>   [75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-iclb5/igt@gem_userptr_blits@access-control.html
>
>  * igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-180:
>    - shard-iclb:         NOTRUN -> [SKIP][76] ([i915#5286]) +1 similar issue
>   [76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-iclb5/igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-180.html
>
>  * igt@kms_big_fb@linear-8bpp-rotate-90:
>    - shard-iclb:         NOTRUN -> [SKIP][77] ([fdo#110725] / [fdo#111614])
>   [77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-iclb5/igt@kms_big_fb@linear-8bpp-rotate-90.html
>
>  * igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-0-hflip:
>    - shard-apl:          NOTRUN -> [SKIP][78] ([fdo#109271] / [i915#3777]) +1 similar issue
>   [78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-apl2/igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-0-hflip.html
>
>  * igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-180-hflip:
>    - shard-kbl:          NOTRUN -> [SKIP][79] ([fdo#109271] / [i915#3777])
>   [79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-kbl6/igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-180-hflip.html
>
>  * igt@kms_big_fb@yf-tiled-max-hw-stride-64bpp-rotate-0-hflip:
>    - shard-iclb:         NOTRUN -> [SKIP][80] ([fdo#110723])
>   [80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-iclb5/igt@kms_big_fb@yf-tiled-max-hw-stride-64bpp-rotate-0-hflip.html
>
>  * igt@kms_ccs@pipe-b-missing-ccs-buffer-y_tiled_gen12_rc_ccs_cc:
>    - shard-apl:          NOTRUN -> [SKIP][81] ([fdo#109271] / [i915#3886]) +4 similar issues
>   [81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-apl2/igt@kms_ccs@pipe-b-missing-ccs-buffer-y_tiled_gen12_rc_ccs_cc.html
>
>  * igt@kms_ccs@pipe-c-crc-primary-basic-y_tiled_gen12_rc_ccs_cc:
>    - shard-skl:          NOTRUN -> [SKIP][82] ([fdo#109271] / [i915#3886])
>   [82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-skl8/igt@kms_ccs@pipe-c-crc-primary-basic-y_tiled_gen12_rc_ccs_cc.html
>
>  * igt@kms_chamelium@dp-hpd-storm:
>    - shard-apl:          NOTRUN -> [SKIP][83] ([fdo#109271] / [fdo#111827]) +5 similar issues
>   [83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-apl1/igt@kms_chamelium@dp-hpd-storm.html
>
>  * igt@kms_chamelium@hdmi-audio:
>    - shard-iclb:         NOTRUN -> [SKIP][84] ([fdo#109284] / [fdo#111827]) +2 similar issues
>   [84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-iclb5/igt@kms_chamelium@hdmi-audio.html
>
>  * igt@kms_chamelium@hdmi-hpd-storm-disable:
>    - shard-kbl:          NOTRUN -> [SKIP][85] ([fdo#109271] / [fdo#111827]) +1 similar issue
>   [85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-kbl6/igt@kms_chamelium@hdmi-hpd-storm-disable.html
>
>  * igt@kms_color@pipe-c-ctm-max:
>    - shard-kbl:          [PASS][86] -> [DMESG-WARN][87] ([i915#62] / [i915#92]) +19 similar issues
>   [86]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11452/shard-kbl6/igt@kms_color@pipe-c-ctm-max.html
>   [87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-kbl6/igt@kms_color@pipe-c-ctm-max.html
>
>  * igt@kms_cursor_legacy@cursora-vs-flipb-atomic-transitions-varying-size:
>    - shard-iclb:         NOTRUN -> [SKIP][88] ([fdo#109274] / [fdo#109278])
>   [88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-iclb5/igt@kms_cursor_legacy@cursora-vs-flipb-atomic-transitions-varying-size.html
>
>  * igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size:
>    - shard-iclb:         [PASS][89] -> [FAIL][90] ([i915#2346])
>   [89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11452/shard-iclb8/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
>   [90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-iclb7/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
>
>  * igt@kms_draw_crc@draw-method-rgb565-mmap-cpu-untiled:
>    - shard-glk:          [PASS][91] -> [FAIL][92] ([i915#5160])
>   [91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11452/shard-glk9/igt@kms_draw_crc@draw-method-rgb565-mmap-cpu-untiled.html
>   [92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-glk6/igt@kms_draw_crc@draw-method-rgb565-mmap-cpu-untiled.html
>
>  * igt@kms_flip@2x-blocking-wf_vblank:
>    - shard-iclb:         NOTRUN -> [SKIP][93] ([fdo#109274]) +1 similar issue
>   [93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-iclb5/igt@kms_flip@2x-blocking-wf_vblank.html
>
>  * igt@kms_flip@flip-vs-expired-vblank@c-hdmi-a2:
>    - shard-glk:          [PASS][94] -> [FAIL][95] ([i915#79]) +1 similar issue
>   [94]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11452/shard-glk8/igt@kms_flip@flip-vs-expired-vblank@c-hdmi-a2.html
>   [95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-glk4/igt@kms_flip@flip-vs-expired-vblank@c-hdmi-a2.html
>
>  * igt@kms_flip@flip-vs-suspend-interruptible@c-dp1:
>    - shard-apl:          [PASS][96] -> [DMESG-WARN][97] ([i915#180]) +2 similar issues
>   [96]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11452/shard-apl2/igt@kms_flip@flip-vs-suspend-interruptible@c-dp1.html
>   [97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-apl6/igt@kms_flip@flip-vs-suspend-interruptible@c-dp1.html
>
>  * igt@kms_flip@flip-vs-suspend@a-dp1:
>    - shard-kbl:          [PASS][98] -> [DMESG-WARN][99] ([i915#180]) +2 similar issues
>   [98]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11452/shard-kbl3/igt@kms_flip@flip-vs-suspend@a-dp1.html
>   [99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-kbl6/igt@kms_flip@flip-vs-suspend@a-dp1.html
>
>  * igt@kms_flip@plain-flip-fb-recreate-interruptible@a-dp1:
>    - shard-kbl:          [PASS][100] -> [FAIL][101] ([i915#2122])
>   [100]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11452/shard-kbl1/igt@kms_flip@plain-flip-fb-recreate-interruptible@a-dp1.html
>   [101]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-kbl1/igt@kms_flip@plain-flip-fb-recreate-interruptible@a-dp1.html
>
>  * igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile-upscaling:
>    - shard-glk:          [PASS][102] -> [FAIL][103] ([i915#4911])
>   [102]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11452/shard-glk5/igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile-upscaling.html
>   [103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-glk8/igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile-upscaling.html
>
>  * igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytile-downscaling:
>    - shard-iclb:         [PASS][104] -> [SKIP][105] ([i915#3701])
>   [104]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11452/shard-iclb7/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytile-downscaling.html
>   [105]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-iclb2/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytile-downscaling.html
>
>  * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-shrfb-msflip-blt:
>    - shard-kbl:          [PASS][106] -> [DMESG-WARN][107] ([i915#1982] / [i915#62] / [i915#92])
>   [106]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11452/shard-kbl6/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-shrfb-msflip-blt.html
>   [107]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-kbl6/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-shrfb-msflip-blt.html
>
>  * igt@kms_frontbuffer_tracking@fbc-2p-pri-indfb-multidraw:
>    - shard-iclb:         NOTRUN -> [SKIP][108] ([fdo#109280]) +8 similar issues
>   [108]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-iclb5/igt@kms_frontbuffer_tracking@fbc-2p-pri-indfb-multidraw.html
>
>  * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-indfb-msflip-blt:
>    - shard-skl:          NOTRUN -> [SKIP][109] ([fdo#109271]) +8 similar issues
>   [109]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-skl8/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-indfb-msflip-blt.html
>
>  * igt@kms_hdr@static-toggle-dpms:
>    - shard-iclb:         NOTRUN -> [SKIP][110] ([i915#3555])
>   [110]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-iclb5/igt@kms_hdr@static-toggle-dpms.html
>
>  * igt@kms_pipe_b_c_ivb@enable-pipe-c-while-b-has-3-lanes:
>    - shard-iclb:         NOTRUN -> [SKIP][111] ([fdo#109289])
>   [111]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-iclb5/igt@kms_pipe_b_c_ivb@enable-pipe-c-while-b-has-3-lanes.html
>
>  * igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
>    - shard-apl:          NOTRUN -> [DMESG-WARN][112] ([i915#180])
>   [112]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-apl6/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b.html
>
>  * igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min:
>    - shard-skl:          NOTRUN -> [FAIL][113] ([fdo#108145] / [i915#265])
>   [113]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-skl8/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min.html
>
>  * igt@kms_plane_alpha_blend@pipe-b-alpha-basic:
>    - shard-apl:          NOTRUN -> [FAIL][114] ([fdo#108145] / [i915#265])
>   [114]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-apl2/igt@kms_plane_alpha_blend@pipe-b-alpha-basic.html
>
>  * igt@kms_plane_cursor@pipe-d-primary-size-128:
>    - shard-iclb:         NOTRUN -> [SKIP][115] ([fdo#109278]) +6 similar issues
>   [115]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-iclb5/igt@kms_plane_cursor@pipe-d-primary-size-128.html
>
>  * igt@kms_psr2_sf@plane-move-sf-dmg-area:
>    - shard-iclb:         NOTRUN -> [SKIP][116] ([fdo#111068] / [i915#658])
>   [116]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-iclb5/igt@kms_psr2_sf@plane-move-sf-dmg-area.html
>
>  * igt@kms_psr2_su@frontbuffer-xrgb8888:
>    - shard-apl:          NOTRUN -> [SKIP][117] ([fdo#109271] / [i915#658])
>   [117]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-apl2/igt@kms_psr2_su@frontbuffer-xrgb8888.html
>
>  * igt@kms_scaling_modes@scaling-mode-none@edp-1-pipe-c:
>    - shard-iclb:         NOTRUN -> [SKIP][118] ([i915#5030]) +2 similar issues
>   [118]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-iclb5/igt@kms_scaling_modes@scaling-mode-none@edp-1-pipe-c.html
>
>  * igt@kms_writeback@writeback-invalid-parameters:
>    - shard-apl:          NOTRUN -> [SKIP][119] ([fdo#109271] / [i915#2437])
>   [119]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-apl2/igt@kms_writeback@writeback-invalid-parameters.html
>
>  * igt@nouveau_crc@pipe-a-ctx-flip-detection:
>    - shard-iclb:         NOTRUN -> [SKIP][120] ([i915#2530])
>   [120]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-iclb5/igt@nouveau_crc@pipe-a-ctx-flip-detection.html
>
>  * igt@perf@polling-parameterized:
>    - shard-tglb:         [PASS][121] -> [FAIL][122] ([i915#1542])
>   [121]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11452/shard-tglb7/igt@perf@polling-parameterized.html
>   [122]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-tglb7/igt@perf@polling-parameterized.html
>
>  * igt@prime_udl:
>    - shard-iclb:         NOTRUN -> [SKIP][123] ([fdo#109291])
>   [123]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-iclb5/igt@prime_udl.html
>
>  * igt@syncobj_timeline@invalid-single-wait-available-unsubmitted:
>    - shard-skl:          [PASS][124] -> [DMESG-WARN][125] ([i915#1982])
>   [124]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11452/shard-skl8/igt@syncobj_timeline@invalid-single-wait-available-unsubmitted.html
>   [125]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-skl6/igt@syncobj_timeline@invalid-single-wait-available-unsubmitted.html
>
>
>#### Possible fixes ####
>
>  * igt@fbdev@nullptr:
>    - {shard-rkl}:        [SKIP][126] ([i915#2582]) -> [PASS][127]
>   [126]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11452/shard-rkl-2/igt@fbdev@nullptr.html
>   [127]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-rkl-6/igt@fbdev@nullptr.html
>
>  * igt@gem_exec_fair@basic-none-share@rcs0:
>    - shard-tglb:         [FAIL][128] ([i915#2842]) -> [PASS][129]
>   [128]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11452/shard-tglb1/igt@gem_exec_fair@basic-none-share@rcs0.html
>   [129]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-tglb2/igt@gem_exec_fair@basic-none-share@rcs0.html
>
>  * igt@gem_exec_fair@basic-pace-solo@rcs0:
>    - shard-glk:          [FAIL][130] ([i915#2842]) -> [PASS][131]
>   [130]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11452/shard-glk5/igt@gem_exec_fair@basic-pace-solo@rcs0.html
>   [131]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-glk3/igt@gem_exec_fair@basic-pace-solo@rcs0.html
>
>  * igt@gem_exec_fair@basic-throttle@rcs0:
>    - shard-iclb:         [FAIL][132] ([i915#2842]) -> [PASS][133]
>   [132]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11452/shard-iclb8/igt@gem_exec_fair@basic-throttle@rcs0.html
>   [133]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-iclb7/igt@gem_exec_fair@basic-throttle@rcs0.html
>
>  * igt@gem_exec_schedule@smoketest@rcs0:
>    - shard-glk:          [DMESG-WARN][134] ([i915#118]) -> [PASS][135]
>   [134]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11452/shard-glk6/igt@gem_exec_schedule@smoketest@rcs0.html
>   [135]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-glk7/igt@gem_exec_schedule@smoketest@rcs0.html
>
>  * igt@gem_mmap_offset@clear:
>    - {shard-rkl}:        [INCOMPLETE][136] ([i915#1373]) -> [PASS][137]
>   [136]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11452/shard-rkl-5/igt@gem_mmap_offset@clear.html
>   [137]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-rkl-1/igt@gem_mmap_offset@clear.html
>
>  * igt@i915_pm_dc@dc6-psr:
>    - shard-iclb:         [FAIL][138] ([i915#454]) -> [PASS][139]
>   [138]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11452/shard-iclb3/igt@i915_pm_dc@dc6-psr.html
>   [139]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-iclb6/igt@i915_pm_dc@dc6-psr.html
>
>  * igt@kms_color@pipe-b-ctm-red-to-blue:
>    - {shard-rkl}:        [SKIP][140] ([i915#1149] / [i915#1849] / [i915#4070] / [i915#4098]) -> [PASS][141]
>   [140]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11452/shard-rkl-2/igt@kms_color@pipe-b-ctm-red-to-blue.html
>   [141]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-rkl-6/igt@kms_color@pipe-b-ctm-red-to-blue.html
>
>  * igt@kms_cursor_crc@pipe-a-cursor-64x21-rapid-movement:
>    - {shard-rkl}:        ([SKIP][142], [SKIP][143]) ([fdo#112022] / [i915#4070]) -> [PASS][144] +1 similar issue
>   [142]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11452/shard-rkl-4/igt@kms_cursor_crc@pipe-a-cursor-64x21-rapid-movement.html
>   [143]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11452/shard-rkl-2/igt@kms_cursor_crc@pipe-a-cursor-64x21-rapid-movement.html
>   [144]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-rkl-6/igt@kms_cursor_crc@pipe-a-cursor-64x21-rapid-movement.html
>
>  * igt@kms_cursor_crc@pipe-b-cursor-256x256-sliding:
>    - {shard-rkl}:        [SKIP][145] ([fdo#112022] / [i915#4070]) -> [PASS][146] +2 similar issues
>   [145]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11452/shard-rkl-2/igt@kms_cursor_crc@pipe-b-cursor-256x256-sliding.html
>   [146]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-rkl-6/igt@kms_cursor_crc@pipe-b-cursor-256x256-sliding.html
>
>  * igt@kms_cursor_crc@pipe-c-cursor-suspend:
>    - shard-kbl:          [INCOMPLETE][147] ([i915#3614]) -> [PASS][148]
>   [147]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11452/shard-kbl4/igt@kms_cursor_crc@pipe-c-cursor-suspend.html
>   [148]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-kbl6/igt@kms_cursor_crc@pipe-c-cursor-suspend.html
>
>  * igt@kms_cursor_edge_walk@pipe-a-256x256-bottom-edge:
>    - {shard-rkl}:        [SKIP][149] ([i915#1849] / [i915#4070] / [i915#4098]) -> [PASS][150] +1 similar issue
>   [149]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11452/shard-rkl-2/igt@kms_cursor_edge_walk@pipe-a-256x256-bottom-edge.html
>   [150]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-rkl-6/igt@kms_cursor_edge_walk@pipe-a-256x256-bottom-edge.html
>
>  * igt@kms_cursor_legacy@cursora-vs-flipa-atomic-transitions-varying-size:
>    - {shard-rkl}:        [SKIP][151] ([fdo#111825] / [i915#4070]) -> [PASS][152] +2 similar issues
>   [151]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11452/shard-rkl-2/igt@kms_cursor_legacy@cursora-vs-flipa-atomic-transitions-varying-size.html
>   [152]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-rkl-6/igt@kms_cursor_legacy@cursora-vs-flipa-atomic-transitions-varying-size.html
>
>  * igt@kms_cursor_legacy@flip-vs-cursor-toggle:
>    - shard-iclb:         [FAIL][153] ([i915#2346]) -> [PASS][154]
>   [153]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11452/shard-iclb7/igt@kms_cursor_legacy@flip-vs-cursor-toggle.html
>   [154]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-iclb2/igt@kms_cursor_legacy@flip-vs-cursor-toggle.html
>
>  * igt@kms_draw_crc@draw-method-xrgb2101010-mmap-gtt-ytiled:
>    - {shard-rkl}:        [SKIP][155] ([fdo#111314] / [i915#4098] / [i915#4369]) -> [PASS][156] +1 similar issue
>   [155]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11452/shard-rkl-2/igt@kms_draw_crc@draw-method-xrgb2101010-mmap-gtt-ytiled.html
>   [156]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-rkl-6/igt@kms_draw_crc@draw-method-xrgb2101010-mmap-gtt-ytiled.html
>
>  * igt@kms_draw_crc@draw-method-xrgb8888-pwrite-ytiled:
>    - {shard-rkl}:        [SKIP][157] ([i915#4098] / [i915#4369]) -> [PASS][158]
>   [157]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11452/shard-rkl-4/igt@kms_draw_crc@draw-method-xrgb8888-pwrite-ytiled.html
>   [158]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-rkl-6/igt@kms_draw_crc@draw-method-xrgb8888-pwrite-ytiled.html
>
>  * igt@kms_flip@flip-vs-expired-vblank-interruptible@b-edp1:
>    - shard-skl:          [FAIL][159] ([i915#79]) -> [PASS][160]
>   [159]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11452/shard-skl6/igt@kms_flip@flip-vs-expired-vblank-interruptible@b-edp1.html
>   [160]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-skl1/igt@kms_flip@flip-vs-expired-vblank-interruptible@b-edp1.html
>
>  * igt@kms_flip@flip-vs-suspend-interruptible@a-dp1:
>    - shard-apl:          [DMESG-WARN][161] ([i915#180]) -> [PASS][162] +8 similar issues
>   [161]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11452/shard-apl2/igt@kms_flip@flip-vs-suspend-interruptible@a-dp1.html
>   [162]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-apl6/igt@kms_flip@flip-vs-suspend-interruptible@a-dp1.html
>
>  * igt@kms_flip@flip-vs-suspend@c-edp1:
>    - shard-tglb:         [DMESG-WARN][163] ([i915#2411] / [i915#2867]) -> [PASS][164]
>   [163]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11452/shard-tglb5/igt@kms_flip@flip-vs-suspend@c-edp1.html
>   [164]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-tglb6/igt@kms_flip@flip-vs-suspend@c-edp1.html
>
>  * igt@kms_flip@plain-flip-fb-recreate-interruptible@a-hdmi-a1:
>    - shard-glk:          [FAIL][165] ([i915#2122]) -> [PASS][166]
>   [165]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11452/sh
>
>== Logs ==
>
>For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/index.html
Vudum, Lakshminarayana April 5, 2022, 5:07 p.m. UTC | #2
Those failures are directing towards https://gitlab.freedesktop.org/drm/intel/-/issues/1436 which was closed long back and I see the filters are also broken. 
So, I have filed a new issue and new filter
https://gitlab.freedesktop.org/drm/intel/-/issues/5566

Thanks,
Lakshmi.
-----Original Message-----
From: De Marchi, Lucas <lucas.demarchi@intel.com> 
Sent: Tuesday, April 5, 2022 8:20 AM
To: intel-gfx@lists.freedesktop.org
Cc: Vudum, Lakshminarayana <lakshminarayana.vudum@intel.com>
Subject: Re: ✗ Fi.CI.IGT: failure for drm/i915/uncore: Warn on previous unclaimed accesses

On Tue, Apr 05, 2022 at 09:43:58AM +0000, Patchwork wrote:
>== Series Details ==
>
>Series: drm/i915/uncore: Warn on previous unclaimed accesses
>URL   : https://patchwork.freedesktop.org/series/102167/
>State : failure
>
>== Summary ==
>
>CI Bug Log - changes from CI_DRM_11452_full -> Patchwork_22778_full 
>====================================================
>
>Summary
>-------
>
>  **FAILURE**
>
>  Serious unknown changes coming with Patchwork_22778_full absolutely 
> need to be  verified manually.
>
>  If you think the reported changes have nothing to do with the changes  
> introduced in Patchwork_22778_full, please notify your bug team to 
> allow them  to document this new failure mode, which will reduce false positives in CI.
>
>
>
>Participating hosts (12 -> 13)
>------------------------------
>
>  Additional (1): shard-dg1
>
>Possible new issues
>-------------------
>
>  Here are the unknown changes that may have been introduced in Patchwork_22778_full:
>
>### IGT changes ###
>
>#### Possible regressions ####
>
>  * igt@gen9_exec_parse@allowed-all:
>    - shard-skl:          [PASS][1] -> [DMESG-WARN][2]
>   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11452/shard-skl1/igt@gen9_exec_parse@allowed-all.html
>   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-skl4/igt@gen9_exec_parse@allowed-all.html
>    - shard-apl:          [PASS][3] -> [DMESG-WARN][4]
>   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11452/shard-apl4/igt@gen9_exec_parse@allowed-all.html
>   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-apl7/igt@gen9_exec_parse@allowed-all.html
>    - shard-glk:          [PASS][5] -> [DMESG-WARN][6]
>   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11452/shard-glk1/igt@gen9_exec_parse@allowed-all.html
>   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-glk8/igt@gen9_exec_parse@allowed-all.html
>    - shard-kbl:          [PASS][7] -> [DMESG-WARN][8]
>   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11452/shard-kbl6/igt@gen9_exec_parse@allowed-all.html
>   [8]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-kbl7/ig
> t@gen9_exec_parse@allowed-all.html

don't shoot the messenger :)

Lakshmi, these need to be mapped to previous failures. Here we are just changing the message logged to make clear they aren't caused by the register we are currently reading/writting, but it's rather cause by a previous read/write.

All of these should have a previous issue already with the different message, not being caused by this patch.

Lucas De Marchi

>
>
>#### Suppressed ####
>
>  The following results come from untrusted machines, tests, or statuses.
>  They do not affect the overall result.
>
>  * igt@i915_pm_rpm@system-suspend-devices:
>    - {shard-rkl}:        [PASS][9] -> [FAIL][10]
>   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11452/shard-rkl-1/igt@i915_pm_rpm@system-suspend-devices.html
>   [10]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-rkl-5/i
> gt@i915_pm_rpm@system-suspend-devices.html
>
>
>Known issues
>------------
>
>  Here are the changes found in Patchwork_22778_full that come from known issues:
>
>### CI changes ###
>
>#### Issues hit ####
>
>  * boot:
>    - shard-skl:          ([PASS][11], [PASS][12], [PASS][13], [PASS][14], [PASS][15], [PASS][16], [PASS][17], [PASS][18], [PASS][19], [PASS][20], [PASS][21], [PASS][22], [PASS][23], [PASS][24], [PASS][25], [PASS][26], [PASS][27], [PASS][28], [PASS][29], [PASS][30], [PASS][31], [PASS][32], [PASS][33], [PASS][34], [PASS][35]) -> ([PASS][36], [PASS][37], [PASS][38], [PASS][39], [PASS][40], [PASS][41], [PASS][42], [PASS][43], [PASS][44], [PASS][45], [PASS][46], [FAIL][47], [PASS][48], [PASS][49], [PASS][50], [PASS][51], [PASS][52], [PASS][53], [PASS][54], [PASS][55], [PASS][56], [PASS][57]) ([i915#5032])
>   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11452/shard-skl9/boot.html
>   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11452/shard-skl9/boot.html
>   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11452/shard-skl9/boot.html
>   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11452/shard-skl8/boot.html
>   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11452/shard-skl8/boot.html
>   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11452/shard-skl8/boot.html
>   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11452/shard-skl7/boot.html
>   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11452/shard-skl7/boot.html
>   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11452/shard-skl7/boot.html
>   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11452/shard-skl7/boot.html
>   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11452/shard-skl6/boot.html
>   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11452/shard-skl6/boot.html
>   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11452/shard-skl6/boot.html
>   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11452/shard-skl6/boot.html
>   [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11452/shard-skl4/boot.html
>   [26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11452/shard-skl4/boot.html
>   [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11452/shard-skl4/boot.html
>   [28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11452/shard-skl4/boot.html
>   [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11452/shard-skl1/boot.html
>   [30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11452/shard-skl1/boot.html
>   [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11452/shard-skl1/boot.html
>   [32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11452/shard-skl1/boot.html
>   [33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11452/shard-skl10/boot.html
>   [34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11452/shard-skl10/boot.html
>   [35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11452/shard-skl10/boot.html
>   [36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-skl9/boot.html
>   [37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-skl9/boot.html
>   [38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-skl8/boot.html
>   [39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-skl8/boot.html
>   [40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-skl8/boot.html
>   [41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-skl7/boot.html
>   [42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-skl7/boot.html
>   [43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-skl7/boot.html
>   [44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-skl6/boot.html
>   [45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-skl6/boot.html
>   [46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-skl5/boot.html
>   [47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-skl5/boot.html
>   [48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-skl4/boot.html
>   [49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-skl4/boot.html
>   [50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-skl4/boot.html
>   [51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-skl2/boot.html
>   [52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-skl1/boot.html
>   [53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-skl1/boot.html
>   [54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-skl1/boot.html
>   [55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-skl10/boot.html
>   [56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-skl10/boot.html
>   [57]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-skl10/b
> oot.html
>
>
>
>### IGT changes ###
>
>#### Issues hit ####
>
>  * igt@gem_exec_balancer@parallel:
>    - shard-kbl:          NOTRUN -> [DMESG-WARN][58] ([i915#5076])
>   [58]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-kbl6/ig
> t@gem_exec_balancer@parallel.html
>
>  * igt@gem_exec_fair@basic-deadline:
>    - shard-glk:          [PASS][59] -> [FAIL][60] ([i915#2846])
>   [59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11452/shard-glk2/igt@gem_exec_fair@basic-deadline.html
>   [60]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-glk8/ig
> t@gem_exec_fair@basic-deadline.html
>
>  * igt@gem_exec_fair@basic-none-share@rcs0:
>    - shard-kbl:          [PASS][61] -> [FAIL][62] ([i915#2842]) +2 similar issues
>   [61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11452/shard-kbl3/igt@gem_exec_fair@basic-none-share@rcs0.html
>   [62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-kbl3/igt@gem_exec_fair@basic-none-share@rcs0.html
>    - shard-iclb:         [PASS][63] -> [FAIL][64] ([i915#2842])
>   [63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11452/shard-iclb7/igt@gem_exec_fair@basic-none-share@rcs0.html
>   [64]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-iclb2/i
> gt@gem_exec_fair@basic-none-share@rcs0.html
>
>  * igt@gem_exec_fair@basic-none-solo@rcs0:
>    - shard-apl:          [PASS][65] -> [FAIL][66] ([i915#2842]) +1 similar issue
>   [65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11452/shard-apl3/igt@gem_exec_fair@basic-none-solo@rcs0.html
>   [66]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-apl4/ig
> t@gem_exec_fair@basic-none-solo@rcs0.html
>
>  * igt@gem_exec_fair@basic-pace@bcs0:
>    - shard-apl:          NOTRUN -> [SKIP][67] ([fdo#109271]) +47 similar issues
>   [67]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-apl7/ig
> t@gem_exec_fair@basic-pace@bcs0.html
>
>  * igt@gem_exec_fair@basic-pace@rcs0:
>    - shard-glk:          [PASS][68] -> [FAIL][69] ([i915#2842])
>   [68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11452/shard-glk5/igt@gem_exec_fair@basic-pace@rcs0.html
>   [69]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-glk1/ig
> t@gem_exec_fair@basic-pace@rcs0.html
>
>  * igt@gem_lmem_swapping@heavy-random:
>    - shard-iclb:         NOTRUN -> [SKIP][70] ([i915#4613])
>   [70]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-iclb5/i
> gt@gem_lmem_swapping@heavy-random.html
>
>  * igt@gem_ppgtt@flink-and-close-vma-leak:
>    - shard-glk:          [PASS][71] -> [FAIL][72] ([i915#644])
>   [71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11452/shard-glk3/igt@gem_ppgtt@flink-and-close-vma-leak.html
>   [72]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-glk5/ig
> t@gem_ppgtt@flink-and-close-vma-leak.html
>
>  * igt@gem_pxp@verify-pxp-key-change-after-suspend-resume:
>    - shard-iclb:         NOTRUN -> [SKIP][73] ([i915#4270])
>   [73]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-iclb5/i
> gt@gem_pxp@verify-pxp-key-change-after-suspend-resume.html
>
>  * igt@gem_render_copy@linear-to-vebox-yf-tiled:
>    - shard-kbl:          NOTRUN -> [SKIP][74] ([fdo#109271]) +9 similar issues
>   [74]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-kbl6/ig
> t@gem_render_copy@linear-to-vebox-yf-tiled.html
>
>  * igt@gem_userptr_blits@access-control:
>    - shard-iclb:         NOTRUN -> [SKIP][75] ([i915#3297]) +1 similar issue
>   [75]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-iclb5/i
> gt@gem_userptr_blits@access-control.html
>
>  * igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-180:
>    - shard-iclb:         NOTRUN -> [SKIP][76] ([i915#5286]) +1 similar issue
>   [76]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-iclb5/i
> gt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-180.html
>
>  * igt@kms_big_fb@linear-8bpp-rotate-90:
>    - shard-iclb:         NOTRUN -> [SKIP][77] ([fdo#110725] / [fdo#111614])
>   [77]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-iclb5/i
> gt@kms_big_fb@linear-8bpp-rotate-90.html
>
>  * igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-0-hflip:
>    - shard-apl:          NOTRUN -> [SKIP][78] ([fdo#109271] / [i915#3777]) +1 similar issue
>   [78]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-apl2/ig
> t@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-0-hflip.html
>
>  * igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-180-hflip:
>    - shard-kbl:          NOTRUN -> [SKIP][79] ([fdo#109271] / [i915#3777])
>   [79]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-kbl6/ig
> t@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-180-hflip.html
>
>  * igt@kms_big_fb@yf-tiled-max-hw-stride-64bpp-rotate-0-hflip:
>    - shard-iclb:         NOTRUN -> [SKIP][80] ([fdo#110723])
>   [80]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-iclb5/i
> gt@kms_big_fb@yf-tiled-max-hw-stride-64bpp-rotate-0-hflip.html
>
>  * igt@kms_ccs@pipe-b-missing-ccs-buffer-y_tiled_gen12_rc_ccs_cc:
>    - shard-apl:          NOTRUN -> [SKIP][81] ([fdo#109271] / [i915#3886]) +4 similar issues
>   [81]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-apl2/ig
> t@kms_ccs@pipe-b-missing-ccs-buffer-y_tiled_gen12_rc_ccs_cc.html
>
>  * igt@kms_ccs@pipe-c-crc-primary-basic-y_tiled_gen12_rc_ccs_cc:
>    - shard-skl:          NOTRUN -> [SKIP][82] ([fdo#109271] / [i915#3886])
>   [82]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-skl8/ig
> t@kms_ccs@pipe-c-crc-primary-basic-y_tiled_gen12_rc_ccs_cc.html
>
>  * igt@kms_chamelium@dp-hpd-storm:
>    - shard-apl:          NOTRUN -> [SKIP][83] ([fdo#109271] / [fdo#111827]) +5 similar issues
>   [83]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-apl1/ig
> t@kms_chamelium@dp-hpd-storm.html
>
>  * igt@kms_chamelium@hdmi-audio:
>    - shard-iclb:         NOTRUN -> [SKIP][84] ([fdo#109284] / [fdo#111827]) +2 similar issues
>   [84]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-iclb5/i
> gt@kms_chamelium@hdmi-audio.html
>
>  * igt@kms_chamelium@hdmi-hpd-storm-disable:
>    - shard-kbl:          NOTRUN -> [SKIP][85] ([fdo#109271] / [fdo#111827]) +1 similar issue
>   [85]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-kbl6/ig
> t@kms_chamelium@hdmi-hpd-storm-disable.html
>
>  * igt@kms_color@pipe-c-ctm-max:
>    - shard-kbl:          [PASS][86] -> [DMESG-WARN][87] ([i915#62] / [i915#92]) +19 similar issues
>   [86]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11452/shard-kbl6/igt@kms_color@pipe-c-ctm-max.html
>   [87]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-kbl6/ig
> t@kms_color@pipe-c-ctm-max.html
>
>  * igt@kms_cursor_legacy@cursora-vs-flipb-atomic-transitions-varying-size:
>    - shard-iclb:         NOTRUN -> [SKIP][88] ([fdo#109274] / [fdo#109278])
>   [88]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-iclb5/i
> gt@kms_cursor_legacy@cursora-vs-flipb-atomic-transitions-varying-size.
> html
>
>  * igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size:
>    - shard-iclb:         [PASS][89] -> [FAIL][90] ([i915#2346])
>   [89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11452/shard-iclb8/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
>   [90]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-iclb7/i
> gt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.ht
> ml
>
>  * igt@kms_draw_crc@draw-method-rgb565-mmap-cpu-untiled:
>    - shard-glk:          [PASS][91] -> [FAIL][92] ([i915#5160])
>   [91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11452/shard-glk9/igt@kms_draw_crc@draw-method-rgb565-mmap-cpu-untiled.html
>   [92]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-glk6/ig
> t@kms_draw_crc@draw-method-rgb565-mmap-cpu-untiled.html
>
>  * igt@kms_flip@2x-blocking-wf_vblank:
>    - shard-iclb:         NOTRUN -> [SKIP][93] ([fdo#109274]) +1 similar issue
>   [93]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-iclb5/i
> gt@kms_flip@2x-blocking-wf_vblank.html
>
>  * igt@kms_flip@flip-vs-expired-vblank@c-hdmi-a2:
>    - shard-glk:          [PASS][94] -> [FAIL][95] ([i915#79]) +1 similar issue
>   [94]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11452/shard-glk8/igt@kms_flip@flip-vs-expired-vblank@c-hdmi-a2.html
>   [95]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-glk4/ig
> t@kms_flip@flip-vs-expired-vblank@c-hdmi-a2.html
>
>  * igt@kms_flip@flip-vs-suspend-interruptible@c-dp1:
>    - shard-apl:          [PASS][96] -> [DMESG-WARN][97] ([i915#180]) +2 similar issues
>   [96]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11452/shard-apl2/igt@kms_flip@flip-vs-suspend-interruptible@c-dp1.html
>   [97]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-apl6/ig
> t@kms_flip@flip-vs-suspend-interruptible@c-dp1.html
>
>  * igt@kms_flip@flip-vs-suspend@a-dp1:
>    - shard-kbl:          [PASS][98] -> [DMESG-WARN][99] ([i915#180]) +2 similar issues
>   [98]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11452/shard-kbl3/igt@kms_flip@flip-vs-suspend@a-dp1.html
>   [99]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-kbl6/ig
> t@kms_flip@flip-vs-suspend@a-dp1.html
>
>  * igt@kms_flip@plain-flip-fb-recreate-interruptible@a-dp1:
>    - shard-kbl:          [PASS][100] -> [FAIL][101] ([i915#2122])
>   [100]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11452/shard-kbl1/igt@kms_flip@plain-flip-fb-recreate-interruptible@a-dp1.html
>   [101]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-kbl1/ig
> t@kms_flip@plain-flip-fb-recreate-interruptible@a-dp1.html
>
>  * igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile-upscaling:
>    - shard-glk:          [PASS][102] -> [FAIL][103] ([i915#4911])
>   [102]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11452/shard-glk5/igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile-upscaling.html
>   [103]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-glk8/ig
> t@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile-upscaling.htm
> l
>
>  * igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytile-downscaling:
>    - shard-iclb:         [PASS][104] -> [SKIP][105] ([i915#3701])
>   [104]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11452/shard-iclb7/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytile-downscaling.html
>   [105]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-iclb2/i
> gt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytile-downscaling.htm
> l
>
>  * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-shrfb-msflip-blt:
>    - shard-kbl:          [PASS][106] -> [DMESG-WARN][107] ([i915#1982] / [i915#62] / [i915#92])
>   [106]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11452/shard-kbl6/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-shrfb-msflip-blt.html
>   [107]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-kbl6/ig
> t@kms_frontbuffer_tracking@fbc-1p-primscrn-shrfb-msflip-blt.html
>
>  * igt@kms_frontbuffer_tracking@fbc-2p-pri-indfb-multidraw:
>    - shard-iclb:         NOTRUN -> [SKIP][108] ([fdo#109280]) +8 similar issues
>   [108]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-iclb5/i
> gt@kms_frontbuffer_tracking@fbc-2p-pri-indfb-multidraw.html
>
>  * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-indfb-msflip-blt:
>    - shard-skl:          NOTRUN -> [SKIP][109] ([fdo#109271]) +8 similar issues
>   [109]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-skl8/ig
> t@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-indfb-msflip-blt.html
>
>  * igt@kms_hdr@static-toggle-dpms:
>    - shard-iclb:         NOTRUN -> [SKIP][110] ([i915#3555])
>   [110]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-iclb5/i
> gt@kms_hdr@static-toggle-dpms.html
>
>  * igt@kms_pipe_b_c_ivb@enable-pipe-c-while-b-has-3-lanes:
>    - shard-iclb:         NOTRUN -> [SKIP][111] ([fdo#109289])
>   [111]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-iclb5/i
> gt@kms_pipe_b_c_ivb@enable-pipe-c-while-b-has-3-lanes.html
>
>  * igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
>    - shard-apl:          NOTRUN -> [DMESG-WARN][112] ([i915#180])
>   [112]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-apl6/ig
> t@kms_pipe_crc_basic@suspend-read-crc-pipe-b.html
>
>  * igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min:
>    - shard-skl:          NOTRUN -> [FAIL][113] ([fdo#108145] / [i915#265])
>   [113]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-skl8/ig
> t@kms_plane_alpha_blend@pipe-a-constant-alpha-min.html
>
>  * igt@kms_plane_alpha_blend@pipe-b-alpha-basic:
>    - shard-apl:          NOTRUN -> [FAIL][114] ([fdo#108145] / [i915#265])
>   [114]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-apl2/ig
> t@kms_plane_alpha_blend@pipe-b-alpha-basic.html
>
>  * igt@kms_plane_cursor@pipe-d-primary-size-128:
>    - shard-iclb:         NOTRUN -> [SKIP][115] ([fdo#109278]) +6 similar issues
>   [115]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-iclb5/i
> gt@kms_plane_cursor@pipe-d-primary-size-128.html
>
>  * igt@kms_psr2_sf@plane-move-sf-dmg-area:
>    - shard-iclb:         NOTRUN -> [SKIP][116] ([fdo#111068] / [i915#658])
>   [116]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-iclb5/i
> gt@kms_psr2_sf@plane-move-sf-dmg-area.html
>
>  * igt@kms_psr2_su@frontbuffer-xrgb8888:
>    - shard-apl:          NOTRUN -> [SKIP][117] ([fdo#109271] / [i915#658])
>   [117]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-apl2/ig
> t@kms_psr2_su@frontbuffer-xrgb8888.html
>
>  * igt@kms_scaling_modes@scaling-mode-none@edp-1-pipe-c:
>    - shard-iclb:         NOTRUN -> [SKIP][118] ([i915#5030]) +2 similar issues
>   [118]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-iclb5/i
> gt@kms_scaling_modes@scaling-mode-none@edp-1-pipe-c.html
>
>  * igt@kms_writeback@writeback-invalid-parameters:
>    - shard-apl:          NOTRUN -> [SKIP][119] ([fdo#109271] / [i915#2437])
>   [119]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-apl2/ig
> t@kms_writeback@writeback-invalid-parameters.html
>
>  * igt@nouveau_crc@pipe-a-ctx-flip-detection:
>    - shard-iclb:         NOTRUN -> [SKIP][120] ([i915#2530])
>   [120]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-iclb5/i
> gt@nouveau_crc@pipe-a-ctx-flip-detection.html
>
>  * igt@perf@polling-parameterized:
>    - shard-tglb:         [PASS][121] -> [FAIL][122] ([i915#1542])
>   [121]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11452/shard-tglb7/igt@perf@polling-parameterized.html
>   [122]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-tglb7/i
> gt@perf@polling-parameterized.html
>
>  * igt@prime_udl:
>    - shard-iclb:         NOTRUN -> [SKIP][123] ([fdo#109291])
>   [123]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-iclb5/i
> gt@prime_udl.html
>
>  * igt@syncobj_timeline@invalid-single-wait-available-unsubmitted:
>    - shard-skl:          [PASS][124] -> [DMESG-WARN][125] ([i915#1982])
>   [124]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11452/shard-skl8/igt@syncobj_timeline@invalid-single-wait-available-unsubmitted.html
>   [125]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-skl6/ig
> t@syncobj_timeline@invalid-single-wait-available-unsubmitted.html
>
>
>#### Possible fixes ####
>
>  * igt@fbdev@nullptr:
>    - {shard-rkl}:        [SKIP][126] ([i915#2582]) -> [PASS][127]
>   [126]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11452/shard-rkl-2/igt@fbdev@nullptr.html
>   [127]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-rkl-6/i
> gt@fbdev@nullptr.html
>
>  * igt@gem_exec_fair@basic-none-share@rcs0:
>    - shard-tglb:         [FAIL][128] ([i915#2842]) -> [PASS][129]
>   [128]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11452/shard-tglb1/igt@gem_exec_fair@basic-none-share@rcs0.html
>   [129]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-tglb2/i
> gt@gem_exec_fair@basic-none-share@rcs0.html
>
>  * igt@gem_exec_fair@basic-pace-solo@rcs0:
>    - shard-glk:          [FAIL][130] ([i915#2842]) -> [PASS][131]
>   [130]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11452/shard-glk5/igt@gem_exec_fair@basic-pace-solo@rcs0.html
>   [131]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-glk3/ig
> t@gem_exec_fair@basic-pace-solo@rcs0.html
>
>  * igt@gem_exec_fair@basic-throttle@rcs0:
>    - shard-iclb:         [FAIL][132] ([i915#2842]) -> [PASS][133]
>   [132]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11452/shard-iclb8/igt@gem_exec_fair@basic-throttle@rcs0.html
>   [133]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-iclb7/i
> gt@gem_exec_fair@basic-throttle@rcs0.html
>
>  * igt@gem_exec_schedule@smoketest@rcs0:
>    - shard-glk:          [DMESG-WARN][134] ([i915#118]) -> [PASS][135]
>   [134]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11452/shard-glk6/igt@gem_exec_schedule@smoketest@rcs0.html
>   [135]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-glk7/ig
> t@gem_exec_schedule@smoketest@rcs0.html
>
>  * igt@gem_mmap_offset@clear:
>    - {shard-rkl}:        [INCOMPLETE][136] ([i915#1373]) -> [PASS][137]
>   [136]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11452/shard-rkl-5/igt@gem_mmap_offset@clear.html
>   [137]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-rkl-1/i
> gt@gem_mmap_offset@clear.html
>
>  * igt@i915_pm_dc@dc6-psr:
>    - shard-iclb:         [FAIL][138] ([i915#454]) -> [PASS][139]
>   [138]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11452/shard-iclb3/igt@i915_pm_dc@dc6-psr.html
>   [139]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-iclb6/i
> gt@i915_pm_dc@dc6-psr.html
>
>  * igt@kms_color@pipe-b-ctm-red-to-blue:
>    - {shard-rkl}:        [SKIP][140] ([i915#1149] / [i915#1849] / [i915#4070] / [i915#4098]) -> [PASS][141]
>   [140]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11452/shard-rkl-2/igt@kms_color@pipe-b-ctm-red-to-blue.html
>   [141]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-rkl-6/i
> gt@kms_color@pipe-b-ctm-red-to-blue.html
>
>  * igt@kms_cursor_crc@pipe-a-cursor-64x21-rapid-movement:
>    - {shard-rkl}:        ([SKIP][142], [SKIP][143]) ([fdo#112022] / [i915#4070]) -> [PASS][144] +1 similar issue
>   [142]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11452/shard-rkl-4/igt@kms_cursor_crc@pipe-a-cursor-64x21-rapid-movement.html
>   [143]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11452/shard-rkl-2/igt@kms_cursor_crc@pipe-a-cursor-64x21-rapid-movement.html
>   [144]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-rkl-6/i
> gt@kms_cursor_crc@pipe-a-cursor-64x21-rapid-movement.html
>
>  * igt@kms_cursor_crc@pipe-b-cursor-256x256-sliding:
>    - {shard-rkl}:        [SKIP][145] ([fdo#112022] / [i915#4070]) -> [PASS][146] +2 similar issues
>   [145]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11452/shard-rkl-2/igt@kms_cursor_crc@pipe-b-cursor-256x256-sliding.html
>   [146]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-rkl-6/i
> gt@kms_cursor_crc@pipe-b-cursor-256x256-sliding.html
>
>  * igt@kms_cursor_crc@pipe-c-cursor-suspend:
>    - shard-kbl:          [INCOMPLETE][147] ([i915#3614]) -> [PASS][148]
>   [147]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11452/shard-kbl4/igt@kms_cursor_crc@pipe-c-cursor-suspend.html
>   [148]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-kbl6/ig
> t@kms_cursor_crc@pipe-c-cursor-suspend.html
>
>  * igt@kms_cursor_edge_walk@pipe-a-256x256-bottom-edge:
>    - {shard-rkl}:        [SKIP][149] ([i915#1849] / [i915#4070] / [i915#4098]) -> [PASS][150] +1 similar issue
>   [149]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11452/shard-rkl-2/igt@kms_cursor_edge_walk@pipe-a-256x256-bottom-edge.html
>   [150]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-rkl-6/i
> gt@kms_cursor_edge_walk@pipe-a-256x256-bottom-edge.html
>
>  * igt@kms_cursor_legacy@cursora-vs-flipa-atomic-transitions-varying-size:
>    - {shard-rkl}:        [SKIP][151] ([fdo#111825] / [i915#4070]) -> [PASS][152] +2 similar issues
>   [151]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11452/shard-rkl-2/igt@kms_cursor_legacy@cursora-vs-flipa-atomic-transitions-varying-size.html
>   [152]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-rkl-6/i
> gt@kms_cursor_legacy@cursora-vs-flipa-atomic-transitions-varying-size.
> html
>
>  * igt@kms_cursor_legacy@flip-vs-cursor-toggle:
>    - shard-iclb:         [FAIL][153] ([i915#2346]) -> [PASS][154]
>   [153]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11452/shard-iclb7/igt@kms_cursor_legacy@flip-vs-cursor-toggle.html
>   [154]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-iclb2/i
> gt@kms_cursor_legacy@flip-vs-cursor-toggle.html
>
>  * igt@kms_draw_crc@draw-method-xrgb2101010-mmap-gtt-ytiled:
>    - {shard-rkl}:        [SKIP][155] ([fdo#111314] / [i915#4098] / [i915#4369]) -> [PASS][156] +1 similar issue
>   [155]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11452/shard-rkl-2/igt@kms_draw_crc@draw-method-xrgb2101010-mmap-gtt-ytiled.html
>   [156]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-rkl-6/i
> gt@kms_draw_crc@draw-method-xrgb2101010-mmap-gtt-ytiled.html
>
>  * igt@kms_draw_crc@draw-method-xrgb8888-pwrite-ytiled:
>    - {shard-rkl}:        [SKIP][157] ([i915#4098] / [i915#4369]) -> [PASS][158]
>   [157]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11452/shard-rkl-4/igt@kms_draw_crc@draw-method-xrgb8888-pwrite-ytiled.html
>   [158]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-rkl-6/i
> gt@kms_draw_crc@draw-method-xrgb8888-pwrite-ytiled.html
>
>  * igt@kms_flip@flip-vs-expired-vblank-interruptible@b-edp1:
>    - shard-skl:          [FAIL][159] ([i915#79]) -> [PASS][160]
>   [159]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11452/shard-skl6/igt@kms_flip@flip-vs-expired-vblank-interruptible@b-edp1.html
>   [160]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-skl1/ig
> t@kms_flip@flip-vs-expired-vblank-interruptible@b-edp1.html
>
>  * igt@kms_flip@flip-vs-suspend-interruptible@a-dp1:
>    - shard-apl:          [DMESG-WARN][161] ([i915#180]) -> [PASS][162] +8 similar issues
>   [161]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11452/shard-apl2/igt@kms_flip@flip-vs-suspend-interruptible@a-dp1.html
>   [162]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-apl6/ig
> t@kms_flip@flip-vs-suspend-interruptible@a-dp1.html
>
>  * igt@kms_flip@flip-vs-suspend@c-edp1:
>    - shard-tglb:         [DMESG-WARN][163] ([i915#2411] / [i915#2867]) -> [PASS][164]
>   [163]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11452/shard-tglb5/igt@kms_flip@flip-vs-suspend@c-edp1.html
>   [164]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/shard-tglb6/i
> gt@kms_flip@flip-vs-suspend@c-edp1.html
>
>  * igt@kms_flip@plain-flip-fb-recreate-interruptible@a-hdmi-a1:
>    - shard-glk:          [FAIL][165] ([i915#2122]) -> [PASS][166]
>   [165]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11452/sh
>
>== Logs ==
>
>For more details see: 
>https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22778/index.html
Matt Roper April 6, 2022, 4:02 a.m. UTC | #3
On Mon, Apr 04, 2022 at 05:11:49PM -0700, Lucas De Marchi wrote:
> Since gen6 we use FPGA_DBG register to detect unclaimed MMIO registers.
> This register is in the display engine IP and can only ever detect
> unclaimed accesses to registers in this area. However sometimes there
> are reports of this triggering for registers in other areas, which
> should not be possible.
> 
> Right now we always warn after the read/write of registers going through
> unclaimed_reg_debug(). However places using __raw_uncore_* may be
> triggering the unclaimed access and those being later accounted to a
> different register. Let's warn both before and after the read/write
> with a slightly different message, so it's clear if the register
> reported in the warning is actually the culprit.

You should probably probably give an explicit mention of commit
dda960335e020 ("drm/i915: Just clear the mmiodebug before a register
access") in the commit message since we're reversing direction here.

> 
> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
> ---
>  drivers/gpu/drm/i915/intel_uncore.c | 29 +++++++++++++++++++++--------
>  1 file changed, 21 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_uncore.c b/drivers/gpu/drm/i915/intel_uncore.c
> index 8b9caaaacc21..df59ec88459e 100644
> --- a/drivers/gpu/drm/i915/intel_uncore.c
> +++ b/drivers/gpu/drm/i915/intel_uncore.c
> @@ -1502,11 +1502,10 @@ ilk_dummy_write(struct intel_uncore *uncore)
>  static void
>  __unclaimed_reg_debug(struct intel_uncore *uncore,
>  		      const i915_reg_t reg,
> -		      const bool read,
> -		      const bool before)
> +		      const bool read)
>  {
>  	if (drm_WARN(&uncore->i915->drm,
> -		     check_for_unclaimed_mmio(uncore) && !before,
> +		     check_for_unclaimed_mmio(uncore),
>  		     "Unclaimed %s register 0x%x\n",

Might be simpler to just keep it all in one function and do something
like a

        before ? "MMIO operation *before* a " : ""

in the message?  Up to you.  Either way,

Reviewed-by: Matt Roper <matthew.d.roper@intel.com>

>  		     read ? "read from" : "write to",
>  		     i915_mmio_reg_offset(reg)))
> @@ -1514,6 +1513,20 @@ __unclaimed_reg_debug(struct intel_uncore *uncore,
>  		uncore->i915->params.mmio_debug--;
>  }
>  
> +static void
> +__unclaimed_previous_reg_debug(struct intel_uncore *uncore,
> +			       const i915_reg_t reg,
> +			       const bool read)
> +{
> +	if (drm_WARN(&uncore->i915->drm,
> +		     check_for_unclaimed_mmio(uncore),
> +		     "Unclaimed access detected before %s register 0x%x\n",
> +		     read ? "read from" : "write to",
> +		     i915_mmio_reg_offset(reg)))
> +		/* Only report the first N failures */
> +		uncore->i915->params.mmio_debug--;
> +}
> +
>  static inline void
>  unclaimed_reg_debug(struct intel_uncore *uncore,
>  		    const i915_reg_t reg,
> @@ -1526,13 +1539,13 @@ unclaimed_reg_debug(struct intel_uncore *uncore,
>  	/* interrupts are disabled and re-enabled around uncore->lock usage */
>  	lockdep_assert_held(&uncore->lock);
>  
> -	if (before)
> +	if (before) {
>  		spin_lock(&uncore->debug->lock);
> -
> -	__unclaimed_reg_debug(uncore, reg, read, before);
> -
> -	if (!before)
> +		__unclaimed_previous_reg_debug(uncore, reg, read);
> +	} else {
> +		__unclaimed_reg_debug(uncore, reg, read);
>  		spin_unlock(&uncore->debug->lock);
> +	}
>  }
>  
>  #define __vgpu_read(x) \
> -- 
> 2.35.1
>
Lucas De Marchi April 6, 2022, 5:53 a.m. UTC | #4
On Tue, Apr 05, 2022 at 09:02:42PM -0700, Matt Roper wrote:
>On Mon, Apr 04, 2022 at 05:11:49PM -0700, Lucas De Marchi wrote:
>> Since gen6 we use FPGA_DBG register to detect unclaimed MMIO registers.
>> This register is in the display engine IP and can only ever detect
>> unclaimed accesses to registers in this area. However sometimes there
>> are reports of this triggering for registers in other areas, which
>> should not be possible.
>>
>> Right now we always warn after the read/write of registers going through
>> unclaimed_reg_debug(). However places using __raw_uncore_* may be
>> triggering the unclaimed access and those being later accounted to a
>> different register. Let's warn both before and after the read/write
>> with a slightly different message, so it's clear if the register
>> reported in the warning is actually the culprit.
>
>You should probably probably give an explicit mention of commit
>dda960335e020 ("drm/i915: Just clear the mmiodebug before a register
>access") in the commit message since we're reversing direction here.

I will add a note about that commit, but this is not going a reverse
direction: The reason for the change is exactly the same as expressed in
that commit:  earlier failures being accounted for unrelated registers.
In that commit it dropped the warning before the read, but it failed to
account for cases like we are having: a read or write to a non-display
register will still read FPGA_DBG and be marked as failure. Even if it's
unrelated to the register that actually caused the failure. So I think
this is just a slightly different implementation: instead of dropping the
warning, warn with a more appropriate message to be clear what happened.


>
>>
>> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
>> ---
>>  drivers/gpu/drm/i915/intel_uncore.c | 29 +++++++++++++++++++++--------
>>  1 file changed, 21 insertions(+), 8 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/i915/intel_uncore.c b/drivers/gpu/drm/i915/intel_uncore.c
>> index 8b9caaaacc21..df59ec88459e 100644
>> --- a/drivers/gpu/drm/i915/intel_uncore.c
>> +++ b/drivers/gpu/drm/i915/intel_uncore.c
>> @@ -1502,11 +1502,10 @@ ilk_dummy_write(struct intel_uncore *uncore)
>>  static void
>>  __unclaimed_reg_debug(struct intel_uncore *uncore,
>>  		      const i915_reg_t reg,
>> -		      const bool read,
>> -		      const bool before)
>> +		      const bool read)
>>  {
>>  	if (drm_WARN(&uncore->i915->drm,
>> -		     check_for_unclaimed_mmio(uncore) && !before,
>> +		     check_for_unclaimed_mmio(uncore),
>>  		     "Unclaimed %s register 0x%x\n",
>
>Might be simpler to just keep it all in one function and do something
>like a
>
>        before ? "MMIO operation *before* a " : ""
>
>in the message?  Up to you.  Either way,

those bool arguments ar too easy to mess up in the caller IMO. I'd
rather keep different functions, particularly since it's just a few
lines.

>
>Reviewed-by: Matt Roper <matthew.d.roper@intel.com>

thanks
Lucas De Marchi

>
>>  		     read ? "read from" : "write to",
>>  		     i915_mmio_reg_offset(reg)))
>> @@ -1514,6 +1513,20 @@ __unclaimed_reg_debug(struct intel_uncore *uncore,
>>  		uncore->i915->params.mmio_debug--;
>>  }
>>
>> +static void
>> +__unclaimed_previous_reg_debug(struct intel_uncore *uncore,
>> +			       const i915_reg_t reg,
>> +			       const bool read)
>> +{
>> +	if (drm_WARN(&uncore->i915->drm,
>> +		     check_for_unclaimed_mmio(uncore),
>> +		     "Unclaimed access detected before %s register 0x%x\n",
>> +		     read ? "read from" : "write to",
>> +		     i915_mmio_reg_offset(reg)))
>> +		/* Only report the first N failures */
>> +		uncore->i915->params.mmio_debug--;
>> +}
>> +
>>  static inline void
>>  unclaimed_reg_debug(struct intel_uncore *uncore,
>>  		    const i915_reg_t reg,
>> @@ -1526,13 +1539,13 @@ unclaimed_reg_debug(struct intel_uncore *uncore,
>>  	/* interrupts are disabled and re-enabled around uncore->lock usage */
>>  	lockdep_assert_held(&uncore->lock);
>>
>> -	if (before)
>> +	if (before) {
>>  		spin_lock(&uncore->debug->lock);
>> -
>> -	__unclaimed_reg_debug(uncore, reg, read, before);
>> -
>> -	if (!before)
>> +		__unclaimed_previous_reg_debug(uncore, reg, read);
>> +	} else {
>> +		__unclaimed_reg_debug(uncore, reg, read);
>>  		spin_unlock(&uncore->debug->lock);
>> +	}
>>  }
>>
>>  #define __vgpu_read(x) \
>> --
>> 2.35.1
>>
>
>-- 
>Matt Roper
>Graphics Software Engineer
>VTT-OSGC Platform Enablement
>Intel Corporation
>(916) 356-2795
Lucas De Marchi April 6, 2022, 8:35 p.m. UTC | #5
On Tue, Apr 05, 2022 at 10:53:43PM -0700, Lucas De Marchi wrote:
>On Tue, Apr 05, 2022 at 09:02:42PM -0700, Matt Roper wrote:
>>On Mon, Apr 04, 2022 at 05:11:49PM -0700, Lucas De Marchi wrote:
>>>Since gen6 we use FPGA_DBG register to detect unclaimed MMIO registers.
>>>This register is in the display engine IP and can only ever detect
>>>unclaimed accesses to registers in this area. However sometimes there
>>>are reports of this triggering for registers in other areas, which
>>>should not be possible.
>>>
>>>Right now we always warn after the read/write of registers going through
>>>unclaimed_reg_debug(). However places using __raw_uncore_* may be
>>>triggering the unclaimed access and those being later accounted to a
>>>different register. Let's warn both before and after the read/write
>>>with a slightly different message, so it's clear if the register
>>>reported in the warning is actually the culprit.
>>
>>You should probably probably give an explicit mention of commit
>>dda960335e020 ("drm/i915: Just clear the mmiodebug before a register
>>access") in the commit message since we're reversing direction here.
>
>I will add a note about that commit, but this is not going a reverse
>direction: The reason for the change is exactly the same as expressed in
>that commit:  earlier failures being accounted for unrelated registers.
>In that commit it dropped the warning before the read, but it failed to
>account for cases like we are having: a read or write to a non-display
>register will still read FPGA_DBG and be marked as failure. Even if it's
>unrelated to the register that actually caused the failure. So I think
>this is just a slightly different implementation: instead of dropping the
>warning, warn with a more appropriate message to be clear what happened.
>
>
>>
>>>
>>>Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
>>>---
>>> drivers/gpu/drm/i915/intel_uncore.c | 29 +++++++++++++++++++++--------
>>> 1 file changed, 21 insertions(+), 8 deletions(-)
>>>
>>>diff --git a/drivers/gpu/drm/i915/intel_uncore.c b/drivers/gpu/drm/i915/intel_uncore.c
>>>index 8b9caaaacc21..df59ec88459e 100644
>>>--- a/drivers/gpu/drm/i915/intel_uncore.c
>>>+++ b/drivers/gpu/drm/i915/intel_uncore.c
>>>@@ -1502,11 +1502,10 @@ ilk_dummy_write(struct intel_uncore *uncore)
>>> static void
>>> __unclaimed_reg_debug(struct intel_uncore *uncore,
>>> 		      const i915_reg_t reg,
>>>-		      const bool read,
>>>-		      const bool before)
>>>+		      const bool read)
>>> {
>>> 	if (drm_WARN(&uncore->i915->drm,
>>>-		     check_for_unclaimed_mmio(uncore) && !before,
>>>+		     check_for_unclaimed_mmio(uncore),
>>> 		     "Unclaimed %s register 0x%x\n",
>>
>>Might be simpler to just keep it all in one function and do something
>>like a
>>
>>       before ? "MMIO operation *before* a " : ""
>>
>>in the message?  Up to you.  Either way,
>
>those bool arguments ar too easy to mess up in the caller IMO. I'd
>rather keep different functions, particularly since it's just a few
>lines.
>
>>
>>Reviewed-by: Matt Roper <matthew.d.roper@intel.com>
>
>thanks
>Lucas De Marchi


Applied to drm-intel-next.

Lucas De Marchi
Tvrtko Ursulin April 8, 2022, 12:44 p.m. UTC | #6
On 05/04/2022 01:11, Lucas De Marchi wrote:
> Since gen6 we use FPGA_DBG register to detect unclaimed MMIO registers.
> This register is in the display engine IP and can only ever detect
> unclaimed accesses to registers in this area. However sometimes there
> are reports of this triggering for registers in other areas, which
> should not be possible.
> 
> Right now we always warn after the read/write of registers going through
> unclaimed_reg_debug(). However places using __raw_uncore_* may be
> triggering the unclaimed access and those being later accounted to a
> different register. Let's warn both before and after the read/write
> with a slightly different message, so it's clear if the register
> reported in the warning is actually the culprit.
> 
> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>

I see this triggering a lot on drm-tip today (TGL), is that expected?

[    3.994907] i915 0000:00:02.0: [drm:intel_uncore_init_mmio [i915]] unclaimed mmio detected on uncore init, clearing
[    4.392525] i915 0000:00:02.0: Unclaimed access detected before read from register 0x44408
[    5.669929] i915 0000:00:02.0: Unclaimed access detected before write to register 0x50380
[    6.652808] i915 0000:00:02.0: Unclaimed access detected before write to register 0x50380
[   13.015978] i915 0000:00:02.0: Unclaimed access detected before write to register 0x50380
[   16.876802] i915 0000:00:02.0: Unclaimed access detected before write to register 0x44404
[   45.174395] i915 0000:00:02.0: Unclaimed access detected before write to register 0x44404

It continues at runtime as well:

[10265.010902] i915 0000:00:02.0: Unclaimed access detected before write to register 0x190030
[10329.093078] i915 0000:00:02.0: Unclaimed access detected before write to register 0x190030
[10354.060331] i915 0000:00:02.0: Unclaimed access detected before write to register 0x190030
[10385.486480] i915 0000:00:02.0: Unclaimed access detected before write to register 0x190030
[10408.910533] i915 0000:00:02.0: Unclaimed access detected before write to register 0x190030
[10433.398443] i915 0000:00:02.0: Unclaimed access detected before write to register 0x1900ec
[10444.110593] i915 0000:00:02.0: Unclaimed access detected before write to register 0x190030
[10468.302627] i915 0000:00:02.0: Unclaimed access detected before write to register 0x190030
[10493.398727] i915 0000:00:02.0: Unclaimed access detected before write to register 0x1900ec
[10515.366845] i915 0000:00:02.0: Unclaimed access detected before read from register 0x44408
[10518.674046] i915 0000:00:02.0: Unclaimed access detected before read from register 0xc7204
[10529.934735] i915 0000:00:02.0: Unclaimed access detected before write to register 0x190030
[10553.398808] i915 0000:00:02.0: Unclaimed access detected before write to register 0x1900ec
[10599.684455] i915 0000:00:02.0: Unclaimed access detected before read from register 0xc4008
[10602.898167] i915 0000:00:02.0: Unclaimed access detected before read from register 0xc7204
[10613.398909] i915 0000:00:02.0: Unclaimed access detected before write to register 0x1900ec
[10686.006783] i915 0000:00:02.0: Unclaimed access detected before write to register 0x190030
[10711.906813] i915 0000:00:02.0: Unclaimed access detected before write to register 0x190030
[10745.860538] i915 0000:00:02.0: Unclaimed access detected before write to register 0x190030
[10771.812277] i915 0000:00:02.0: Unclaimed access detected before write to register 0x190030
[10805.903058] i915 0000:00:02.0: Unclaimed access detected before write to register 0x190030
[10831.927073] i915 0000:00:02.0: Unclaimed access detected before write to register 0x190030
[10853.398958] i915 0000:00:02.0: Unclaimed access detected before write to register 0x1900ec
[10866.007084] i915 0000:00:02.0: Unclaimed access detected before write to register 0x190030
[10879.378435] i915 0000:00:02.0: Unclaimed access detected before read from register 0xc7204
[10891.727120] i915 0000:00:02.0: Unclaimed access detected before write to register 0x190030
[10913.395161] i915 0000:00:02.0: Unclaimed access detected before write to register 0x1900ec
[10939.026480] i915 0000:00:02.0: Unclaimed access detected before read from register 0xc7204
[10964.626494] i915 0000:00:02.0: Unclaimed access detected before read from register 0xc7204

It don't think this machine had a problem with this before, or perhaps it was going undetected?

Regards,

Tvrtko

> ---
>   drivers/gpu/drm/i915/intel_uncore.c | 29 +++++++++++++++++++++--------
>   1 file changed, 21 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_uncore.c b/drivers/gpu/drm/i915/intel_uncore.c
> index 8b9caaaacc21..df59ec88459e 100644
> --- a/drivers/gpu/drm/i915/intel_uncore.c
> +++ b/drivers/gpu/drm/i915/intel_uncore.c
> @@ -1502,11 +1502,10 @@ ilk_dummy_write(struct intel_uncore *uncore)
>   static void
>   __unclaimed_reg_debug(struct intel_uncore *uncore,
>   		      const i915_reg_t reg,
> -		      const bool read,
> -		      const bool before)
> +		      const bool read)
>   {
>   	if (drm_WARN(&uncore->i915->drm,
> -		     check_for_unclaimed_mmio(uncore) && !before,
> +		     check_for_unclaimed_mmio(uncore),
>   		     "Unclaimed %s register 0x%x\n",
>   		     read ? "read from" : "write to",
>   		     i915_mmio_reg_offset(reg)))
> @@ -1514,6 +1513,20 @@ __unclaimed_reg_debug(struct intel_uncore *uncore,
>   		uncore->i915->params.mmio_debug--;
>   }
>   
> +static void
> +__unclaimed_previous_reg_debug(struct intel_uncore *uncore,
> +			       const i915_reg_t reg,
> +			       const bool read)
> +{
> +	if (drm_WARN(&uncore->i915->drm,
> +		     check_for_unclaimed_mmio(uncore),
> +		     "Unclaimed access detected before %s register 0x%x\n",
> +		     read ? "read from" : "write to",
> +		     i915_mmio_reg_offset(reg)))
> +		/* Only report the first N failures */
> +		uncore->i915->params.mmio_debug--;
> +}
> +
>   static inline void
>   unclaimed_reg_debug(struct intel_uncore *uncore,
>   		    const i915_reg_t reg,
> @@ -1526,13 +1539,13 @@ unclaimed_reg_debug(struct intel_uncore *uncore,
>   	/* interrupts are disabled and re-enabled around uncore->lock usage */
>   	lockdep_assert_held(&uncore->lock);
>   
> -	if (before)
> +	if (before) {
>   		spin_lock(&uncore->debug->lock);
> -
> -	__unclaimed_reg_debug(uncore, reg, read, before);
> -
> -	if (!before)
> +		__unclaimed_previous_reg_debug(uncore, reg, read);
> +	} else {
> +		__unclaimed_reg_debug(uncore, reg, read);
>   		spin_unlock(&uncore->debug->lock);
> +	}
>   }
>   
>   #define __vgpu_read(x) \
Lucas De Marchi April 8, 2022, 3 p.m. UTC | #7
On Fri, Apr 08, 2022 at 01:44:44PM +0100, Tvrtko Ursulin wrote:
>
>On 05/04/2022 01:11, Lucas De Marchi wrote:
>>Since gen6 we use FPGA_DBG register to detect unclaimed MMIO registers.
>>This register is in the display engine IP and can only ever detect
>>unclaimed accesses to registers in this area. However sometimes there
>>are reports of this triggering for registers in other areas, which
>>should not be possible.
>>
>>Right now we always warn after the read/write of registers going through
>>unclaimed_reg_debug(). However places using __raw_uncore_* may be
>>triggering the unclaimed access and those being later accounted to a
>>different register. Let's warn both before and after the read/write
>>with a slightly different message, so it's clear if the register
>>reported in the warning is actually the culprit.
>>
>>Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
>
>I see this triggering a lot on drm-tip today (TGL), is that expected?
>
>[    3.994907] i915 0000:00:02.0: [drm:intel_uncore_init_mmio [i915]] unclaimed mmio detected on uncore init, clearing
>[    4.392525] i915 0000:00:02.0: Unclaimed access detected before read from register 0x44408
>[    5.669929] i915 0000:00:02.0: Unclaimed access detected before write to register 0x50380
>[    6.652808] i915 0000:00:02.0: Unclaimed access detected before write to register 0x50380
>[   13.015978] i915 0000:00:02.0: Unclaimed access detected before write to register 0x50380
>[   16.876802] i915 0000:00:02.0: Unclaimed access detected before write to register 0x44404
>[   45.174395] i915 0000:00:02.0: Unclaimed access detected before write to register 0x44404
>
>It continues at runtime as well:
>
>[10265.010902] i915 0000:00:02.0: Unclaimed access detected before write to register 0x190030
>[10329.093078] i915 0000:00:02.0: Unclaimed access detected before write to register 0x190030
>[10354.060331] i915 0000:00:02.0: Unclaimed access detected before write to register 0x190030
>[10385.486480] i915 0000:00:02.0: Unclaimed access detected before write to register 0x190030
>[10408.910533] i915 0000:00:02.0: Unclaimed access detected before write to register 0x190030
>[10433.398443] i915 0000:00:02.0: Unclaimed access detected before write to register 0x1900ec
>[10444.110593] i915 0000:00:02.0: Unclaimed access detected before write to register 0x190030
>[10468.302627] i915 0000:00:02.0: Unclaimed access detected before write to register 0x190030
>[10493.398727] i915 0000:00:02.0: Unclaimed access detected before write to register 0x1900ec
>[10515.366845] i915 0000:00:02.0: Unclaimed access detected before read from register 0x44408
>[10518.674046] i915 0000:00:02.0: Unclaimed access detected before read from register 0xc7204
>[10529.934735] i915 0000:00:02.0: Unclaimed access detected before write to register 0x190030
>[10553.398808] i915 0000:00:02.0: Unclaimed access detected before write to register 0x1900ec
>[10599.684455] i915 0000:00:02.0: Unclaimed access detected before read from register 0xc4008
>[10602.898167] i915 0000:00:02.0: Unclaimed access detected before read from register 0xc7204
>[10613.398909] i915 0000:00:02.0: Unclaimed access detected before write to register 0x1900ec
>[10686.006783] i915 0000:00:02.0: Unclaimed access detected before write to register 0x190030
>[10711.906813] i915 0000:00:02.0: Unclaimed access detected before write to register 0x190030
>[10745.860538] i915 0000:00:02.0: Unclaimed access detected before write to register 0x190030
>[10771.812277] i915 0000:00:02.0: Unclaimed access detected before write to register 0x190030
>[10805.903058] i915 0000:00:02.0: Unclaimed access detected before write to register 0x190030
>[10831.927073] i915 0000:00:02.0: Unclaimed access detected before write to register 0x190030
>[10853.398958] i915 0000:00:02.0: Unclaimed access detected before write to register 0x1900ec
>[10866.007084] i915 0000:00:02.0: Unclaimed access detected before write to register 0x190030
>[10879.378435] i915 0000:00:02.0: Unclaimed access detected before read from register 0xc7204
>[10891.727120] i915 0000:00:02.0: Unclaimed access detected before write to register 0x190030
>[10913.395161] i915 0000:00:02.0: Unclaimed access detected before write to register 0x1900ec
>[10939.026480] i915 0000:00:02.0: Unclaimed access detected before read from register 0xc7204
>[10964.626494] i915 0000:00:02.0: Unclaimed access detected before read from register 0xc7204
>
>It don't think this machine had a problem with this before, or perhaps it was going undetected?

it was going undetected. However I have a patch to downgrade the first
message to debug, because we are clear not ready to enable the stricter
check. I will send it in a bit.

Lucas De Marchi

>
>Regards,
>
>Tvrtko
>
>>---
>>  drivers/gpu/drm/i915/intel_uncore.c | 29 +++++++++++++++++++++--------
>>  1 file changed, 21 insertions(+), 8 deletions(-)
>>
>>diff --git a/drivers/gpu/drm/i915/intel_uncore.c b/drivers/gpu/drm/i915/intel_uncore.c
>>index 8b9caaaacc21..df59ec88459e 100644
>>--- a/drivers/gpu/drm/i915/intel_uncore.c
>>+++ b/drivers/gpu/drm/i915/intel_uncore.c
>>@@ -1502,11 +1502,10 @@ ilk_dummy_write(struct intel_uncore *uncore)
>>  static void
>>  __unclaimed_reg_debug(struct intel_uncore *uncore,
>>  		      const i915_reg_t reg,
>>-		      const bool read,
>>-		      const bool before)
>>+		      const bool read)
>>  {
>>  	if (drm_WARN(&uncore->i915->drm,
>>-		     check_for_unclaimed_mmio(uncore) && !before,
>>+		     check_for_unclaimed_mmio(uncore),
>>  		     "Unclaimed %s register 0x%x\n",
>>  		     read ? "read from" : "write to",
>>  		     i915_mmio_reg_offset(reg)))
>>@@ -1514,6 +1513,20 @@ __unclaimed_reg_debug(struct intel_uncore *uncore,
>>  		uncore->i915->params.mmio_debug--;
>>  }
>>+static void
>>+__unclaimed_previous_reg_debug(struct intel_uncore *uncore,
>>+			       const i915_reg_t reg,
>>+			       const bool read)
>>+{
>>+	if (drm_WARN(&uncore->i915->drm,
>>+		     check_for_unclaimed_mmio(uncore),
>>+		     "Unclaimed access detected before %s register 0x%x\n",
>>+		     read ? "read from" : "write to",
>>+		     i915_mmio_reg_offset(reg)))
>>+		/* Only report the first N failures */
>>+		uncore->i915->params.mmio_debug--;
>>+}
>>+
>>  static inline void
>>  unclaimed_reg_debug(struct intel_uncore *uncore,
>>  		    const i915_reg_t reg,
>>@@ -1526,13 +1539,13 @@ unclaimed_reg_debug(struct intel_uncore *uncore,
>>  	/* interrupts are disabled and re-enabled around uncore->lock usage */
>>  	lockdep_assert_held(&uncore->lock);
>>-	if (before)
>>+	if (before) {
>>  		spin_lock(&uncore->debug->lock);
>>-
>>-	__unclaimed_reg_debug(uncore, reg, read, before);
>>-
>>-	if (!before)
>>+		__unclaimed_previous_reg_debug(uncore, reg, read);
>>+	} else {
>>+		__unclaimed_reg_debug(uncore, reg, read);
>>  		spin_unlock(&uncore->debug->lock);
>>+	}
>>  }
>>  #define __vgpu_read(x) \
diff mbox series

Patch

diff --git a/drivers/gpu/drm/i915/intel_uncore.c b/drivers/gpu/drm/i915/intel_uncore.c
index 8b9caaaacc21..df59ec88459e 100644
--- a/drivers/gpu/drm/i915/intel_uncore.c
+++ b/drivers/gpu/drm/i915/intel_uncore.c
@@ -1502,11 +1502,10 @@  ilk_dummy_write(struct intel_uncore *uncore)
 static void
 __unclaimed_reg_debug(struct intel_uncore *uncore,
 		      const i915_reg_t reg,
-		      const bool read,
-		      const bool before)
+		      const bool read)
 {
 	if (drm_WARN(&uncore->i915->drm,
-		     check_for_unclaimed_mmio(uncore) && !before,
+		     check_for_unclaimed_mmio(uncore),
 		     "Unclaimed %s register 0x%x\n",
 		     read ? "read from" : "write to",
 		     i915_mmio_reg_offset(reg)))
@@ -1514,6 +1513,20 @@  __unclaimed_reg_debug(struct intel_uncore *uncore,
 		uncore->i915->params.mmio_debug--;
 }
 
+static void
+__unclaimed_previous_reg_debug(struct intel_uncore *uncore,
+			       const i915_reg_t reg,
+			       const bool read)
+{
+	if (drm_WARN(&uncore->i915->drm,
+		     check_for_unclaimed_mmio(uncore),
+		     "Unclaimed access detected before %s register 0x%x\n",
+		     read ? "read from" : "write to",
+		     i915_mmio_reg_offset(reg)))
+		/* Only report the first N failures */
+		uncore->i915->params.mmio_debug--;
+}
+
 static inline void
 unclaimed_reg_debug(struct intel_uncore *uncore,
 		    const i915_reg_t reg,
@@ -1526,13 +1539,13 @@  unclaimed_reg_debug(struct intel_uncore *uncore,
 	/* interrupts are disabled and re-enabled around uncore->lock usage */
 	lockdep_assert_held(&uncore->lock);
 
-	if (before)
+	if (before) {
 		spin_lock(&uncore->debug->lock);
-
-	__unclaimed_reg_debug(uncore, reg, read, before);
-
-	if (!before)
+		__unclaimed_previous_reg_debug(uncore, reg, read);
+	} else {
+		__unclaimed_reg_debug(uncore, reg, read);
 		spin_unlock(&uncore->debug->lock);
+	}
 }
 
 #define __vgpu_read(x) \