| Message ID | cce0f07d-25fc-5880-69e7-001d951750b7@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Jason Gunthorpe |
| Headers | show |
| Series | [for-next] RDMA/rxe: Remove reliable datagram support | expand |
On 2022/4/8 5:04, Bob Pearson wrote: > > > > -------- Forwarded Message -------- > Subject: [PATCH for-next] RDMA/rxe: Remove reliable datagram support > Date: Thu, 7 Apr 2022 14:05:23 -0500 > From: Bob Pearson <rpearsonhpe@gmail.com> > To: jgg@nvidia.com, zyjzyj2000@gmail.com, linux-rdma@vger.kerne.org > CC: Bob Pearson <rpearsonhpe@gmail.com> > > The rdma_rxe driver does not actually support the reliable datagram transport > but contains two references to RD opcodes in driver code. > This commit removes these references to RD transport opcodes which > are never used. Hi Bob, Agreed. It looks good to me. ^_^ Best Regards, Xiao Yang > > Signed-off-by: Bob Pearson <rpearsonhpe@gmail.com> > --- > drivers/infiniband/sw/rxe/rxe_req.c | 3 +-- > drivers/infiniband/sw/rxe/rxe_resp.c | 3 +-- > 2 files changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/infiniband/sw/rxe/rxe_req.c b/drivers/infiniband/sw/rxe/rxe_req.c > index 52c1d8ff6e5b..5f7348b11268 100644 > --- a/drivers/infiniband/sw/rxe/rxe_req.c > +++ b/drivers/infiniband/sw/rxe/rxe_req.c > @@ -413,8 +413,7 @@ static struct sk_buff *init_req_packet(struct rxe_qp *qp, > > if (pkt->mask & RXE_ATMETH_MASK) { > atmeth_set_va(pkt, wqe->iova); > - if (opcode == IB_OPCODE_RC_COMPARE_SWAP || > - opcode == IB_OPCODE_RD_COMPARE_SWAP) { > + if (opcode == IB_OPCODE_RC_COMPARE_SWAP) { > atmeth_set_swap_add(pkt, ibwr->wr.atomic.swap); > atmeth_set_comp(pkt, ibwr->wr.atomic.compare_add); > } else { > diff --git a/drivers/infiniband/sw/rxe/rxe_resp.c b/drivers/infiniband/sw/rxe/rxe_resp.c > index 9dc38f7c990b..e2653a8721fe 100644 > --- a/drivers/infiniband/sw/rxe/rxe_resp.c > +++ b/drivers/infiniband/sw/rxe/rxe_resp.c > @@ -576,8 +576,7 @@ static enum resp_states process_atomic(struct rxe_qp *qp, > > qp->resp.atomic_orig = *vaddr; > > - if (pkt->opcode == IB_OPCODE_RC_COMPARE_SWAP || > - pkt->opcode == IB_OPCODE_RD_COMPARE_SWAP) { > + if (pkt->opcode == IB_OPCODE_RC_COMPARE_SWAP) { > if (*vaddr == atmeth_comp(pkt)) > *vaddr = atmeth_swap_add(pkt); > } else {
On Thu, Apr 07, 2022 at 04:04:45PM -0500, Bob Pearson wrote: > The rdma_rxe driver does not actually support the reliable datagram transport > but contains two references to RD opcodes in driver code. > This commit removes these references to RD transport opcodes which > are never used. > > Signed-off-by: Bob Pearson <rpearsonhpe@gmail.com> > --- > drivers/infiniband/sw/rxe/rxe_req.c | 3 +-- > drivers/infiniband/sw/rxe/rxe_resp.c | 3 +-- > 2 files changed, 2 insertions(+), 4 deletions(-) Applied to for-next, thanks Jason
diff --git a/drivers/infiniband/sw/rxe/rxe_req.c b/drivers/infiniband/sw/rxe/rxe_req.c index 52c1d8ff6e5b..5f7348b11268 100644 --- a/drivers/infiniband/sw/rxe/rxe_req.c +++ b/drivers/infiniband/sw/rxe/rxe_req.c @@ -413,8 +413,7 @@ static struct sk_buff *init_req_packet(struct rxe_qp *qp, if (pkt->mask & RXE_ATMETH_MASK) { atmeth_set_va(pkt, wqe->iova); - if (opcode == IB_OPCODE_RC_COMPARE_SWAP || - opcode == IB_OPCODE_RD_COMPARE_SWAP) { + if (opcode == IB_OPCODE_RC_COMPARE_SWAP) { atmeth_set_swap_add(pkt, ibwr->wr.atomic.swap); atmeth_set_comp(pkt, ibwr->wr.atomic.compare_add); } else { diff --git a/drivers/infiniband/sw/rxe/rxe_resp.c b/drivers/infiniband/sw/rxe/rxe_resp.c index 9dc38f7c990b..e2653a8721fe 100644 --- a/drivers/infiniband/sw/rxe/rxe_resp.c +++ b/drivers/infiniband/sw/rxe/rxe_resp.c @@ -576,8 +576,7 @@ static enum resp_states process_atomic(struct rxe_qp *qp, qp->resp.atomic_orig = *vaddr; - if (pkt->opcode == IB_OPCODE_RC_COMPARE_SWAP || - pkt->opcode == IB_OPCODE_RD_COMPARE_SWAP) { + if (pkt->opcode == IB_OPCODE_RC_COMPARE_SWAP) { if (*vaddr == atmeth_comp(pkt)) *vaddr = atmeth_swap_add(pkt); } else {