| Message ID | 20220406152347.85908-3-Frank.Li@nxp.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Lorenzo Pieralisi |
| Headers | show |
| Series | Enable designware PCI EP EDMA locally | expand |
On Wed, Apr 06, 2022 at 10:23:40AM -0500, Frank Li wrote: > irq of struct dw_edma_chip was never used. > It can be removed safely. As I said in my comment to the patch "dmaengine: dw-edma: Detach the private data and chip info structures" of this series, please move this patch to being applied before that one and completely drop the irq field in the framework of this modification. Otherwise the change in both of these patches seem intermixed and don't represent a single modification. -Sergey > > Signed-off-by: Frank Li <Frank.Li@nxp.com> > --- > Change from v5 to v6 > - s/remove/Remove/ at subject > Change from v4 to v5 > - none > new patch at v4 > > drivers/dma/dw-edma/dw-edma-pcie.c | 1 - > include/linux/dma/edma.h | 2 -- > 2 files changed, 3 deletions(-) > > diff --git a/drivers/dma/dw-edma/dw-edma-pcie.c b/drivers/dma/dw-edma/dw-edma-pcie.c > index 21c8c59e09c23..2c1c5fa4e9f28 100644 > --- a/drivers/dma/dw-edma/dw-edma-pcie.c > +++ b/drivers/dma/dw-edma/dw-edma-pcie.c > @@ -225,7 +225,6 @@ static int dw_edma_pcie_probe(struct pci_dev *pdev, > /* Data structure initialization */ > chip->dev = dev; > chip->id = pdev->devfn; > - chip->irq = pdev->irq; > > chip->mf = vsec_data.mf; > chip->nr_irqs = nr_irqs; > diff --git a/include/linux/dma/edma.h b/include/linux/dma/edma.h > index a9bee4aeb2eee..6fd374cc72c8e 100644 > --- a/include/linux/dma/edma.h > +++ b/include/linux/dma/edma.h > @@ -37,7 +37,6 @@ enum dw_edma_map_format { > * struct dw_edma_chip - representation of DesignWare eDMA controller hardware > * @dev: struct device of the eDMA controller > * @id: instance ID > - * @irq: irq line > * @nr_irqs: total dma irq number > * @ops DMA channel to IRQ number mapping > * @wr_ch_cnt DMA write channel number > @@ -51,7 +50,6 @@ enum dw_edma_map_format { > struct dw_edma_chip { > struct device *dev; > int id; > - int irq; > int nr_irqs; > const struct dw_edma_core_ops *ops; > > -- > 2.35.1 >
diff --git a/drivers/dma/dw-edma/dw-edma-pcie.c b/drivers/dma/dw-edma/dw-edma-pcie.c index 21c8c59e09c23..2c1c5fa4e9f28 100644 --- a/drivers/dma/dw-edma/dw-edma-pcie.c +++ b/drivers/dma/dw-edma/dw-edma-pcie.c @@ -225,7 +225,6 @@ static int dw_edma_pcie_probe(struct pci_dev *pdev, /* Data structure initialization */ chip->dev = dev; chip->id = pdev->devfn; - chip->irq = pdev->irq; chip->mf = vsec_data.mf; chip->nr_irqs = nr_irqs; diff --git a/include/linux/dma/edma.h b/include/linux/dma/edma.h index a9bee4aeb2eee..6fd374cc72c8e 100644 --- a/include/linux/dma/edma.h +++ b/include/linux/dma/edma.h @@ -37,7 +37,6 @@ enum dw_edma_map_format { * struct dw_edma_chip - representation of DesignWare eDMA controller hardware * @dev: struct device of the eDMA controller * @id: instance ID - * @irq: irq line * @nr_irqs: total dma irq number * @ops DMA channel to IRQ number mapping * @wr_ch_cnt DMA write channel number @@ -51,7 +50,6 @@ enum dw_edma_map_format { struct dw_edma_chip { struct device *dev; int id; - int irq; int nr_irqs; const struct dw_edma_core_ops *ops;
irq of struct dw_edma_chip was never used. It can be removed safely. Signed-off-by: Frank Li <Frank.Li@nxp.com> --- Change from v5 to v6 - s/remove/Remove/ at subject Change from v4 to v5 - none new patch at v4 drivers/dma/dw-edma/dw-edma-pcie.c | 1 - include/linux/dma/edma.h | 2 -- 2 files changed, 3 deletions(-)