mbox series

[0/5] Firmware loader support for ZSTD-compressed files

Message ID 20220421152908.4718-1-tiwai@suse.de (mailing list archive)
Headers show
Series Firmware loader support for ZSTD-compressed files | expand

Message

Takashi Iwai April 21, 2022, 3:29 p.m. UTC
Hi,

this is a revised patch set for RFC I posted some time ago (*).
Since the ZSTD usage became much more popular now, it makes sense to
have the consistent (de)compression support in the kernel, also for
the firmware files.  This patch set adds the support for ZSTD-
compressed firmware files as well as the extension of selftests, in
addition to a couple of relevant fixes in selftests.

(*) https://lore.kernel.org/r/20210127154939.13288-1-tiwai@suse.de


Takashi

===

Takashi Iwai (5):
  firmware: Add the support for ZSTD-compressed firmware files
  selftests: firmware: Use smaller dictionary for XZ compression
  selftests: firmware: Fix the request_firmware_into_buf() test for XZ
    format
  selftests: firmware: Simplify test patterns
  selftests: firmware: Add ZSTD compressed file tests

 drivers/base/firmware_loader/Kconfig          |  24 ++-
 drivers/base/firmware_loader/main.c           |  76 +++++++-
 .../selftests/firmware/fw_filesystem.sh       | 170 +++++++++---------
 tools/testing/selftests/firmware/fw_lib.sh    |  12 +-
 4 files changed, 182 insertions(+), 100 deletions(-)

Comments

Luis Chamberlain April 21, 2022, 4:48 p.m. UTC | #1
On Thu, Apr 21, 2022 at 05:29:03PM +0200, Takashi Iwai wrote:
> Hi,
> 
> this is a revised patch set for RFC I posted some time ago (*).
> Since the ZSTD usage became much more popular now, it makes sense to
> have the consistent (de)compression support in the kernel, also for
> the firmware files.  This patch set adds the support for ZSTD-
> compressed firmware files as well as the extension of selftests, in
> addition to a couple of relevant fixes in selftests.
> 
> (*) https://lore.kernel.org/r/20210127154939.13288-1-tiwai@suse.de

Russ had posted a set of patches which this likely needs to be
rebased on top of. Russ however has to address one kernel splat
found by 0day, so I'd expect a new set and then perhaps this can
be based on that?

[0] https://lkml.kernel.org/r/20220419231658.664388-1-russell.h.weight@intel.com    

  Luis
Takashi Iwai April 22, 2022, 6:38 a.m. UTC | #2
On Thu, 21 Apr 2022 18:48:05 +0200,
Luis Chamberlain wrote:
> 
> On Thu, Apr 21, 2022 at 05:29:03PM +0200, Takashi Iwai wrote:
> > Hi,
> > 
> > this is a revised patch set for RFC I posted some time ago (*).
> > Since the ZSTD usage became much more popular now, it makes sense to
> > have the consistent (de)compression support in the kernel, also for
> > the firmware files.  This patch set adds the support for ZSTD-
> > compressed firmware files as well as the extension of selftests, in
> > addition to a couple of relevant fixes in selftests.
> > 
> > (*) https://lore.kernel.org/r/20210127154939.13288-1-tiwai@suse.de
> 
> Russ had posted a set of patches which this likely needs to be
> rebased on top of. Russ however has to address one kernel splat
> found by 0day, so I'd expect a new set and then perhaps this can
> be based on that?

Sure, it should be fine, as the code change there is quite minimal.
Let me know if the base branch becomes ready.


thanks,

Takashi

> 
> [0] https://lkml.kernel.org/r/20220419231658.664388-1-russell.h.weight@intel.com    
> 
>   Luis
>
Greg Kroah-Hartman April 22, 2022, 6:50 a.m. UTC | #3
On Fri, Apr 22, 2022 at 08:38:07AM +0200, Takashi Iwai wrote:
> On Thu, 21 Apr 2022 18:48:05 +0200,
> Luis Chamberlain wrote:
> > 
> > On Thu, Apr 21, 2022 at 05:29:03PM +0200, Takashi Iwai wrote:
> > > Hi,
> > > 
> > > this is a revised patch set for RFC I posted some time ago (*).
> > > Since the ZSTD usage became much more popular now, it makes sense to
> > > have the consistent (de)compression support in the kernel, also for
> > > the firmware files.  This patch set adds the support for ZSTD-
> > > compressed firmware files as well as the extension of selftests, in
> > > addition to a couple of relevant fixes in selftests.
> > > 
> > > (*) https://lore.kernel.org/r/20210127154939.13288-1-tiwai@suse.de
> > 
> > Russ had posted a set of patches which this likely needs to be
> > rebased on top of. Russ however has to address one kernel splat
> > found by 0day, so I'd expect a new set and then perhaps this can
> > be based on that?
> 
> Sure, it should be fine, as the code change there is quite minimal.
> Let me know if the base branch becomes ready.

Your patches came in before Russ's, so I'll queue them up now first.

thanks,

greg k-h