| Message ID | 20220423200155.1735336-1-trix@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/radeon: change cac_weights_* to static | expand |
Applied. Thanks! Alex On Sat, Apr 23, 2022 at 4:02 PM Tom Rix <trix@redhat.com> wrote: > > Sparse reports these issues > si_dpm.c:332:26: warning: symbol 'cac_weights_pitcairn' was not declared. Should it be static? > si_dpm.c:1088:26: warning: symbol 'cac_weights_oland' was not declared. Should it be static? > > Both of these variables are only used in si_dpm.c. Single file variables > should be static, so change their storage-class specifiers to static. > > Signed-off-by: Tom Rix <trix@redhat.com> > --- > drivers/gpu/drm/radeon/si_dpm.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/radeon/si_dpm.c b/drivers/gpu/drm/radeon/si_dpm.c > index 3add39c1a689..fbf968e3f6d7 100644 > --- a/drivers/gpu/drm/radeon/si_dpm.c > +++ b/drivers/gpu/drm/radeon/si_dpm.c > @@ -329,7 +329,7 @@ static const struct si_dte_data dte_data_malta = > true > }; > > -struct si_cac_config_reg cac_weights_pitcairn[] = > +static struct si_cac_config_reg cac_weights_pitcairn[] = > { > { 0x0, 0x0000ffff, 0, 0x8a, SISLANDS_CACCONFIG_CGIND }, > { 0x0, 0xffff0000, 16, 0x0, SISLANDS_CACCONFIG_CGIND }, > @@ -1085,7 +1085,7 @@ static const struct si_dte_data dte_data_venus_pro = > true > }; > > -struct si_cac_config_reg cac_weights_oland[] = > +static struct si_cac_config_reg cac_weights_oland[] = > { > { 0x0, 0x0000ffff, 0, 0x82, SISLANDS_CACCONFIG_CGIND }, > { 0x0, 0xffff0000, 16, 0x4F, SISLANDS_CACCONFIG_CGIND }, > -- > 2.27.0 >
diff --git a/drivers/gpu/drm/radeon/si_dpm.c b/drivers/gpu/drm/radeon/si_dpm.c index 3add39c1a689..fbf968e3f6d7 100644 --- a/drivers/gpu/drm/radeon/si_dpm.c +++ b/drivers/gpu/drm/radeon/si_dpm.c @@ -329,7 +329,7 @@ static const struct si_dte_data dte_data_malta = true }; -struct si_cac_config_reg cac_weights_pitcairn[] = +static struct si_cac_config_reg cac_weights_pitcairn[] = { { 0x0, 0x0000ffff, 0, 0x8a, SISLANDS_CACCONFIG_CGIND }, { 0x0, 0xffff0000, 16, 0x0, SISLANDS_CACCONFIG_CGIND }, @@ -1085,7 +1085,7 @@ static const struct si_dte_data dte_data_venus_pro = true }; -struct si_cac_config_reg cac_weights_oland[] = +static struct si_cac_config_reg cac_weights_oland[] = { { 0x0, 0x0000ffff, 0, 0x82, SISLANDS_CACCONFIG_CGIND }, { 0x0, 0xffff0000, 16, 0x4F, SISLANDS_CACCONFIG_CGIND },
Sparse reports these issues si_dpm.c:332:26: warning: symbol 'cac_weights_pitcairn' was not declared. Should it be static? si_dpm.c:1088:26: warning: symbol 'cac_weights_oland' was not declared. Should it be static? Both of these variables are only used in si_dpm.c. Single file variables should be static, so change their storage-class specifiers to static. Signed-off-by: Tom Rix <trix@redhat.com> --- drivers/gpu/drm/radeon/si_dpm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)