[rdma-next,00/12] Refactor UMR post send logic

Message

Leon Romanovsky April 12, 2022, 7:23 a.m. UTC

From: Leon Romanovsky <[e-mail]>

Hi,

UMR are special QPs that require slightly different logic than other
QPs. This series from Aharon refactors the logic around UMR QP to
separate file and functions to clean the post send flow.

Thanks

Aharon Landau (12):
  RDMA/mlx5: Move init and cleanup of UMR to umr.c
  RDMA/mlx5: Move umr checks to umr.h
  RDMA/mlx5: Move mkey ctrl segment logic to umr.c
  RDMA/mlx5: Simplify get_umr_update_access_mask()
  RDMA/mlx5: Expose wqe posting helpers outside of wr.c
  RDMA/mlx5: Introduce mlx5_umr_post_send_wait()
  RDMA/mlx5: Use mlx5_umr_post_send_wait() to revoke MRs
  RDMA/mlx5: Use mlx5_umr_post_send_wait() to rereg pd access
  RDMA/mlx5: Move creation and free of translation tables to umr.c
  RDMA/mlx5: Use mlx5_umr_post_send_wait() to update MR pas
  RDMA/mlx5: Use mlx5_umr_post_send_wait() to update xlt
  RDMA/mlx5: Clean UMR QP type flow from mlx5_ib_post_send()

 drivers/infiniband/hw/mlx5/Makefile  |   1 +
 drivers/infiniband/hw/mlx5/main.c    | 109 +----
 drivers/infiniband/hw/mlx5/mlx5_ib.h |  89 +---
 drivers/infiniband/hw/mlx5/mr.c      | 421 +---------------
 drivers/infiniband/hw/mlx5/odp.c     |  63 ++-
 drivers/infiniband/hw/mlx5/qp.c      |   1 +
 drivers/infiniband/hw/mlx5/umr.c     | 700 +++++++++++++++++++++++++++
 drivers/infiniband/hw/mlx5/umr.h     |  97 ++++
 drivers/infiniband/hw/mlx5/wr.c      | 377 +++------------
 drivers/infiniband/hw/mlx5/wr.h      |  60 +++
 10 files changed, 976 insertions(+), 942 deletions(-)
 create mode 100644 drivers/infiniband/hw/mlx5/umr.c
 create mode 100644 drivers/infiniband/hw/mlx5/umr.h

Comments

Jason Gunthorpe April 25, 2022, 6:48 p.m. UTC | #1

On Tue, Apr 12, 2022 at 10:23:55AM +0300, Leon Romanovsky wrote:
> From: Leon Romanovsky <[e-mail]>
> 
> Hi,
> 
> UMR are special QPs that require slightly different logic than other
> QPs. This series from Aharon refactors the logic around UMR QP to
> separate file and functions to clean the post send flow.
> 
> Thanks
> 
> Aharon Landau (12):
>   RDMA/mlx5: Move init and cleanup of UMR to umr.c
>   RDMA/mlx5: Move umr checks to umr.h
>   RDMA/mlx5: Move mkey ctrl segment logic to umr.c
>   RDMA/mlx5: Simplify get_umr_update_access_mask()
>   RDMA/mlx5: Expose wqe posting helpers outside of wr.c
>   RDMA/mlx5: Introduce mlx5_umr_post_send_wait()
>   RDMA/mlx5: Use mlx5_umr_post_send_wait() to revoke MRs
>   RDMA/mlx5: Use mlx5_umr_post_send_wait() to rereg pd access
>   RDMA/mlx5: Move creation and free of translation tables to umr.c
>   RDMA/mlx5: Use mlx5_umr_post_send_wait() to update MR pas
>   RDMA/mlx5: Use mlx5_umr_post_send_wait() to update xlt
>   RDMA/mlx5: Clean UMR QP type flow from mlx5_ib_post_send()

I moved the static to the earlier patch, but otherwise applied to
for-next, thanks

Jason