| Message ID | 20220427063504.384540-1-juergh@protonmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Bluetooth: ath3k: Add MODULE_FIRMWARE for patch and config files | expand |
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=636030
---Test result---
Test Summary:
CheckPatch FAIL 1.76 seconds
GitLint PASS 1.05 seconds
SubjectPrefix PASS 0.96 seconds
BuildKernel PASS 41.93 seconds
BuildKernel32 PASS 35.32 seconds
Incremental Build with patchesPASS 48.09 seconds
TestRunner: Setup PASS 620.05 seconds
TestRunner: l2cap-tester PASS 19.76 seconds
TestRunner: bnep-tester PASS 7.58 seconds
TestRunner: mgmt-tester PASS 120.59 seconds
TestRunner: rfcomm-tester PASS 11.37 seconds
TestRunner: sco-tester PASS 11.02 seconds
TestRunner: smp-tester PASS 11.43 seconds
TestRunner: userchan-tester PASS 8.40 seconds
Details
##############################
Test: CheckPatch - FAIL - 1.76 seconds
Run checkpatch.pl script with rule in .checkpatch.conf
Bluetooth: ath3k: Add MODULE_FIRMWARE for patch and config files\WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email address mismatch: 'From: Juerg Haefliger <juerg.haefliger@canonical.com>' != 'Signed-off-by: Juerg Haefliger <juergh@protonmail.com>'
total: 0 errors, 1 warnings, 5 lines checked
NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.
/github/workspace/src/12828329.patch has style problems, please review.
NOTE: Ignored message types: UNKNOWN_COMMIT_ID
NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
---
Regards,
Linux Bluetooth
Hi Juerg, > The ath3k driver loads patch and configuration files so add MODULE_FIRMWARE > macros to povide that information via modinfo. > > Signed-off-by: Juerg Haefliger <juergh@protonmail.com> > --- > drivers/bluetooth/ath3k.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/bluetooth/ath3k.c b/drivers/bluetooth/ath3k.c > index 88262d3a9392..56e9a64177ae 100644 > --- a/drivers/bluetooth/ath3k.c > +++ b/drivers/bluetooth/ath3k.c > @@ -538,3 +538,5 @@ MODULE_DESCRIPTION("Atheros AR30xx firmware driver"); > MODULE_VERSION(VERSION); > MODULE_LICENSE("GPL"); > MODULE_FIRMWARE(ATH3K_FIRMWARE); > +MODULE_FIRMWARE("ar3k/AthrBT_0x*.dfu"); > +MODULE_FIRMWARE("ar3k/ramps_0x*_*.dfu"); since when do we allow GLOB pattern matching here? Regards Marcel
------- Original Message ------- On Wednesday, April 27th, 2022 at 14:49, Marcel Holtmann <marcel@holtmann.org> wrote: > > > Hi Juerg, > > > The ath3k driver loads patch and configuration files so add MODULE_FIRMWARE > > macros to povide that information via modinfo. > > > > Signed-off-by: Juerg Haefliger juergh@protonmail.com > > --- > > drivers/bluetooth/ath3k.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/drivers/bluetooth/ath3k.c b/drivers/bluetooth/ath3k.c > > index 88262d3a9392..56e9a64177ae 100644 > > --- a/drivers/bluetooth/ath3k.c > > +++ b/drivers/bluetooth/ath3k.c > > @@ -538,3 +538,5 @@ MODULE_DESCRIPTION("Atheros AR30xx firmware driver"); > > MODULE_VERSION(VERSION); > > MODULE_LICENSE("GPL"); > > MODULE_FIRMWARE(ATH3K_FIRMWARE); > > +MODULE_FIRMWARE("ar3k/AthrBT_0x*.dfu"); > > +MODULE_FIRMWARE("ar3k/ramps_0x*_*.dfu"); > > > since when do we allow GLOB pattern matching here? Not sure when that was first introduced but: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=75729e110e680687668fd5b4bdd7b25c92e9c00d ...Juerg > Regards > > Marcel
diff --git a/drivers/bluetooth/ath3k.c b/drivers/bluetooth/ath3k.c index 88262d3a9392..56e9a64177ae 100644 --- a/drivers/bluetooth/ath3k.c +++ b/drivers/bluetooth/ath3k.c @@ -538,3 +538,5 @@ MODULE_DESCRIPTION("Atheros AR30xx firmware driver"); MODULE_VERSION(VERSION); MODULE_LICENSE("GPL"); MODULE_FIRMWARE(ATH3K_FIRMWARE); +MODULE_FIRMWARE("ar3k/AthrBT_0x*.dfu"); +MODULE_FIRMWARE("ar3k/ramps_0x*_*.dfu");
The ath3k driver loads patch and configuration files so add MODULE_FIRMWARE macros to povide that information via modinfo. Signed-off-by: Juerg Haefliger <juergh@protonmail.com> --- drivers/bluetooth/ath3k.c | 2 ++ 1 file changed, 2 insertions(+)