| Message ID | 20220421071747.1892-1-chengyou@linux.alibaba.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Elastic RDMA Adapter (ERDMA) driver | expand |
On Thu, Apr 21, 2022 at 03:17:35PM +0800, Cheng Xu wrote: > Hello all, > > This v7 patch set introduces the Elastic RDMA Adapter (ERDMA) driver, > which released in Apsara Conference 2021 by Alibaba. The PR of ERDMA > userspace provider has already been created [1]. It doesn't compile: ../drivers/infiniband/hw/erdma/erdma_verbs.c:291:8: error: no member named 'kernel_cap_flags' in 'struct ib_device_attr' attr->kernel_cap_flags = IBK_LOCAL_DMA_LKEY; ~~~~ ^ ../drivers/infiniband/hw/erdma/erdma_verbs.c:291:27: error: use of undeclared identifier 'IBK_LOCAL_DMA_LKEY' attr->kernel_cap_flags = IBK_LOCAL_DMA_LKEY; ^ Jason
On 5/10/22 8:50 PM, Jason Gunthorpe wrote: > On Thu, Apr 21, 2022 at 03:17:35PM +0800, Cheng Xu wrote: >> Hello all, >> >> This v7 patch set introduces the Elastic RDMA Adapter (ERDMA) driver, >> which released in Apsara Conference 2021 by Alibaba. The PR of ERDMA >> userspace provider has already been created [1]. > > It doesn't compile: > > ../drivers/infiniband/hw/erdma/erdma_verbs.c:291:8: error: no member named 'kernel_cap_flags' in 'struct ib_device_attr' > attr->kernel_cap_flags = IBK_LOCAL_DMA_LKEY; > ~~~~ ^ > ../drivers/infiniband/hw/erdma/erdma_verbs.c:291:27: error: use of undeclared identifier 'IBK_LOCAL_DMA_LKEY' > attr->kernel_cap_flags = IBK_LOCAL_DMA_LKEY; > ^ > > Jason This v7 patch set is based on the latest for-next branch. This change is introduced by (e945c653c, RDMA: Split kernel-only global device caps from uverbs device caps). Maybe you compile the patch set with for-rc? If so, should the code be base on the for-rc code? (BTW, sorry for late reply. My mail APP classified your responses to wrong folder, and I'm aware of this after visiting the website lore.kernel.org) Thanks, Cheng Xu
On Mon, May 16, 2022 at 10:30:08AM +0800, Cheng Xu wrote: > > > On 5/10/22 8:50 PM, Jason Gunthorpe wrote: > > On Thu, Apr 21, 2022 at 03:17:35PM +0800, Cheng Xu wrote: > > > Hello all, > > > > > > This v7 patch set introduces the Elastic RDMA Adapter (ERDMA) driver, > > > which released in Apsara Conference 2021 by Alibaba. The PR of ERDMA > > > userspace provider has already been created [1]. > > > > It doesn't compile: > > > > ../drivers/infiniband/hw/erdma/erdma_verbs.c:291:8: error: no member named 'kernel_cap_flags' in 'struct ib_device_attr' > > attr->kernel_cap_flags = IBK_LOCAL_DMA_LKEY; > > ~~~~ ^ > > ../drivers/infiniband/hw/erdma/erdma_verbs.c:291:27: error: use of undeclared identifier 'IBK_LOCAL_DMA_LKEY' > > attr->kernel_cap_flags = IBK_LOCAL_DMA_LKEY; > > ^ > > > > Jason > > This v7 patch set is based on the latest for-next branch. This > change is introduced by (e945c653c, RDMA: Split kernel-only global device > caps from uverbs device caps). Maybe you compile the patch set > with for-rc? Oh, Ok Jason
Hello all, This v7 patch set introduces the Elastic RDMA Adapter (ERDMA) driver, which released in Apsara Conference 2021 by Alibaba. The PR of ERDMA userspace provider has already been created [1]. ERDMA enables large-scale RDMA acceleration capability in Alibaba ECS environment, initially offered in g7re instance. It can improve the efficiency of large-scale distributed computing and communication significantly and expand dynamically with the cluster scale of Alibaba Cloud. ERDMA is a RDMA networking adapter based on the Alibaba MOC hardware. It works in the VPC network environment (overlay network), and uses iWarp transport protocol. ERDMA supports reliable connection (RC). ERDMA also supports both kernel space and user space verbs. Now we have already supported HPC/AI applications with libfabric, NoF and some other internal verbs libraries, such as xrdma, epsl, etc,. For the ECS instance with RDMA enabled, our MOC hardware generates two kinds of PCI devices: one for ERDMA, and one for the original net device (virtio-net). They are separated PCI devices, using "rdma link" command with a filter inside our rdma_link_ops.newlink implementation can bind them together properly. Besides, this patchset contains a change in iw_query_port to fix this issue [2]. This change lets the device drivers decide the return value of iw_query_port when attached netdev is NULL. After this change, erdma can register device successfully in pci probe function, and keep port state invalid until a netdev is binded to it. Changes in v7: - Fix a wrong doorbell records' address calculation issue in erdma_create_qp. - Fix a condition race issue when reporting IW_CM_EVENT_CONNECT_REQUEST event in cm. - Sorry for a mmap_free implementation missing, we add it in this version. - Remove unnecessary reference to erdma_dev in erdma_ucontext. Changes in v6: - Rebase to the latest for-next code, and solve the compilation issues. Fixed issues or changes in v5: - Rename the reserved fields of structure definitions to improve readability. - Remove some magic numbers and unnecessary initializations. - Fix some coding style format issues. - Fix some typos in comments. - No casting in the assignment if the function's returned pointer is "void *". - Re-write the polling functions (cmdq cq, verbs cq, aeq and ceq), which all check the valid bit in order to get next valid QE. This new implementation is more simple. Thank Wenpeng. - Fix an issue reported by kernel test robot. - Some minor changes in code (such as removing SRQ definitions since we do not support it yet). Fixed issues in v4: - Fix some typos. - Use __GFP_ZERO flags in dma_alloc_coherent, instead of memset after buffer allocation. - Use one single polling function for AEQ and CEQ, before there had two. - Fix wrong iov_num when calling kernel_sendmsg. - Add necessary comment in erdma_cm. - Remove duplicated check in MPA processing function. - Always return 0 in erdma_query_port. - Directly return error code instead of assigning "ret", and then returning "ret" in init_kernel_qp. Fixed issues or changes in v3: - Change char limit of column from 100 to 80. - Remove unnecessary field or structure definitions in erdma.h. - Use exactly type (bool, unsigned int) instead of "int" in erdma_dev. - Make ibdev and pci device having the same lifecycle. ERDMA will remain an invalid port state until binded to the corresponding netdev. - ib_core: allow query_port when netdev is NULL for iWarp device. - Move large inline function in erdma.h to .c files. - Use dev_{info, warn, err} or ibdev_{info, warn, err} instead of pr_{info, warn, err} function calls. - Remove print function calls in userspace-triggered paths. - Add necessary comments in CM part. - Remove unused entries in map_cqe_opcode[] table. - Use rdma_is_kernel_res instead of self-definitions. - Remove unsed resources counter in erdma_dev. - Use pgprot_device instead of pgprot_noncached in erdma_mmap. - Remove disassociate_ucontext interface implementation Fixed issues in v2: - No "extern" to function declarations. - No inline functions in .c files, no void casting for functions with return values. - Based on siw's newest kernel version, rewrite the code (mainly CM and CM related part) which originally based on an old siw version. - remove debugfs. - fix issues reported by kernel test robot. - Using RDMA_NLDEV_CMD_NEWLINK instead of binding in net notifiers. [1] https://github.com/linux-rdma/rdma-core/pull/1126 [2] https://lore.kernel.org/all/20220118141324.GF8034@ziepe.ca/ Thanks, Cheng Xu Cheng Xu (12): RDMA: Add ERDMA to rdma_driver_id definition RDMA/core: Allow calling query_port when netdev isn't attached in iWarp RDMA/erdma: Add the hardware related definitions RDMA/erdma: Add main include file RDMA/erdma: Add cmdq implementation RDMA/erdma: Add event queue implementation RDMA/erdma: Add verbs header file RDMA/erdma: Add verbs implementation RDMA/erdma: Add connection management (CM) support RDMA/erdma: Add the erdma module RDMA/erdma: Add the ABI definitions RDMA/erdma: Add driver to kernel build environment MAINTAINERS | 8 + drivers/infiniband/Kconfig | 1 + drivers/infiniband/core/device.c | 7 +- drivers/infiniband/hw/Makefile | 1 + drivers/infiniband/hw/erdma/Kconfig | 12 + drivers/infiniband/hw/erdma/Makefile | 4 + drivers/infiniband/hw/erdma/erdma.h | 287 ++++ drivers/infiniband/hw/erdma/erdma_cm.c | 1435 ++++++++++++++++++++ drivers/infiniband/hw/erdma/erdma_cm.h | 168 +++ drivers/infiniband/hw/erdma/erdma_cmdq.c | 497 +++++++ drivers/infiniband/hw/erdma/erdma_cq.c | 205 +++ drivers/infiniband/hw/erdma/erdma_eq.c | 334 +++++ drivers/infiniband/hw/erdma/erdma_hw.h | 504 +++++++ drivers/infiniband/hw/erdma/erdma_main.c | 625 +++++++++ drivers/infiniband/hw/erdma/erdma_qp.c | 564 ++++++++ drivers/infiniband/hw/erdma/erdma_verbs.c | 1461 +++++++++++++++++++++ drivers/infiniband/hw/erdma/erdma_verbs.h | 342 +++++ include/uapi/rdma/erdma-abi.h | 49 + include/uapi/rdma/ib_user_ioctl_verbs.h | 1 + 19 files changed, 6504 insertions(+), 1 deletion(-) create mode 100644 drivers/infiniband/hw/erdma/Kconfig create mode 100644 drivers/infiniband/hw/erdma/Makefile create mode 100644 drivers/infiniband/hw/erdma/erdma.h create mode 100644 drivers/infiniband/hw/erdma/erdma_cm.c create mode 100644 drivers/infiniband/hw/erdma/erdma_cm.h create mode 100644 drivers/infiniband/hw/erdma/erdma_cmdq.c create mode 100644 drivers/infiniband/hw/erdma/erdma_cq.c create mode 100644 drivers/infiniband/hw/erdma/erdma_eq.c create mode 100644 drivers/infiniband/hw/erdma/erdma_hw.h create mode 100644 drivers/infiniband/hw/erdma/erdma_main.c create mode 100644 drivers/infiniband/hw/erdma/erdma_qp.c create mode 100644 drivers/infiniband/hw/erdma/erdma_verbs.c create mode 100644 drivers/infiniband/hw/erdma/erdma_verbs.h create mode 100644 include/uapi/rdma/erdma-abi.h