| Message ID | 20220518144122.231243-1-xiubli@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | ceph: switch TASK_INTERRUPTIBLE to TASK_KILLABLE | expand |
On Wed, 2022-05-18 at 22:41 +0800, Xiubo Li wrote: > If the task is placed in the TASK_INTERRUPTIBLE state it will sleep > until either something explicitly wakes it up, or a non-masked signal > is received. Switch to TASK_KILLABLE to avoid the noises. > > Cc: Matthew Wilcox <willy@infradead.org> > Signed-off-by: Xiubo Li <xiubli@redhat.com> > --- > fs/ceph/mds_client.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/ceph/mds_client.h b/fs/ceph/mds_client.h > index d1ae679c52c3..f72f40b3e26b 100644 > --- a/fs/ceph/mds_client.h > +++ b/fs/ceph/mds_client.h > @@ -579,7 +579,7 @@ static inline int ceph_wait_on_async_create(struct inode *inode) > struct ceph_inode_info *ci = ceph_inode(inode); > > return wait_on_bit(&ci->i_ceph_flags, CEPH_ASYNC_CREATE_BIT, > - TASK_INTERRUPTIBLE); > + TASK_KILLABLE); > } > > extern int ceph_wait_on_conflict_unlink(struct dentry *dentry); Reviewed-by: Jeff Layton <jlayton@kernel.org>
diff --git a/fs/ceph/mds_client.h b/fs/ceph/mds_client.h index d1ae679c52c3..f72f40b3e26b 100644 --- a/fs/ceph/mds_client.h +++ b/fs/ceph/mds_client.h @@ -579,7 +579,7 @@ static inline int ceph_wait_on_async_create(struct inode *inode) struct ceph_inode_info *ci = ceph_inode(inode); return wait_on_bit(&ci->i_ceph_flags, CEPH_ASYNC_CREATE_BIT, - TASK_INTERRUPTIBLE); + TASK_KILLABLE); } extern int ceph_wait_on_conflict_unlink(struct dentry *dentry);
If the task is placed in the TASK_INTERRUPTIBLE state it will sleep until either something explicitly wakes it up, or a non-masked signal is received. Switch to TASK_KILLABLE to avoid the noises. Cc: Matthew Wilcox <willy@infradead.org> Signed-off-by: Xiubo Li <xiubli@redhat.com> --- fs/ceph/mds_client.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)