| Message ID | 20220522155046.260146-10-tmaimon77@gmail.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | Introduce Nuvoton Arbel NPCM8XX BMC SoC | expand |
On 22/05/2022 17:50, Tomer Maimon wrote: > Describe syscon property that handles GCR registers > in Nuvoton BMC NPCM reset driver. Please wrap according to Linux standards: https://elixir.bootlin.com/linux/v5.18-rc4/source/Documentation/process/submitting-patches.rst#L586 > > Signed-off-by: Tomer Maimon <tmaimon77@gmail.com> > --- > Documentation/devicetree/bindings/reset/nuvoton,npcm-reset.txt | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/reset/nuvoton,npcm-reset.txt b/Documentation/devicetree/bindings/reset/nuvoton,npcm-reset.txt > index 17b7a6a43a29..cb1613092ee7 100644 > --- a/Documentation/devicetree/bindings/reset/nuvoton,npcm-reset.txt > +++ b/Documentation/devicetree/bindings/reset/nuvoton,npcm-reset.txt > @@ -4,6 +4,7 @@ Required properties: > - compatible : "nuvoton,npcm750-reset" for NPCM7XX BMC > - reg : specifies physical base address and size of the register. > - #reset-cells: must be set to 2 > +- syscon: a phandle to access GCR registers. syscon is not a generic property, so vendor prefix and some descriptive name of property. > > Optional property: > - nuvoton,sw-reset-number - Contains the software reset number to restart the SoC. > @@ -16,6 +17,7 @@ Example: > compatible = "nuvoton,npcm750-reset"; > reg = <0xf0801000 0x70>; > #reset-cells = <2>; > + syscon = <&gcr>; > nuvoton,sw-reset-number = <2>; > }; > Best regards, Krzysztof
Hi Krzysztof, Thanks for your comments. On Mon, 23 May 2022 at 10:39, Krzysztof Kozlowski < krzysztof.kozlowski@linaro.org> wrote: > On 22/05/2022 17:50, Tomer Maimon wrote: > > Describe syscon property that handles GCR registers > > in Nuvoton BMC NPCM reset driver. > > Please wrap according to Linux standards: > > https://elixir.bootlin.com/linux/v5.18-rc4/source/Documentation/process/submitting-patches.rst#L586 Which problem do you see with the commit explanation body? > > > > > > Signed-off-by: Tomer Maimon <tmaimon77@gmail.com> > > --- > > Documentation/devicetree/bindings/reset/nuvoton,npcm-reset.txt | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git > a/Documentation/devicetree/bindings/reset/nuvoton,npcm-reset.txt > b/Documentation/devicetree/bindings/reset/nuvoton,npcm-reset.txt > > index 17b7a6a43a29..cb1613092ee7 100644 > > --- a/Documentation/devicetree/bindings/reset/nuvoton,npcm-reset.txt > > +++ b/Documentation/devicetree/bindings/reset/nuvoton,npcm-reset.txt > > @@ -4,6 +4,7 @@ Required properties: > > - compatible : "nuvoton,npcm750-reset" for NPCM7XX BMC > > - reg : specifies physical base address and size of the register. > > - #reset-cells: must be set to 2 > > +- syscon: a phandle to access GCR registers. > > syscon is not a generic property, so vendor prefix and some descriptive > name of property. > > Will do. > > > > Optional property: > > - nuvoton,sw-reset-number - Contains the software reset number to > restart the SoC. > > @@ -16,6 +17,7 @@ Example: > > compatible = "nuvoton,npcm750-reset"; > > reg = <0xf0801000 0x70>; > > #reset-cells = <2>; > > + syscon = <&gcr>; > > nuvoton,sw-reset-number = <2>; > > }; > > > > > Best regards, > Krzysztof > Best Regards, Tomer
On 23/05/2022 15:44, Tomer Maimon wrote: > On Mon, 23 May 2022 at 10:39, Krzysztof Kozlowski > <krzysztof.kozlowski@linaro.org <mailto:krzysztof.kozlowski@linaro.org>> > wrote: > > On 22/05/2022 17:50, Tomer Maimon wrote: > > Describe syscon property that handles GCR registers > > in Nuvoton BMC NPCM reset driver. > > Please wrap according to Linux standards: > https://elixir.bootlin.com/linux/v5.18-rc4/source/Documentation/process/submitting-patches.rst#L586 > <https://elixir.bootlin.com/linux/v5.18-rc4/source/Documentation/process/submitting-patches.rst#L586> > > Which problem do you see with the commit explanation body? It is wrapped not according to Linux standards. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/reset/nuvoton,npcm-reset.txt b/Documentation/devicetree/bindings/reset/nuvoton,npcm-reset.txt index 17b7a6a43a29..cb1613092ee7 100644 --- a/Documentation/devicetree/bindings/reset/nuvoton,npcm-reset.txt +++ b/Documentation/devicetree/bindings/reset/nuvoton,npcm-reset.txt @@ -4,6 +4,7 @@ Required properties: - compatible : "nuvoton,npcm750-reset" for NPCM7XX BMC - reg : specifies physical base address and size of the register. - #reset-cells: must be set to 2 +- syscon: a phandle to access GCR registers. Optional property: - nuvoton,sw-reset-number - Contains the software reset number to restart the SoC. @@ -16,6 +17,7 @@ Example: compatible = "nuvoton,npcm750-reset"; reg = <0xf0801000 0x70>; #reset-cells = <2>; + syscon = <&gcr>; nuvoton,sw-reset-number = <2>; };
Describe syscon property that handles GCR registers in Nuvoton BMC NPCM reset driver. Signed-off-by: Tomer Maimon <tmaimon77@gmail.com> --- Documentation/devicetree/bindings/reset/nuvoton,npcm-reset.txt | 2 ++ 1 file changed, 2 insertions(+)