| Message ID | 20220522155046.260146-19-tmaimon77@gmail.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | Introduce Nuvoton Arbel NPCM8XX BMC SoC | expand |
On 22/05/2022 17:50, Tomer Maimon wrote: > Add initial Nuvoton NPCM845 evaluation board device tree. > > Signed-off-by: Tomer Maimon <tmaimon77@gmail.com> > --- > arch/arm64/boot/dts/nuvoton/Makefile | 2 + > .../boot/dts/nuvoton/nuvoton-npcm845-evb.dts | 50 +++++++++++++++++++ > 2 files changed, 52 insertions(+) > create mode 100644 arch/arm64/boot/dts/nuvoton/Makefile > create mode 100644 arch/arm64/boot/dts/nuvoton/nuvoton-npcm845-evb.dts > > diff --git a/arch/arm64/boot/dts/nuvoton/Makefile b/arch/arm64/boot/dts/nuvoton/Makefile > new file mode 100644 > index 000000000000..a99dab90472a > --- /dev/null > +++ b/arch/arm64/boot/dts/nuvoton/Makefile > @@ -0,0 +1,2 @@ > +# SPDX-License-Identifier: GPL-2.0 > +dtb-$(CONFIG_ARCH_NPCM) += nuvoton-npcm845-evb.dtb > diff --git a/arch/arm64/boot/dts/nuvoton/nuvoton-npcm845-evb.dts b/arch/arm64/boot/dts/nuvoton/nuvoton-npcm845-evb.dts > new file mode 100644 > index 000000000000..d7a9a85f8075 > --- /dev/null > +++ b/arch/arm64/boot/dts/nuvoton/nuvoton-npcm845-evb.dts > @@ -0,0 +1,50 @@ > +// SPDX-License-Identifier: GPL-2.0 > +// Copyright (c) 2021 Nuvoton Technology tomer.maimon@nuvoton.com > + > +/dts-v1/; > +#include "nuvoton-npcm845.dtsi" > + > +/ { > + model = "Nuvoton npcm845 Development Board (Device Tree)"; s/ (Device Tree)// > + compatible = "nuvoton,npcm845"; This does not match your bindings. Please test your DTS with `make dtbs_check`. > + > + aliases { > + serial0 = &serial0; > + serial1 = &serial1; > + serial2 = &serial2; > + serial3 = &serial3; > + }; > + > + chosen { > + stdout-path = &serial0; > + }; > + > + memory { > + reg = <0x0 0x0 0x0 0x40000000>; > + }; > + > + ahb { > + No need for blank line. > + apb { > + serial0: serial@0 { > + status = "okay"; No, override by labels. Here and in places below. > + }; > + > + serial1: serial@1000 { > + status = "disabled"; > + }; > + > + serial2: serial@2000 { > + status = "disabled"; > + }; > + > + serial3: serial@3000 { > + status = "disabled"; > + }; > + > + watchdog1: watchdog@901c { > + status = "okay"; > + }; > + }; > + }; > +}; Best regards, Krzysztof
On Sun, May 22, 2022 at 5:50 PM Tomer Maimon <tmaimon77@gmail.com> wrote: > +/ { > + model = "Nuvoton npcm845 Development Board (Device Tree)"; > + compatible = "nuvoton,npcm845"; > + > + aliases { > + serial0 = &serial0; > + serial1 = &serial1; > + serial2 = &serial2; > + serial3 = &serial3; > + }; > + apb { > + serial0: serial@0 { > + status = "okay"; > + }; > + > + serial1: serial@1000 { > + status = "disabled"; > + }; > + > + serial2: serial@2000 { > + status = "disabled"; > + }; > + > + serial3: serial@3000 { > + status = "disabled"; > + }; Please drop the aliases for disabled uarts. It probably also makes sense to have the status="disabled" properties in the .dtsi file and only override them when you explicitly want to enable a uart for a board. Arnd
Hi, Thanks for your comments. the patch will modify according to your comments and will be sent in the next kernel revision 5.19.rc1 On Mon, 23 May 2022 at 12:40, Arnd Bergmann <arnd@arndb.de> wrote: > On Sun, May 22, 2022 at 5:50 PM Tomer Maimon <tmaimon77@gmail.com> wrote: > > +/ { > > + model = "Nuvoton npcm845 Development Board (Device Tree)"; > > + compatible = "nuvoton,npcm845"; > > + > > + aliases { > > + serial0 = &serial0; > > + serial1 = &serial1; > > + serial2 = &serial2; > > + serial3 = &serial3; > > + }; > > > + apb { > > + serial0: serial@0 { > > + status = "okay"; > > + }; > > + > > + serial1: serial@1000 { > > + status = "disabled"; > > + }; > > + > > + serial2: serial@2000 { > > + status = "disabled"; > > + }; > > + > > + serial3: serial@3000 { > > + status = "disabled"; > > + }; > > Please drop the aliases for disabled uarts. It probably also makes > sense to have the status="disabled" properties in the .dtsi file and > only override them when you explicitly want to enable a uart for a > board. > > Arnd > Best regards, Tomer
On 23/05/2022 16:17, Tomer Maimon wrote: > Hi, > > Thanks for your comments. > > the patch will modify according to your comments and will be sent in the > next kernel revision 5.19.rc1 > None of your emails reach lists because of using HTML. Please use appropriate messaging format. Best regards, Krzysztof
diff --git a/arch/arm64/boot/dts/nuvoton/Makefile b/arch/arm64/boot/dts/nuvoton/Makefile new file mode 100644 index 000000000000..a99dab90472a --- /dev/null +++ b/arch/arm64/boot/dts/nuvoton/Makefile @@ -0,0 +1,2 @@ +# SPDX-License-Identifier: GPL-2.0 +dtb-$(CONFIG_ARCH_NPCM) += nuvoton-npcm845-evb.dtb diff --git a/arch/arm64/boot/dts/nuvoton/nuvoton-npcm845-evb.dts b/arch/arm64/boot/dts/nuvoton/nuvoton-npcm845-evb.dts new file mode 100644 index 000000000000..d7a9a85f8075 --- /dev/null +++ b/arch/arm64/boot/dts/nuvoton/nuvoton-npcm845-evb.dts @@ -0,0 +1,50 @@ +// SPDX-License-Identifier: GPL-2.0 +// Copyright (c) 2021 Nuvoton Technology tomer.maimon@nuvoton.com + +/dts-v1/; +#include "nuvoton-npcm845.dtsi" + +/ { + model = "Nuvoton npcm845 Development Board (Device Tree)"; + compatible = "nuvoton,npcm845"; + + aliases { + serial0 = &serial0; + serial1 = &serial1; + serial2 = &serial2; + serial3 = &serial3; + }; + + chosen { + stdout-path = &serial0; + }; + + memory { + reg = <0x0 0x0 0x0 0x40000000>; + }; + + ahb { + + apb { + serial0: serial@0 { + status = "okay"; + }; + + serial1: serial@1000 { + status = "disabled"; + }; + + serial2: serial@2000 { + status = "disabled"; + }; + + serial3: serial@3000 { + status = "disabled"; + }; + + watchdog1: watchdog@901c { + status = "okay"; + }; + }; + }; +};
Add initial Nuvoton NPCM845 evaluation board device tree. Signed-off-by: Tomer Maimon <tmaimon77@gmail.com> --- arch/arm64/boot/dts/nuvoton/Makefile | 2 + .../boot/dts/nuvoton/nuvoton-npcm845-evb.dts | 50 +++++++++++++++++++ 2 files changed, 52 insertions(+) create mode 100644 arch/arm64/boot/dts/nuvoton/Makefile create mode 100644 arch/arm64/boot/dts/nuvoton/nuvoton-npcm845-evb.dts