diff mbox series

soc: ixp4xx/qmgr: Fix unused match warning

Message ID 20220523085520.913217-1-linus.walleij@linaro.org (mailing list archive)
State Accepted
Commit 526f3f3b102f05e97d5e51fb0dcf5037c7be9722
Headers show
Series soc: ixp4xx/qmgr: Fix unused match warning | expand

Commit Message

Linus Walleij May 23, 2022, 8:55 a.m. UTC 
The kernel test robot found this inconsistency:

>> drivers/soc/ixp4xx/ixp4xx-npe.c:737:34: warning:
  'ixp4xx_npe_of_match' defined but not used [-Wunused-const-variable=]
     737 | static const struct of_device_id ixp4xx_npe_of_match[] = {

This is because the match is enclosed in the of_match_ptr()
which compiles into NULL when OF is disabled and this
is unnecessary.

Fix it by dropping of_match_ptr() around the match.

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
SoC maintainers: please apply this directly for fixes for v5.19.
---
 drivers/soc/ixp4xx/ixp4xx-qmgr.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

patchwork-bot+linux-soc@kernel.org May 27, 2022, 2:20 p.m. UTC | #1 
Hello:

This patch was applied to soc/soc.git (for-next)
by Arnd Bergmann <arnd@arndb.de>:

On Mon, 23 May 2022 10:55:20 +0200 you wrote:
> The kernel test robot found this inconsistency:
> 
> >> drivers/soc/ixp4xx/ixp4xx-npe.c:737:34: warning:
>   'ixp4xx_npe_of_match' defined but not used [-Wunused-const-variable=]
>      737 | static const struct of_device_id ixp4xx_npe_of_match[] = {
> 
> This is because the match is enclosed in the of_match_ptr()
> which compiles into NULL when OF is disabled and this
> is unnecessary.
> 
> [...]

Here is the summary with links:
  - soc: ixp4xx/qmgr: Fix unused match warning
    https://git.kernel.org/soc/soc/c/526f3f3b102f

You are awesome, thank you!
diff mbox series

Patch

diff --git a/drivers/soc/ixp4xx/ixp4xx-qmgr.c b/drivers/soc/ixp4xx/ixp4xx-qmgr.c
index 9154c7029b05..291086bb9313 100644
--- a/drivers/soc/ixp4xx/ixp4xx-qmgr.c
+++ b/drivers/soc/ixp4xx/ixp4xx-qmgr.c
@@ -459,7 +459,7 @@  static const struct of_device_id ixp4xx_qmgr_of_match[] = {
 static struct platform_driver ixp4xx_qmgr_driver = {
 	.driver = {
 		.name           = "ixp4xx-qmgr",
-		.of_match_table = of_match_ptr(ixp4xx_qmgr_of_match),
+		.of_match_table = ixp4xx_qmgr_of_match,
 	},
 	.probe = ixp4xx_qmgr_probe,
 	.remove = ixp4xx_qmgr_remove,