| Message ID | 20220528154704.2576290-1-masahiroy@kernel.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/4] kbuild: remove redundant cleanups in scripts/link-vmlinux.sh | expand |
On Sat, May 28, 2022 at 10:20 PM Masahiro Yamada <masahiroy@kernel.org> wrote: > > These are cleaned by the top Makefile. > > vmlinux.o and .vmlinux.d matches the '*.[aios]' and '.*.d' patterns > respectively. > > Signed-off-by: Masahiro Yamada <masahiroy@kernel.org> I applied this patchset on top of yesterday's kbuild.git#for-next (today's did not fit due to "kbuild: do not try to parse *.cmd files for objects provided by compiler"). Might be related to this patchset or not: $ LC_ALL=C ll .*vmlinux*export* -rw-r--r-- 1 dileks dileks 4.2K May 29 15:11 ..vmlinux.export.o.cmd -rw-r--r-- 1 dileks dileks 508K May 29 15:11 .vmlinux.export.c -rw-r--r-- 1 dileks dileks 2.6M May 29 15:11 .vmlinux.export.o You see the leading double-dot for ..vmlinux.export.o.cmd - intended or not? Tested-by: Sedat Dilek <sedat.dilek@gmail.com> # LLVM-14 (x86-64) -Sedat- > --- > > scripts/link-vmlinux.sh | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/scripts/link-vmlinux.sh b/scripts/link-vmlinux.sh > index a7f6196c7e41..844fc0125d72 100755 > --- a/scripts/link-vmlinux.sh > +++ b/scripts/link-vmlinux.sh > @@ -309,8 +309,6 @@ cleanup() > rm -f System.map > rm -f vmlinux > rm -f vmlinux.map > - rm -f vmlinux.o > - rm -f .vmlinux.d > rm -f .vmlinux.objs > rm -f .vmlinux.export.c > } > -- > 2.32.0 >
On Sun, May 29, 2022 at 11:38 PM Sedat Dilek <sedat.dilek@gmail.com> wrote: > > On Sat, May 28, 2022 at 10:20 PM Masahiro Yamada <masahiroy@kernel.org> wrote: > > > > These are cleaned by the top Makefile. > > > > vmlinux.o and .vmlinux.d matches the '*.[aios]' and '.*.d' patterns > > respectively. > > > > Signed-off-by: Masahiro Yamada <masahiroy@kernel.org> > > I applied this patchset on top of yesterday's kbuild.git#for-next > (today's did not fit due to "kbuild: do not try to parse *.cmd files > for objects provided by compiler"). > > Might be related to this patchset or not: > > $ LC_ALL=C ll .*vmlinux*export* > -rw-r--r-- 1 dileks dileks 4.2K May 29 15:11 ..vmlinux.export.o.cmd > -rw-r--r-- 1 dileks dileks 508K May 29 15:11 .vmlinux.export.c > -rw-r--r-- 1 dileks dileks 2.6M May 29 15:11 .vmlinux.export.o > > You see the leading double-dot for ..vmlinux.export.o.cmd - intended or not? This is intended. The source file (.vmlinux.export.c) is a dot file. .*.cmd prepends one more dot. > > Tested-by: Sedat Dilek <sedat.dilek@gmail.com> # LLVM-14 (x86-64) > > -Sedat- > > > --- > > > > scripts/link-vmlinux.sh | 2 -- > > 1 file changed, 2 deletions(-) > > > > diff --git a/scripts/link-vmlinux.sh b/scripts/link-vmlinux.sh > > index a7f6196c7e41..844fc0125d72 100755 > > --- a/scripts/link-vmlinux.sh > > +++ b/scripts/link-vmlinux.sh > > @@ -309,8 +309,6 @@ cleanup() > > rm -f System.map > > rm -f vmlinux > > rm -f vmlinux.map > > - rm -f vmlinux.o > > - rm -f .vmlinux.d > > rm -f .vmlinux.objs > > rm -f .vmlinux.export.c > > } > > -- > > 2.32.0 > >
On Sun, May 29, 2022 at 7:32 PM Masahiro Yamada <masahiroy@kernel.org> wrote: ... > > Might be related to this patchset or not: > > > > $ LC_ALL=C ll .*vmlinux*export* > > -rw-r--r-- 1 dileks dileks 4.2K May 29 15:11 ..vmlinux.export.o.cmd > > -rw-r--r-- 1 dileks dileks 508K May 29 15:11 .vmlinux.export.c > > -rw-r--r-- 1 dileks dileks 2.6M May 29 15:11 .vmlinux.export.o > > > > You see the leading double-dot for ..vmlinux.export.o.cmd - intended or not? > > This is intended. > > The source file (.vmlinux.export.c) is a dot file. > > .*.cmd prepends one more dot. > Fine with me. -sed@-
diff --git a/scripts/link-vmlinux.sh b/scripts/link-vmlinux.sh index a7f6196c7e41..844fc0125d72 100755 --- a/scripts/link-vmlinux.sh +++ b/scripts/link-vmlinux.sh @@ -309,8 +309,6 @@ cleanup() rm -f System.map rm -f vmlinux rm -f vmlinux.map - rm -f vmlinux.o - rm -f .vmlinux.d rm -f .vmlinux.objs rm -f .vmlinux.export.c }
These are cleaned by the top Makefile. vmlinux.o and .vmlinux.d matches the '*.[aios]' and '.*.d' patterns respectively. Signed-off-by: Masahiro Yamada <masahiroy@kernel.org> --- scripts/link-vmlinux.sh | 2 -- 1 file changed, 2 deletions(-)