| Message ID | YpRiZpZU3kH2xprC@linux-8mug (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | [GIT,PULL] arm64: s32g changes for v5.19 | expand |
On Mon, May 30, 2022 at 8:21 AM Chester Lin <clin@suse.com> wrote: > > ---------------------------------------------------------------- > s32g changes for v5.19 > > ---------------------------------------------------------------- > Chester Lin (1): > MAINTAINERS: add a new reviewer for S32G > > Fabio Estevam (1): > Pass unit name to soc node to fix the following W=1 build warning: The patches look fine, but there are a few minor problems with the submission: - The branch is based on top of a random commit from the mainline repository, you should instead always base this on top of an -rc tag in order to not clutter up the git history or make bisection unnecessarily hard. My 'arm/late' branch is currently based on a random commit 16477cdfefdb ("Merge tag 'asm-generic-5.19' of git://git.kernel.org/pub/scm/linux/kernel/git/arnd/asm-generic") as well, but this is an exception and I will explain it when I send the pull request ;-) - The tag description is only a single line, there should be at least some content in here. Please have a look at other merge commits to see what you can put in here. For a small number of independent patches like these two, you can also just forward them to soc@kernel.org as individual emails without a tag. - The subject lines of the individual emails should have the right namespace listed in them, e.g. 'arm64: s32g: ...'. Fabio's patch originally had this, but it looks like the entire subject line got lost. - The subject for the pull request indicates that this is meant as your normal submission, but this is the wrong time for that, because the merge window is currently open. At this point, only bugfixes get merged, but I do classify MAINTAINERS changes as bugfixes, so this is actually ok, just change the subject. Please address these and resend. Arnd
Hi Arnd, On Mon, May 30, 2022 at 08:58:47AM +0200, Arnd Bergmann wrote: > On Mon, May 30, 2022 at 8:21 AM Chester Lin <clin@suse.com> wrote: > > > > ---------------------------------------------------------------- > > s32g changes for v5.19 > > > > ---------------------------------------------------------------- > > Chester Lin (1): > > MAINTAINERS: add a new reviewer for S32G > > > > Fabio Estevam (1): > > Pass unit name to soc node to fix the following W=1 build warning: > > The patches look fine, but there are a few minor problems with the > submission: > > - The branch is based on top of a random commit from the mainline repository, > you should instead always base this on top of an -rc tag in order to not > clutter up the git history or make bisection unnecessarily hard. My 'arm/late' > branch is currently based on a random commit 16477cdfefdb ("Merge tag > 'asm-generic-5.19' of > git://git.kernel.org/pub/scm/linux/kernel/git/arnd/asm-generic") > as well, but this is an exception and I will explain it when I send the pull > request ;-) > Thanks for your guidance and sorry for any inconvenience this causes. I will wait for the next cycle. > - The tag description is only a single line, there should be at least some > content in here. Please have a look at other merge commits to see what > you can put in here. For a small number of independent patches like Sure, I will describe more information. > these two, you can also just forward them to soc@kernel.org as > individual emails without a tag. > > - The subject lines of the individual emails should have the right namespace > listed in them, e.g. 'arm64: s32g: ...'. Fabio's patch originally had > this, but it looks like the entire subject line got lost. > Sorry for the missing subject line. Will fix it. > - The subject for the pull request indicates that this is meant as your normal > submission, but this is the wrong time for that, because the merge window > is currently open. At this point, only bugfixes get merged, but I do classify > MAINTAINERS changes as bugfixes, so this is actually ok, just change the > subject. > Thanks for the reminder. > Please address these and resend. > > Arnd >
On Mon, May 30, 2022 at 2:58 PM Chester Lin <clin@suse.com> wrote: > On Mon, May 30, 2022 at 08:58:47AM +0200, Arnd Bergmann wrote: > > - The branch is based on top of a random commit from the mainline repository, > > you should instead always base this on top of an -rc tag in order to not > > clutter up the git history or make bisection unnecessarily hard. My 'arm/late' > > branch is currently based on a random commit 16477cdfefdb ("Merge tag > > 'asm-generic-5.19' of > > git://git.kernel.org/pub/scm/linux/kernel/git/arnd/asm-generic") > > as well, but this is an exception and I will explain it when I send the pull > > request ;-) > > > > Thanks for your guidance and sorry for any inconvenience this causes. I will > wait for the next cycle. Just to clarify: both of the patches you sent are good, and I want to apply them for 5.19, so please send them as a bugfix pull request. Arnd
Hi Arnd, Olof, and ARM SoC maintainers, Please pull the following two changes for s32g. Thanks. The following changes since commit b00ed48bb0a7c295facf9036135a573a5cdbe7de: Merge tag 'dmaengine-5.19-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/vkoul/dmaengine (2022-05-29 11:38:27 -0700) are available in the Git repository at: https://github.com/chesterlintw/linux-s32g.git tags/s32g2-5.19 for you to fetch changes up to fdb31e581566f7a2790b602f62701fce96b16443: MAINTAINERS: add a new reviewer for S32G (2022-05-30 11:21:49 +0800) ---------------------------------------------------------------- s32g changes for v5.19 ---------------------------------------------------------------- Chester Lin (1): MAINTAINERS: add a new reviewer for S32G Fabio Estevam (1): Pass unit name to soc node to fix the following W=1 build warning: MAINTAINERS | 1 + arch/arm64/boot/dts/freescale/s32g2.dtsi | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-)