| Message ID | 20220602053250.62593-3-chanho61.park@samsung.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [v2,1/6] dt-bindings: phy: samsung,ufs-phy: make pmu-syscon as phandle-array | expand |
On 02/06/2022 07:32, Chanho Park wrote: > Put const qualifier of samsung_ufs_phy_cfg pointer because they will > not be changed from drvdata. > > Signed-off-by: Chanho Park <chanho61.park@samsung.com> > --- > drivers/phy/samsung/phy-samsung-ufs.c | 4 ++-- > drivers/phy/samsung/phy-samsung-ufs.h | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/phy/samsung/phy-samsung-ufs.c b/drivers/phy/samsung/phy-samsung-ufs.c > index 602ddef259eb..b7ddb91a02be 100644 > --- a/drivers/phy/samsung/phy-samsung-ufs.c > +++ b/drivers/phy/samsung/phy-samsung-ufs.c > @@ -75,7 +75,7 @@ static int samsung_ufs_phy_wait_for_lock_acq(struct phy *phy) > static int samsung_ufs_phy_calibrate(struct phy *phy) > { > struct samsung_ufs_phy *ufs_phy = get_samsung_ufs_phy(phy); > - struct samsung_ufs_phy_cfg **cfgs = ufs_phy->cfg; > + const struct samsung_ufs_phy_cfg **cfgs = ufs_phy->cfg; This should be rather array of const pointers to const data. Best regards, Krzysztof
> > @@ -75,7 +75,7 @@ static int samsung_ufs_phy_wait_for_lock_acq(struct > > phy *phy) static int samsung_ufs_phy_calibrate(struct phy *phy) { > > struct samsung_ufs_phy *ufs_phy = get_samsung_ufs_phy(phy); > > - struct samsung_ufs_phy_cfg **cfgs = ufs_phy->cfg; > > + const struct samsung_ufs_phy_cfg **cfgs = ufs_phy->cfg; > > This should be rather array of const pointers to const data. The prototype of ufs_phy->cfg is 'const struct samsung_ufs_phy_cfg **' by this patch. So, it should be, const struct samsung_ufs_phy_cfg ** const cfgs = ufs_phy->cfg; Best Regards, Chanho Park
On 02/06/2022 15:04, Chanho Park wrote: >>> @@ -75,7 +75,7 @@ static int samsung_ufs_phy_wait_for_lock_acq(struct >>> phy *phy) static int samsung_ufs_phy_calibrate(struct phy *phy) { >>> struct samsung_ufs_phy *ufs_phy = get_samsung_ufs_phy(phy); >>> - struct samsung_ufs_phy_cfg **cfgs = ufs_phy->cfg; >>> + const struct samsung_ufs_phy_cfg **cfgs = ufs_phy->cfg; >> >> This should be rather array of const pointers to const data. > > The prototype of ufs_phy->cfg is 'const struct samsung_ufs_phy_cfg **' by this patch. > So, it should be, > > const struct samsung_ufs_phy_cfg ** const cfgs = ufs_phy->cfg; Not entirely, that would be const pointer (array) of pointers to const data. What you want is: const struct samsung_ufs_phy_cfg * const * cfgs = ufs_phy->cfg; Best regards, Krzysztof
diff --git a/drivers/phy/samsung/phy-samsung-ufs.c b/drivers/phy/samsung/phy-samsung-ufs.c index 602ddef259eb..b7ddb91a02be 100644 --- a/drivers/phy/samsung/phy-samsung-ufs.c +++ b/drivers/phy/samsung/phy-samsung-ufs.c @@ -75,7 +75,7 @@ static int samsung_ufs_phy_wait_for_lock_acq(struct phy *phy) static int samsung_ufs_phy_calibrate(struct phy *phy) { struct samsung_ufs_phy *ufs_phy = get_samsung_ufs_phy(phy); - struct samsung_ufs_phy_cfg **cfgs = ufs_phy->cfg; + const struct samsung_ufs_phy_cfg **cfgs = ufs_phy->cfg; const struct samsung_ufs_phy_cfg *cfg; int err = 0; int i; @@ -327,7 +327,7 @@ static int samsung_ufs_phy_probe(struct platform_device *pdev) drvdata = match->data; phy->dev = dev; phy->drvdata = drvdata; - phy->cfg = (struct samsung_ufs_phy_cfg **)drvdata->cfg; + phy->cfg = drvdata->cfg; phy->isol = &drvdata->isol; phy->lane_cnt = PHY_DEF_LANE_CNT; diff --git a/drivers/phy/samsung/phy-samsung-ufs.h b/drivers/phy/samsung/phy-samsung-ufs.h index 91a0e9f94f98..8c3696b3c5ec 100644 --- a/drivers/phy/samsung/phy-samsung-ufs.h +++ b/drivers/phy/samsung/phy-samsung-ufs.h @@ -121,7 +121,7 @@ struct samsung_ufs_phy { struct clk *rx0_symbol_clk; struct clk *rx1_symbol_clk; const struct samsung_ufs_phy_drvdata *drvdata; - struct samsung_ufs_phy_cfg **cfg; + const struct samsung_ufs_phy_cfg **cfg; const struct pmu_isol *isol; u8 lane_cnt; int ufs_phy_state;
Put const qualifier of samsung_ufs_phy_cfg pointer because they will not be changed from drvdata. Signed-off-by: Chanho Park <chanho61.park@samsung.com> --- drivers/phy/samsung/phy-samsung-ufs.c | 4 ++-- drivers/phy/samsung/phy-samsung-ufs.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-)