| Message ID | 20220603130849.38252-1-linmq006@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [v2] PCI: brcmstb: Fix refcount leak in brcm_pcie_probe | expand |
On Fri, Jun 3, 2022 at 8:09 AM Miaoqian Lin <linmq006@gmail.com> wrote: > > of_parse_phandle() returns a node pointer with refcount > incremented, we should use of_node_put() on it when not need anymore. > Add missing of_node_put() to avoid refcount leak. > > Fixes: 40ca1bf580ef ("PCI: brcmstb: Add MSI support") > Signed-off-by: Miaoqian Lin <linmq006@gmail.com> > --- > changes in v2: > - update Fixes tag. > v1 Link: https://lore.kernel.org/r/20220602125003.10723-1-linmq006@gmail.com > --- > drivers/pci/controller/pcie-brcmstb.c | 2 ++ > 1 file changed, 2 insertions(+) Reviewed-by: Rob Herring <robh@kernel.org>
On Fri, Jun 03, 2022 at 05:08:49PM +0400, Miaoqian Lin wrote: > of_parse_phandle() returns a node pointer with refcount > incremented, we should use of_node_put() on it when not need anymore. > Add missing of_node_put() to avoid refcount leak. > > Fixes: 40ca1bf580ef ("PCI: brcmstb: Add MSI support") > Signed-off-by: Miaoqian Lin <linmq006@gmail.com> Applied with Rob's reviewed-by to pci/ctrl/brcmstb for v5.20, thanks! > --- > changes in v2: > - update Fixes tag. > v1 Link: https://lore.kernel.org/r/20220602125003.10723-1-linmq006@gmail.com > --- > drivers/pci/controller/pcie-brcmstb.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/pci/controller/pcie-brcmstb.c b/drivers/pci/controller/pcie-brcmstb.c > index 375c0c40bbf8..e3b673441a11 100644 > --- a/drivers/pci/controller/pcie-brcmstb.c > +++ b/drivers/pci/controller/pcie-brcmstb.c > @@ -1597,8 +1597,10 @@ static int brcm_pcie_probe(struct platform_device *pdev) > ret = brcm_pcie_enable_msi(pcie); > if (ret) { > dev_err(pcie->dev, "probe of internal MSI failed"); > + of_node_put(msi_np); > goto fail; > } > + of_node_put(msi_np); > } > > bridge->ops = pcie->type == BCM7425 ? &brcm_pcie_ops32 : &brcm_pcie_ops; > -- > 2.25.1 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
diff --git a/drivers/pci/controller/pcie-brcmstb.c b/drivers/pci/controller/pcie-brcmstb.c index 375c0c40bbf8..e3b673441a11 100644 --- a/drivers/pci/controller/pcie-brcmstb.c +++ b/drivers/pci/controller/pcie-brcmstb.c @@ -1597,8 +1597,10 @@ static int brcm_pcie_probe(struct platform_device *pdev) ret = brcm_pcie_enable_msi(pcie); if (ret) { dev_err(pcie->dev, "probe of internal MSI failed"); + of_node_put(msi_np); goto fail; } + of_node_put(msi_np); } bridge->ops = pcie->type == BCM7425 ? &brcm_pcie_ops32 : &brcm_pcie_ops;
of_parse_phandle() returns a node pointer with refcount incremented, we should use of_node_put() on it when not need anymore. Add missing of_node_put() to avoid refcount leak. Fixes: 40ca1bf580ef ("PCI: brcmstb: Add MSI support") Signed-off-by: Miaoqian Lin <linmq006@gmail.com> --- changes in v2: - update Fixes tag. v1 Link: https://lore.kernel.org/r/20220602125003.10723-1-linmq006@gmail.com --- drivers/pci/controller/pcie-brcmstb.c | 2 ++ 1 file changed, 2 insertions(+)