| Message ID | 20220610084545.547700-20-nuno.sa@analog.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | make iio inkern interface firmware agnostic | expand |
On Fri, 10 Jun 2022 10:45:30 +0200 Nuno Sá <nuno.sa@analog.com> wrote: > There is no reason to include OF as we only need to forward declare > 'of_phandle_args'. Previously, some drivers were actually relying on > this for some headers (those were already fixed). > > Signed-off-by: Nuno Sá <nuno.sa@analog.com> This one deserves a 'woot' :) I would have guessed we were much further off being able to do this than the 18 patches earlier in this series. Good work from Andy and yourself to get to the point where this was possible. Applied to the togreg branch of iio.git and pushed out as testing for 0-day to take a look. I'm probably going to review the remainder, but leave on list a bit longer as they are more complex/controversial than this includes cleanup. Thanks, Jonathan > --- > include/linux/iio/iio.h | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/include/linux/iio/iio.h b/include/linux/iio/iio.h > index 4e21a82b3756..d9b4a9ca9a0f 100644 > --- a/include/linux/iio/iio.h > +++ b/include/linux/iio/iio.h > @@ -11,13 +11,14 @@ > #include <linux/cdev.h> > #include <linux/slab.h> > #include <linux/iio/types.h> > -#include <linux/of.h> > /* IIO TODO LIST */ > /* > * Provide means of adjusting timer accuracy. > * Currently assumes nano seconds. > */ > > +struct of_phandle_args; > + > enum iio_shared_by { > IIO_SEPARATE, > IIO_SHARED_BY_TYPE,
diff --git a/include/linux/iio/iio.h b/include/linux/iio/iio.h index 4e21a82b3756..d9b4a9ca9a0f 100644 --- a/include/linux/iio/iio.h +++ b/include/linux/iio/iio.h @@ -11,13 +11,14 @@ #include <linux/cdev.h> #include <linux/slab.h> #include <linux/iio/types.h> -#include <linux/of.h> /* IIO TODO LIST */ /* * Provide means of adjusting timer accuracy. * Currently assumes nano seconds. */ +struct of_phandle_args; + enum iio_shared_by { IIO_SEPARATE, IIO_SHARED_BY_TYPE,
There is no reason to include OF as we only need to forward declare 'of_phandle_args'. Previously, some drivers were actually relying on this for some headers (those were already fixed). Signed-off-by: Nuno Sá <nuno.sa@analog.com> --- include/linux/iio/iio.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)