| Message ID | 20220505024833.8494-1-hanyihao@vivo.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | soc: ti: wkup_m3_ipc: replace DEFINE_SIMPLE_ATTRIBUTE with DEFINE_DEBUGFS_ATTRIBUTE | expand |
On 19:48-20220504, Yihao Han wrote: > Fix the following coccicheck warning: > ./drivers/soc/ti/wkup_m3_ipc.c:198:0-23: WARNING: > wkup_m3_ipc_option_fops should be defined with > DEFINE_DEBUGFS_ATTRIBUTE > > Signed-off-by: Yihao Han <hanyihao@vivo.com> > --- > drivers/soc/ti/wkup_m3_ipc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/soc/ti/wkup_m3_ipc.c b/drivers/soc/ti/wkup_m3_ipc.c > index 0076d467ff6b..2142d8fb3f5c 100644 > --- a/drivers/soc/ti/wkup_m3_ipc.c > +++ b/drivers/soc/ti/wkup_m3_ipc.c > @@ -195,7 +195,7 @@ static int option_set(void *data, u64 val) > return 0; > } > > -DEFINE_SIMPLE_ATTRIBUTE(wkup_m3_ipc_option_fops, option_get, option_set, > +DEFINE_DEBUGFS_ATTRIBUTE(wkup_m3_ipc_option_fops, option_get, option_set, > "%llu\n"); Please run ./scripts/checkpatch --strict patch +CHECK: Alignment should match open parenthesis +#29: FILE: drivers/soc/ti/wkup_m3_ipc.c:199: ++DEFINE_DEBUGFS_ATTRIBUTE(wkup_m3_ipc_option_fops, option_get, option_set, + "%llu\n"); + mechanically convert to the typical style using --fix or --fix-inplace. + them to the maintainer, see CHECKPATCH in MAINTAINERS. Could you fix and post a V2? > > static int wkup_m3_ipc_dbg_init(struct wkup_m3_ipc *m3_ipc) > -- > 2.17.1 >
diff --git a/drivers/soc/ti/wkup_m3_ipc.c b/drivers/soc/ti/wkup_m3_ipc.c index 0076d467ff6b..2142d8fb3f5c 100644 --- a/drivers/soc/ti/wkup_m3_ipc.c +++ b/drivers/soc/ti/wkup_m3_ipc.c @@ -195,7 +195,7 @@ static int option_set(void *data, u64 val) return 0; } -DEFINE_SIMPLE_ATTRIBUTE(wkup_m3_ipc_option_fops, option_get, option_set, +DEFINE_DEBUGFS_ATTRIBUTE(wkup_m3_ipc_option_fops, option_get, option_set, "%llu\n"); static int wkup_m3_ipc_dbg_init(struct wkup_m3_ipc *m3_ipc)
Fix the following coccicheck warning: ./drivers/soc/ti/wkup_m3_ipc.c:198:0-23: WARNING: wkup_m3_ipc_option_fops should be defined with DEFINE_DEBUGFS_ATTRIBUTE Signed-off-by: Yihao Han <hanyihao@vivo.com> --- drivers/soc/ti/wkup_m3_ipc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)