| Message ID | 20220613195658.5607-8-brad@pensando.io (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Support AMD Pensando Elba SoC | expand |
On Mon, Jun 13, 2022 at 12:56:50PM -0700, Brad Larson wrote: > From: Brad Larson <blarson@amd.com> > > Document bindings for AMD Pensando Elba SR Reset Controller > > Signed-off-by: Brad Larson <blarson@amd.com> > --- > .../reset/amd,pensando-elbasr-reset.yaml | 62 +++++++++++++++++++ > 1 file changed, 62 insertions(+) > create mode 100644 Documentation/devicetree/bindings/reset/amd,pensando-elbasr-reset.yaml > > diff --git a/Documentation/devicetree/bindings/reset/amd,pensando-elbasr-reset.yaml b/Documentation/devicetree/bindings/reset/amd,pensando-elbasr-reset.yaml > new file mode 100644 > index 000000000000..03bb86ebcfd3 > --- /dev/null > +++ b/Documentation/devicetree/bindings/reset/amd,pensando-elbasr-reset.yaml > @@ -0,0 +1,62 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/reset/amd,pensando-elbasr-reset.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: AMD Pensando Elba SoC Reset Controller Device Tree Bindings > + > +maintainers: > + - Brad Larson <blarson@amd.com> > + > +description: | > + AMD Pensando Elba SoC reset controller driver which supports a resource > + controller connected to the Elba SoC over a SPI bus. The Elba reset > + controller must be defined as a child node of the Elba SPI bus > + chip-select 0 node. > + > + See also: > + - dt-bindings/reset/amd,pensando-elba-reset.h > + > +properties: > + $nodename: > + pattern: "^reset-controller@[0-9a-f]+$" > + > + compatible: > + const: amd,pensando-elbasr-reset > + > + reg: > + const: 0 > + > + '#reset-cells': > + const: 1 > + > +required: > + - compatible > + - reg > + - '#reset-cells' > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/reset/amd,pensando-elba-reset.h> > + spi0 { > + #address-cells = <1>; > + #size-cells = <0>; > + num-cs = <4>; > + > + spi@0 { 'spi' is reserved for SPI buses. I thought this was an MFD. > + reg = <0>; > + #address-cells = <1>; > + #size-cells = <0>; > + > + rstc: reset-controller@0 { > + compatible = "amd,pensando-elbasr-reset"; > + reg = <0>; > + #reset-cells = <1>; > + }; > + }; > + }; > + > +... > -- > 2.17.1 > >
On 13/06/2022 21:56, Brad Larson wrote: > From: Brad Larson <blarson@amd.com> > > Document bindings for AMD Pensando Elba SR Reset Controller > > Signed-off-by: Brad Larson <blarson@amd.com> > --- > .../reset/amd,pensando-elbasr-reset.yaml | 62 +++++++++++++++++++ > 1 file changed, 62 insertions(+) > create mode 100644 Documentation/devicetree/bindings/reset/amd,pensando-elbasr-reset.yaml > > diff --git a/Documentation/devicetree/bindings/reset/amd,pensando-elbasr-reset.yaml b/Documentation/devicetree/bindings/reset/amd,pensando-elbasr-reset.yaml > new file mode 100644 > index 000000000000..03bb86ebcfd3 > --- /dev/null > +++ b/Documentation/devicetree/bindings/reset/amd,pensando-elbasr-reset.yaml > @@ -0,0 +1,62 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/reset/amd,pensando-elbasr-reset.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: AMD Pensando Elba SoC Reset Controller Device Tree Bindings Here and in all other patches: s/Device Tree Bindings// > + > +maintainers: > + - Brad Larson <blarson@amd.com> > + > +description: | > + AMD Pensando Elba SoC reset controller driver which supports a resource > + controller connected to the Elba SoC over a SPI bus. The Elba reset > + controller must be defined as a child node of the Elba SPI bus > + chip-select 0 node. > + > + See also: > + - dt-bindings/reset/amd,pensando-elba-reset.h > + > +properties: > + $nodename: > + pattern: "^reset-controller@[0-9a-f]+$" Skip the pattern. No particular need for it and unit address part is not correct (const: 0). > + > + compatible: > + const: amd,pensando-elbasr-reset > + > + reg: > + const: 0 > + > + '#reset-cells': > + const: 1 > + > +required: > + - compatible > + - reg > + - '#reset-cells' > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/reset/amd,pensando-elba-reset.h> Missing file: ls: cannot access 'include/dt-bindings/reset/amd,pensando-elba-reset.h': No such file or directory Send complete bindings, not parts of it. Did you test it? I am pretty sure that this did not happen. :( > + spi0 { spi > + #address-cells = <1>; > + #size-cells = <0>; > + num-cs = <4>; > + > + spi@0 { > + reg = <0>; > + #address-cells = <1>; > + #size-cells = <0>; > + > + rstc: reset-controller@0 { > + compatible = "amd,pensando-elbasr-reset"; > + reg = <0>; > + #reset-cells = <1>; > + }; > + }; > + }; > + > +... Best regards, Krzysztof
Hi Rob, On Tue, Jun 14, 2022 at 2:32 PM Rob Herring <robh@kernel.org> wrote: > > On Mon, Jun 13, 2022 at 12:56:50PM -0700, Brad Larson wrote: > > From: Brad Larson <blarson@amd.com> > > > > Document bindings for AMD Pensando Elba SR Reset Controller > > > > Signed-off-by: Brad Larson <blarson@amd.com> > > --- > > .../reset/amd,pensando-elbasr-reset.yaml | 62 +++++++++++++++++++ > > 1 file changed, 62 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/reset/amd,pensando-elbasr-reset.yaml > > > > diff --git a/Documentation/devicetree/bindings/reset/amd,pensando-elbasr-reset.yaml b/Documentation/devicetree/bindings/reset/amd,pensando-elbasr-reset.yaml > > new file mode 100644 > > index 000000000000..03bb86ebcfd3 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/reset/amd,pensando-elbasr-reset.yaml > > @@ -0,0 +1,62 @@ > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/reset/amd,pensando-elbasr-reset.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: AMD Pensando Elba SoC Reset Controller Device Tree Bindings > > + > > +maintainers: > > + - Brad Larson <blarson@amd.com> > > + > > +description: | > > + AMD Pensando Elba SoC reset controller driver which supports a resource > > + controller connected to the Elba SoC over a SPI bus. The Elba reset > > + controller must be defined as a child node of the Elba SPI bus > > + chip-select 0 node. > > + > > + See also: > > + - dt-bindings/reset/amd,pensando-elba-reset.h > > + > > +properties: > > + $nodename: > > + pattern: "^reset-controller@[0-9a-f]+$" > > + > > + compatible: > > + const: amd,pensando-elbasr-reset > > + > > + reg: > > + const: 0 > > + > > + '#reset-cells': > > + const: 1 > > + > > +required: > > + - compatible > > + - reg > > + - '#reset-cells' > > + > > +additionalProperties: false > > + > > +examples: > > + - | > > + #include <dt-bindings/reset/amd,pensando-elba-reset.h> > > + spi0 { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + num-cs = <4>; > > + > > + spi@0 { > > 'spi' is reserved for SPI buses. I thought this was an MFD. Looking at other drivers/mfd files the naming convention could allow the following, how about this? spi@0 { sr_regs@0 { rstc: reset-controller@0 { dw_i2c@1 { lattice_i2c@2 { flash@3 { Regards, Brad
Hi Krzysztof, On Mon, Jun 20, 2022 at 6:00 AM Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > On 13/06/2022 21:56, Brad Larson wrote: > > From: Brad Larson <blarson@amd.com> > > > > Document bindings for AMD Pensando Elba SR Reset Controller > > > > Signed-off-by: Brad Larson <blarson@amd.com> > > --- > > .../reset/amd,pensando-elbasr-reset.yaml | 62 +++++++++++++++++++ > > 1 file changed, 62 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/reset/amd,pensando-elbasr-reset.yaml > > > > diff --git a/Documentation/devicetree/bindings/reset/amd,pensando-elbasr-reset.yaml b/Documentation/devicetree/bindings/reset/amd,pensando-elbasr-reset.yaml > > new file mode 100644 > > index 000000000000..03bb86ebcfd3 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/reset/amd,pensando-elbasr-reset.yaml > > @@ -0,0 +1,62 @@ > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/reset/amd,pensando-elbasr-reset.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: AMD Pensando Elba SoC Reset Controller Device Tree Bindings > > Here and in all other patches: > s/Device Tree Bindings// Removed, must be implicit now, currently 366 files use it $ find . -name \*.yaml|xargs grep title|grep 'Device Tree Bindings'|wc 366 > > + > > +maintainers: > > + - Brad Larson <blarson@amd.com> > > + > > +description: | > > + AMD Pensando Elba SoC reset controller driver which supports a resource > > + controller connected to the Elba SoC over a SPI bus. The Elba reset > > + controller must be defined as a child node of the Elba SPI bus > > + chip-select 0 node. > > + > > + See also: > > + - dt-bindings/reset/amd,pensando-elba-reset.h > > + > > +properties: > > + $nodename: > > + pattern: "^reset-controller@[0-9a-f]+$" > > Skip the pattern. No particular need for it and unit address part is not > correct (const: 0). Deleted these lines $nodename: pattern: "^reset-controller@[0-9a-f]+$" > > > + > > + compatible: > > + const: amd,pensando-elbasr-reset > > + > > + reg: > > + const: 0 > > + > > + '#reset-cells': > > + const: 1 > > + > > +required: > > + - compatible > > + - reg > > + - '#reset-cells' > > + > > +additionalProperties: false > > + > > +examples: > > + - | > > + #include <dt-bindings/reset/amd,pensando-elba-reset.h> > > Missing file: > ls: cannot access 'include/dt-bindings/reset/amd,pensando-elba-reset.h': > No such file or directory > > > Send complete bindings, not parts of it. Did you test it? I am pretty > sure that this did not happen. :( Its in patch v5-0015 with the driver. I'll check this, the correct approach should be put all binding changes as individual patches up front or there are exceptions for new driver. $ cat v5-0015-reset-elbasr-Add-AMD-Pensando-Elba-SR-Reset-Contr.patch | grep diff diff --git a/drivers/reset/Kconfig b/drivers/reset/Kconfig diff --git a/drivers/reset/Makefile b/drivers/reset/Makefile diff --git a/drivers/reset/reset-elbasr.c b/drivers/reset/reset-elbasr.c diff --git a/include/dt-bindings/reset/amd,pensando-elba-reset.h b/include/dt-bindings/reset/amd,pensando-elba-reset.h Yes, tested it with the following and no warnings or errors make ARCH=arm64 dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/arm/amd,pensando.yaml make ARCH=arm64 dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/mfd/syscon.yaml make ARCH=arm64 dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/mmc/cdns,sdhci.yaml make ARCH=arm64 dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml make ARCH=arm64 dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml make ARCH=arm64 dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/vendor-prefixes.yaml make ARCH=arm64 dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/mfd/amd,pensando-elbasr.yaml make ARCH=arm64 dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/reset/amd,pensando-elbasr-reset.yaml make DT_CHECKER_FLAGS=-m dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/arm/amd,pensando.yaml make DT_CHECKER_FLAGS=-m dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/mfd/syscon.yaml make DT_CHECKER_FLAGS=-m dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/mmc/cdns,sdhci.yaml make DT_CHECKER_FLAGS=-m dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml make DT_CHECKER_FLAGS=-m dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml make DT_CHECKER_FLAGS=-m dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/vendor-prefixes.yaml make DT_CHECKER_FLAGS=-m dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/mfd/amd,pensando-elbasr.yaml make DT_CHECKER_FLAGS=-m dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/reset/amd,pensando-elbasr-reset.yaml > > + spi0 { > > spi Changed to spi Regards, Brad
On 04/07/2022 01:50, Brad Larson wrote: >> Missing file: >> ls: cannot access 'include/dt-bindings/reset/amd,pensando-elba-reset.h': >> No such file or directory >> >> >> Send complete bindings, not parts of it. Did you test it? I am pretty >> sure that this did not happen. :( > > Its in patch v5-0015 with the driver Header is part of bindings, not driver. >. I'll check this, the correct > approach should be put all binding changes as individual patches up > front or there are exceptions for new driver. > > $ cat v5-0015-reset-elbasr-Add-AMD-Pensando-Elba-SR-Reset-Contr.patch > | grep diff > diff --git a/drivers/reset/Kconfig b/drivers/reset/Kconfig > diff --git a/drivers/reset/Makefile b/drivers/reset/Makefile > diff --git a/drivers/reset/reset-elbasr.c b/drivers/reset/reset-elbasr.c > diff --git a/include/dt-bindings/reset/amd,pensando-elba-reset.h > b/include/dt-bindings/reset/amd,pensando-elba-reset.h > > Yes, tested it with the following and no warnings or errors > make ARCH=arm64 dtbs_check > DT_SCHEMA_FILES=Documentation/devicetree/bindings/arm/amd,pensando.yaml > make ARCH=arm64 dtbs_check > DT_SCHEMA_FILES=Documentation/devicetree/bindings/mfd/syscon.yaml > make ARCH=arm64 dtbs_check > DT_SCHEMA_FILES=Documentation/devicetree/bindings/mmc/cdns,sdhci.yaml > make ARCH=arm64 dtbs_check > DT_SCHEMA_FILES=Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml > make ARCH=arm64 dtbs_check > DT_SCHEMA_FILES=Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml > make ARCH=arm64 dtbs_check > DT_SCHEMA_FILES=Documentation/devicetree/bindings/vendor-prefixes.yaml > make ARCH=arm64 dtbs_check > DT_SCHEMA_FILES=Documentation/devicetree/bindings/mfd/amd,pensando-elbasr.yaml > make ARCH=arm64 dtbs_check > DT_SCHEMA_FILES=Documentation/devicetree/bindings/reset/amd,pensando-elbasr-reset.yaml > > make DT_CHECKER_FLAGS=-m dt_binding_check > DT_SCHEMA_FILES=Documentation/devicetree/bindings/arm/amd,pensando.yaml > make DT_CHECKER_FLAGS=-m dt_binding_check > DT_SCHEMA_FILES=Documentation/devicetree/bindings/mfd/syscon.yaml > make DT_CHECKER_FLAGS=-m dt_binding_check > DT_SCHEMA_FILES=Documentation/devicetree/bindings/mmc/cdns,sdhci.yaml > make DT_CHECKER_FLAGS=-m dt_binding_check > DT_SCHEMA_FILES=Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml > make DT_CHECKER_FLAGS=-m dt_binding_check > DT_SCHEMA_FILES=Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml > make DT_CHECKER_FLAGS=-m dt_binding_check > DT_SCHEMA_FILES=Documentation/devicetree/bindings/vendor-prefixes.yaml > make DT_CHECKER_FLAGS=-m dt_binding_check > DT_SCHEMA_FILES=Documentation/devicetree/bindings/mfd/amd,pensando-elbasr.yaml > make DT_CHECKER_FLAGS=-m dt_binding_check > DT_SCHEMA_FILES=Documentation/devicetree/bindings/reset/amd,pensando-elbasr-reset.yaml So how this test could pass if there is no header file included in the example here? Are you sure you tested each commit separately (like it will be included in the kernel)? Best regards, Krzysztof
Hi Krzysztof, On Sun, Jul 3, 2022 at 11:41 PM Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > On 04/07/2022 01:50, Brad Larson wrote: > >> Missing file: > >> ls: cannot access 'include/dt-bindings/reset/amd,pensando-elba-reset.h': > >> No such file or directory > >> > >> > >> Send complete bindings, not parts of it. Did you test it? I am pretty > >> sure that this did not happen. :( > > > > Its in patch v5-0015 with the driver > > Header is part of bindings, not driver. That's the reason, the header was not with the bindings. > ... > So how this test could pass if there is no header file included in the > example here? Are you sure you tested each commit separately (like it > will be included in the kernel)? and I had applied the patchset before running the checks. I'll check each commit separately for next version. Regards, Brad
On 05/07/2022 20:28, Brad Larson wrote: > Hi Krzysztof, > > On Sun, Jul 3, 2022 at 11:41 PM Krzysztof Kozlowski > <krzysztof.kozlowski@linaro.org> wrote: >> >> On 04/07/2022 01:50, Brad Larson wrote: >>>> Missing file: >>>> ls: cannot access 'include/dt-bindings/reset/amd,pensando-elba-reset.h': >>>> No such file or directory >>>> >>>> >>>> Send complete bindings, not parts of it. Did you test it? I am pretty >>>> sure that this did not happen. :( >>> >>> Its in patch v5-0015 with the driver >> >> Header is part of bindings, not driver. > > That's the reason, the header was not with the bindings. Sorry, I don't understand. The reason header was not with the bindings is that header is part of bindings? That does not make really sense... Anyway, don't mix up bindings and driver changes in one commit. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/reset/amd,pensando-elbasr-reset.yaml b/Documentation/devicetree/bindings/reset/amd,pensando-elbasr-reset.yaml new file mode 100644 index 000000000000..03bb86ebcfd3 --- /dev/null +++ b/Documentation/devicetree/bindings/reset/amd,pensando-elbasr-reset.yaml @@ -0,0 +1,62 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/reset/amd,pensando-elbasr-reset.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: AMD Pensando Elba SoC Reset Controller Device Tree Bindings + +maintainers: + - Brad Larson <blarson@amd.com> + +description: | + AMD Pensando Elba SoC reset controller driver which supports a resource + controller connected to the Elba SoC over a SPI bus. The Elba reset + controller must be defined as a child node of the Elba SPI bus + chip-select 0 node. + + See also: + - dt-bindings/reset/amd,pensando-elba-reset.h + +properties: + $nodename: + pattern: "^reset-controller@[0-9a-f]+$" + + compatible: + const: amd,pensando-elbasr-reset + + reg: + const: 0 + + '#reset-cells': + const: 1 + +required: + - compatible + - reg + - '#reset-cells' + +additionalProperties: false + +examples: + - | + #include <dt-bindings/reset/amd,pensando-elba-reset.h> + spi0 { + #address-cells = <1>; + #size-cells = <0>; + num-cs = <4>; + + spi@0 { + reg = <0>; + #address-cells = <1>; + #size-cells = <0>; + + rstc: reset-controller@0 { + compatible = "amd,pensando-elbasr-reset"; + reg = <0>; + #reset-cells = <1>; + }; + }; + }; + +...