[net-next,v3,0/5] PolarFire SoC macb reset support

Message

Conor Dooley July 6, 2022, 9:51 a.m. UTC

Hey all,
Jakub requested that these patches be split off from the series
adding the reset controller itself that I sent ~yesterday~ last
week [0].

The Cadence MACBs on PolarFire SoC (MPFS) have reset capability and are
compatible with the zynqmp's init function. I have removed the zynqmp
specific comments from that function & renamed it to reflect what it
does, since it is no longer zynqmp only.

MPFS's MACB had previously used the generic binding, so I also added
the required specific binding.

For v2, I noticed some low hanging cleanup fruit so there are extra
patches added for that:
moving the init function out of the config structs, aligning the
alignment of the zynqmp & default config structs with the other dozen
or so structs & simplifing the error paths to use dev_err_probe().

Feel free to apply as many or as few of those as you like.

Thanks,
Conor.

Changes since v2:
- Fix a commit message typo

Changes since v1:
- added the 3 aforementioned cleanup patches
- fixed two stylistic complaints from Claudiu


Conor Dooley (5):
  dt-bindings: net: cdns,macb: document polarfire soc's macb
  net: macb: add polarfire soc reset support
  net: macb: unify macb_config alignment style
  net: macb: simplify error paths in init_reset_optional()
  net: macb: sort init_reset_optional() with other init()s

 .../devicetree/bindings/net/cdns,macb.yaml    |   1 +
 drivers/net/ethernet/cadence/macb_main.c      | 106 +++++++++---------
 2 files changed, 56 insertions(+), 51 deletions(-)

Comments

[e-mail] July 8, 2022, 3:10 a.m. UTC | #1

Hello:

This series was applied to netdev/net-next.git (master)
by Jakub Kicinski <[e-mail]>:

On Wed, 6 Jul 2022 10:51:24 +0100 you wrote:
> Hey all,
> Jakub requested that these patches be split off from the series
> adding the reset controller itself that I sent ~yesterday~ last
> week [0].
> 
> The Cadence MACBs on PolarFire SoC (MPFS) have reset capability and are
> compatible with the zynqmp's init function. I have removed the zynqmp
> specific comments from that function & renamed it to reflect what it
> does, since it is no longer zynqmp only.
> 
> [...]

Here is the summary with links:
  - [net-next,v3,1/5] dt-bindings: net: cdns,macb: document polarfire soc's macb
    https://git.kernel.org/netdev/net-next/c/b09c6f8ff731
  - [net-next,v3,2/5] net: macb: add polarfire soc reset support
    https://git.kernel.org/netdev/net-next/c/8aad66aa59be
  - [net-next,v3,3/5] net: macb: unify macb_config alignment style
    https://git.kernel.org/netdev/net-next/c/649bef9c7663
  - [net-next,v3,4/5] net: macb: simplify error paths in init_reset_optional()
    https://git.kernel.org/netdev/net-next/c/ea242f821a2d
  - [net-next,v3,5/5] net: macb: sort init_reset_optional() with other init()s
    https://git.kernel.org/netdev/net-next/c/8a78ac73de20

You are awesome, thank you!