| Message ID | 20220718202843.6766-1-maukka@ext.kapsi.fi (mailing list archive) |
|---|---|
| Headers | show |
| Series | PCI: mvebu: add support for orion soc | expand |
On Mon, Jul 18, 2022 at 10:28 PM Mauri Sandberg <maukka@ext.kapsi.fi> wrote: > > Hello all! > > Working in close co-operation with Pali we made an initial attempt at bringing > support for orion PCIe into mvebu PCIe driver. Currently the address of > workaround memory range is hard coded and based on compatible string only. As > Pali describes in another thread, we were not able to figure out what's the > correct way to configure a configuration space. That discussion is here: > https://lore.kernel.org/linux-pci/20220710225108.bgedria6igtqpz5l@pali/T/#u > > I tested this with D-Link DNS-323 rev A1 and it's working. As usual, all > comments and feedback is welcome. Hi Mauri, I've managed to dig out my old series for reworking the orion5x PCI/PCIe support, to the point where the two drivers are completely independent. Please have a look at https://git.kernel.org/pub/scm/linux/kernel/git/arnd/playground.git/log/?h=orion-pci-cleanup to see if this helps you at all. I see now that your DNS-323 only supports PCIe but not PCI, so maybe it's not all that helpful for your machine, but it should help for converting the other ones that do use legacy PCI and want to base DT support on top of this work. Arnd
On Mon, Jul 18, 2022 at 11:28:40PM +0300, Mauri Sandberg wrote: > Hello all! > > Working in close co-operation with Pali we made an initial attempt at bringing > support for orion PCIe into mvebu PCIe driver. Currently the address of > workaround memory range is hard coded and based on compatible string only. As > Pali describes in another thread, we were not able to figure out what's the > correct way to configure a configuration space. That discussion is here: > https://lore.kernel.org/linux-pci/20220710225108.bgedria6igtqpz5l@pali/T/#u > > I tested this with D-Link DNS-323 rev A1 and it's working. As usual, all > comments and feedback is welcome. > > Thanks, > Mauri > > Mauri Sandberg (2): > dt-bindings: PCI: mvebu: Add orion5x compatible > PCI: mvebu: add support for orion5x > > .../devicetree/bindings/pci/mvebu-pci.txt | 1 + > arch/arm/mach-orion5x/common.c | 13 ---- > drivers/pci/controller/Kconfig | 2 +- > drivers/pci/controller/pci-mvebu.c | 59 +++++++++++++++++++ > 4 files changed, 61 insertions(+), 14 deletions(-) Hi Mauri, Can you address anything in 2/2 (if necessary), incorporate any acks, and post a v2? There was some confusion around the first patch (there are two in the thread, likely the same?), and I didn't read the 2/2 feedback in detail to see if any changes were needed. Bjorn
Hi Bjorn! On 29.07.22 20:22, Bjorn Helgaas wrote: > On Mon, Jul 18, 2022 at 11:28:40PM +0300, Mauri Sandberg wrote: >> Hello all! >> >> Working in close co-operation with Pali we made an initial attempt at bringing >> support for orion PCIe into mvebu PCIe driver. Currently the address of >> workaround memory range is hard coded and based on compatible string only. As >> Pali describes in another thread, we were not able to figure out what's the >> correct way to configure a configuration space. That discussion is here: >> https://lore.kernel.org/linux-pci/20220710225108.bgedria6igtqpz5l@pali/T/#u >> >> I tested this with D-Link DNS-323 rev A1 and it's working. As usual, all >> comments and feedback is welcome. >> >> Thanks, >> Mauri >> >> Mauri Sandberg (2): >> dt-bindings: PCI: mvebu: Add orion5x compatible >> PCI: mvebu: add support for orion5x >> >> .../devicetree/bindings/pci/mvebu-pci.txt | 1 + >> arch/arm/mach-orion5x/common.c | 13 ---- >> drivers/pci/controller/Kconfig | 2 +- >> drivers/pci/controller/pci-mvebu.c | 59 +++++++++++++++++++ >> 4 files changed, 61 insertions(+), 14 deletions(-) > > Hi Mauri, > > Can you address anything in 2/2 (if necessary), incorporate any acks, > and post a v2? There was some confusion around the first patch (there > are two in the thread, likely the same?), and I didn't read the 2/2 > feedback in detail to see if any changes were needed. > I give it a little bit time to see if the discussion on how to configure the configuration space would pick up, but I'll attend to the comments and post a clean v2 soonish.