| Message ID | 20220730103242.48612-1-mailmesebin00@gmail.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Jason Gunthorpe |
| Headers | show |
| Series | [-next] RDMA/mlx5: unchecked return value | expand |
On Sat, Jul 30, 2022 at 04:02:42PM +0530, Sebin Sebastian wrote: > Unchecked return value warning as reported by Coverity static analyzer > tool. check the return value of mlx5_ib_ft_type_to_namespace(). > > Signed-off-by: Sebin Sebastian <mailmesebin00@gmail.com> > --- > drivers/infiniband/hw/mlx5/fs.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) Thanks, I had similar patch in my internal queue. https://lore.kernel.org/linux-rdma/7b9ceda217d9368a51dc47a46b769bad4af9ac92.1659256069.git.leonro@nvidia.com/T/#u > > diff --git a/drivers/infiniband/hw/mlx5/fs.c b/drivers/infiniband/hw/mlx5/fs.c > index 691d00c89f33..617e0e9c0c8e 100644 > --- a/drivers/infiniband/hw/mlx5/fs.c > +++ b/drivers/infiniband/hw/mlx5/fs.c > @@ -2079,9 +2079,12 @@ static int mlx5_ib_matcher_ns(struct uverbs_attr_bundle *attrs, > return err; > > if (flags) { > - mlx5_ib_ft_type_to_namespace( > + err = mlx5_ib_ft_type_to_namespace( > MLX5_IB_UAPI_FLOW_TABLE_TYPE_NIC_TX, > &obj->ns_type); > + if (err) > + return err; > + > return 0; > } > } > -- > 2.34.1 >
On Sat, Jul 30, 2022 at 04:02:42PM +0530, Sebin Sebastian wrote: > Unchecked return value warning as reported by Coverity static analyzer > tool. check the return value of mlx5_ib_ft_type_to_namespace(). > > Signed-off-by: Sebin Sebastian <mailmesebin00@gmail.com> > --- > drivers/infiniband/hw/mlx5/fs.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) Leon's is cleaner and has a proper fixes line, so I will use his Thanks, Jason
diff --git a/drivers/infiniband/hw/mlx5/fs.c b/drivers/infiniband/hw/mlx5/fs.c index 691d00c89f33..617e0e9c0c8e 100644 --- a/drivers/infiniband/hw/mlx5/fs.c +++ b/drivers/infiniband/hw/mlx5/fs.c @@ -2079,9 +2079,12 @@ static int mlx5_ib_matcher_ns(struct uverbs_attr_bundle *attrs, return err; if (flags) { - mlx5_ib_ft_type_to_namespace( + err = mlx5_ib_ft_type_to_namespace( MLX5_IB_UAPI_FLOW_TABLE_TYPE_NIC_TX, &obj->ns_type); + if (err) + return err; + return 0; } }
Unchecked return value warning as reported by Coverity static analyzer tool. check the return value of mlx5_ib_ft_type_to_namespace(). Signed-off-by: Sebin Sebastian <mailmesebin00@gmail.com> --- drivers/infiniband/hw/mlx5/fs.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)