diff mbox series

net/rds: Use PTR_ERR instead of IS_ERR for rdsdebug()

Message ID 20220727150341.23746-1-liqiong@nfschina.com (mailing list archive)
State Not Applicable
Headers show
Series net/rds: Use PTR_ERR instead of IS_ERR for rdsdebug() | expand

Commit Message

Li Qiong July 27, 2022, 3:03 p.m. UTC 
If 'local_odp_mr->r_trans_private' is a error code,
it is better to print the error code than to print
the value of IS_ERR().

Signed-off-by: Li Qiong <liqiong@nfschina.com>
---
 net/rds/rdma.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

patchwork-bot+netdevbpf@kernel.org Aug. 1, 2022, 10:50 a.m. UTC | #1 
Hello:

This patch was applied to netdev/net.git (master)
by David S. Miller <davem@davemloft.net>:

On Wed, 27 Jul 2022 23:03:41 +0800 you wrote:
> If 'local_odp_mr->r_trans_private' is a error code,
> it is better to print the error code than to print
> the value of IS_ERR().
> 
> Signed-off-by: Li Qiong <liqiong@nfschina.com>
> ---
>  net/rds/rdma.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Here is the summary with links:
  - net/rds: Use PTR_ERR instead of IS_ERR for rdsdebug()
    https://git.kernel.org/netdev/net/c/5121db6afb99

You are awesome, thank you!
diff mbox series

Patch

diff --git a/net/rds/rdma.c b/net/rds/rdma.c
index 6f1a50d50d06..fba82d36593a 100644
--- a/net/rds/rdma.c
+++ b/net/rds/rdma.c
@@ -742,7 +742,7 @@  int rds_cmsg_rdma_args(struct rds_sock *rs, struct rds_message *rm,
 					NULL, 0, rs, &local_odp_mr->r_key, NULL,
 					iov->addr, iov->bytes, ODP_VIRTUAL);
 			if (IS_ERR(local_odp_mr->r_trans_private)) {
-				ret = IS_ERR(local_odp_mr->r_trans_private);
+				ret = PTR_ERR(local_odp_mr->r_trans_private);
 				rdsdebug("get_mr ret %d %p\"", ret,
 					 local_odp_mr->r_trans_private);
 				kfree(local_odp_mr);