| Message ID | YuenvTPwQj022P13@kili (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Lorenzo Pieralisi |
| Headers | show |
| Series | [1/2] NTB: EPF: Fix error code in epf_ntb_bind() | expand |
On Mon, Aug 1, 2022 at 3:45 PM Dan Carpenter <dan.carpenter@oracle.com> wrote: > > Return an error code if pci_register_driver() fails. Don't return > success. > > Fixes: da51fd247424 ("NTB: EPF: support NTB transfer between PCI RC and EP connection") > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Acked-by: Souptick Joarder (HPE) <jrdr.linux@gmail.com> > --- > drivers/pci/endpoint/functions/pci-epf-vntb.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/pci/endpoint/functions/pci-epf-vntb.c b/drivers/pci/endpoint/functions/pci-epf-vntb.c > index 111568089d45..cf338f3cf348 100644 > --- a/drivers/pci/endpoint/functions/pci-epf-vntb.c > +++ b/drivers/pci/endpoint/functions/pci-epf-vntb.c > @@ -1312,7 +1312,8 @@ static int epf_ntb_bind(struct pci_epf *epf) > > epf_set_drvdata(epf, ntb); > > - if (pci_register_driver(&vntb_pci_driver)) { > + ret = pci_register_driver(&vntb_pci_driver); > + if (ret) { > dev_err(dev, "failure register vntb pci driver\n"); > goto err_bar_alloc; > } > -- > 2.35.1 >
On Mon, Aug 01, 2022 at 01:15:25PM +0300, Dan Carpenter wrote: > Return an error code if pci_register_driver() fails. Don't return > success. > > Fixes: da51fd247424 ("NTB: EPF: support NTB transfer between PCI RC and EP connection") > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> > --- > drivers/pci/endpoint/functions/pci-epf-vntb.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/pci/endpoint/functions/pci-epf-vntb.c b/drivers/pci/endpoint/functions/pci-epf-vntb.c > index 111568089d45..cf338f3cf348 100644 > --- a/drivers/pci/endpoint/functions/pci-epf-vntb.c > +++ b/drivers/pci/endpoint/functions/pci-epf-vntb.c > @@ -1312,7 +1312,8 @@ static int epf_ntb_bind(struct pci_epf *epf) > > epf_set_drvdata(epf, ntb); > > - if (pci_register_driver(&vntb_pci_driver)) { > + ret = pci_register_driver(&vntb_pci_driver); > + if (ret) { > dev_err(dev, "failure register vntb pci driver\n"); > goto err_bar_alloc; > } > -- > 2.35.1 > Sorry for the delay in response. This series is in my ntb branch and will be in my pull request for v5.20 which should be going out later today. Thanks, Jon
diff --git a/drivers/pci/endpoint/functions/pci-epf-vntb.c b/drivers/pci/endpoint/functions/pci-epf-vntb.c index 111568089d45..cf338f3cf348 100644 --- a/drivers/pci/endpoint/functions/pci-epf-vntb.c +++ b/drivers/pci/endpoint/functions/pci-epf-vntb.c @@ -1312,7 +1312,8 @@ static int epf_ntb_bind(struct pci_epf *epf) epf_set_drvdata(epf, ntb); - if (pci_register_driver(&vntb_pci_driver)) { + ret = pci_register_driver(&vntb_pci_driver); + if (ret) { dev_err(dev, "failure register vntb pci driver\n"); goto err_bar_alloc; }
Return an error code if pci_register_driver() fails. Don't return success. Fixes: da51fd247424 ("NTB: EPF: support NTB transfer between PCI RC and EP connection") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> --- drivers/pci/endpoint/functions/pci-epf-vntb.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)