| Message ID | 20220815025006.48167-1-mie@igel.co.jp (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Lorenzo Pieralisi |
| Headers | show |
| Series | PCI: endpoint: fix Kconfig indent style | expand |
I have a question, not related to the patch. Could you please tell me why the ntb related patches are managed outside the pci branch, Helgaas's branch? It confused me a little to find the ntb branch. Thanks, Shunsuke 2022年8月15日(月) 11:50 Shunsuke Mie <mie@igel.co.jp>: > > Change to follow the Kconfig style guide. This patch fixes to use tab > rather than space to indent, while help text is indented an additional > two spaces. > > Fixes: e35f56bb0330 ("PCI: endpoint: Support NTB transfer between RC and EP") > Signed-off-by: Shunsuke Mie <mie@igel.co.jp> > --- > drivers/pci/endpoint/functions/Kconfig | 18 +++++++++--------- > 1 file changed, 9 insertions(+), 9 deletions(-) > > diff --git a/drivers/pci/endpoint/functions/Kconfig b/drivers/pci/endpoint/functions/Kconfig > index 295a033ee9a2..9fd560886871 100644 > --- a/drivers/pci/endpoint/functions/Kconfig > +++ b/drivers/pci/endpoint/functions/Kconfig > @@ -27,13 +27,13 @@ config PCI_EPF_NTB > If in doubt, say "N" to disable Endpoint NTB driver. > > config PCI_EPF_VNTB > - tristate "PCI Endpoint NTB driver" > - depends on PCI_ENDPOINT > - depends on NTB > - select CONFIGFS_FS > - help > - Select this configuration option to enable the Non-Transparent > - Bridge (NTB) driver for PCIe Endpoint. NTB driver implements NTB > - between PCI Root Port and PCIe Endpoint. > + tristate "PCI Endpoint NTB driver" > + depends on PCI_ENDPOINT > + depends on NTB > + select CONFIGFS_FS > + help > + Select this configuration option to enable the Non-Transparent > + Bridge (NTB) driver for PCIe Endpoint. NTB driver implements NTB > + between PCI Root Port and PCIe Endpoint. > > - If in doubt, say "N" to disable Endpoint NTB driver. > + If in doubt, say "N" to disable Endpoint NTB driver. > -- > 2.17.1 >
On Mon, Aug 15, 2022 at 12:00:23PM +0900, Shunsuke Mie wrote: > I have a question, not related to the patch. Could you please tell me > why the ntb related patches are managed outside the pci branch, > Helgaas's branch? It confused me a little to find the ntb branch. My understanding is that the recent drivers/pci/endpoint/functions/*ntb.c patches were merged by Jon because they had dependencies on other patches in his tree. In the future, I think most NTB-related patches in drivers/pci/ will be merged via my PCI tree. Bjorn
On Mon, Aug 15, 2022 at 11:50:06AM +0900, Shunsuke Mie wrote: > Change to follow the Kconfig style guide. This patch fixes to use tab > rather than space to indent, while help text is indented an additional > two spaces. > > Fixes: e35f56bb0330 ("PCI: endpoint: Support NTB transfer between RC and EP") > Signed-off-by: Shunsuke Mie <mie@igel.co.jp> Thanks for doing this. In the future make the subject line match the history, e.g., $ git log --oneline drivers/pci/endpoint/functions/Kconfig 556a2c7dca33 ("PCI: endpoint: Fix Kconfig dependency") e35f56bb0330 ("PCI: endpoint: Support NTB transfer between RC and EP") 8b821cf76150 ("PCI: endpoint: Add EP function driver to provide NTB functionality") 98dbf5af4fdd ("PCI: endpoint: Select CRC32 to fix test build error") 349e7a85b25f ("PCI: endpoint: functions: Add an EP function to test PCI") Note that these are all capitalized ("Fix Kconfig indent style"). Lorenzo will likely fix this up when applying, so no need to repost for this. > --- > drivers/pci/endpoint/functions/Kconfig | 18 +++++++++--------- > 1 file changed, 9 insertions(+), 9 deletions(-) > > diff --git a/drivers/pci/endpoint/functions/Kconfig b/drivers/pci/endpoint/functions/Kconfig > index 295a033ee9a2..9fd560886871 100644 > --- a/drivers/pci/endpoint/functions/Kconfig > +++ b/drivers/pci/endpoint/functions/Kconfig > @@ -27,13 +27,13 @@ config PCI_EPF_NTB > If in doubt, say "N" to disable Endpoint NTB driver. > > config PCI_EPF_VNTB > - tristate "PCI Endpoint NTB driver" > - depends on PCI_ENDPOINT > - depends on NTB > - select CONFIGFS_FS > - help > - Select this configuration option to enable the Non-Transparent > - Bridge (NTB) driver for PCIe Endpoint. NTB driver implements NTB > - between PCI Root Port and PCIe Endpoint. > + tristate "PCI Endpoint NTB driver" > + depends on PCI_ENDPOINT > + depends on NTB > + select CONFIGFS_FS > + help > + Select this configuration option to enable the Non-Transparent > + Bridge (NTB) driver for PCIe Endpoint. NTB driver implements NTB > + between PCI Root Port and PCIe Endpoint. > > - If in doubt, say "N" to disable Endpoint NTB driver. > + If in doubt, say "N" to disable Endpoint NTB driver. > -- > 2.17.1 >
Hi Bjom, 2022年8月16日(火) 3:39 Bjorn Helgaas <helgaas@kernel.org>: > > On Mon, Aug 15, 2022 at 12:00:23PM +0900, Shunsuke Mie wrote: > > I have a question, not related to the patch. Could you please tell me > > why the ntb related patches are managed outside the pci branch, > > Helgaas's branch? It confused me a little to find the ntb branch. > > My understanding is that the recent drivers/pci/endpoint/functions/*ntb.c > patches were merged by Jon because they had dependencies on other > patches in his tree. That makes sense. > In the future, I think most NTB-related patches in drivers/pci/ will > be merged via my PCI tree. > > Bjorn Thanks, Shunsuke
Hi Lorenzo, 2022年8月16日(火) 3:41 Bjorn Helgaas <helgaas@kernel.org>: > > On Mon, Aug 15, 2022 at 11:50:06AM +0900, Shunsuke Mie wrote: > > Change to follow the Kconfig style guide. This patch fixes to use tab > > rather than space to indent, while help text is indented an additional > > two spaces. > > > > Fixes: e35f56bb0330 ("PCI: endpoint: Support NTB transfer between RC and EP") > > Signed-off-by: Shunsuke Mie <mie@igel.co.jp> > > Thanks for doing this. In the future make the subject line match the > history, e.g., > > $ git log --oneline drivers/pci/endpoint/functions/Kconfig > 556a2c7dca33 ("PCI: endpoint: Fix Kconfig dependency") > e35f56bb0330 ("PCI: endpoint: Support NTB transfer between RC and EP") > 8b821cf76150 ("PCI: endpoint: Add EP function driver to provide NTB functionality") > 98dbf5af4fdd ("PCI: endpoint: Select CRC32 to fix test build error") > 349e7a85b25f ("PCI: endpoint: functions: Add an EP function to test PCI") > > Note that these are all capitalized ("Fix Kconfig indent style"). > > Lorenzo will likely fix this up when applying, so no need to repost > for this. This is a gentle ping. > > > --- > > drivers/pci/endpoint/functions/Kconfig | 18 +++++++++--------- > > 1 file changed, 9 insertions(+), 9 deletions(-) > > > > diff --git a/drivers/pci/endpoint/functions/Kconfig b/drivers/pci/endpoint/functions/Kconfig > > index 295a033ee9a2..9fd560886871 100644 > > --- a/drivers/pci/endpoint/functions/Kconfig > > +++ b/drivers/pci/endpoint/functions/Kconfig > > @@ -27,13 +27,13 @@ config PCI_EPF_NTB > > If in doubt, say "N" to disable Endpoint NTB driver. > > > > config PCI_EPF_VNTB > > - tristate "PCI Endpoint NTB driver" > > - depends on PCI_ENDPOINT > > - depends on NTB > > - select CONFIGFS_FS > > - help > > - Select this configuration option to enable the Non-Transparent > > - Bridge (NTB) driver for PCIe Endpoint. NTB driver implements NTB > > - between PCI Root Port and PCIe Endpoint. > > + tristate "PCI Endpoint NTB driver" > > + depends on PCI_ENDPOINT > > + depends on NTB > > + select CONFIGFS_FS > > + help > > + Select this configuration option to enable the Non-Transparent > > + Bridge (NTB) driver for PCIe Endpoint. NTB driver implements NTB > > + between PCI Root Port and PCIe Endpoint. > > > > - If in doubt, say "N" to disable Endpoint NTB driver. > > + If in doubt, say "N" to disable Endpoint NTB driver. > > -- > > 2.17.1 > > thanks, Shunsuke
On Mon, 15 Aug 2022 11:50:06 +0900, Shunsuke Mie wrote: > Change to follow the Kconfig style guide. This patch fixes to use tab > rather than space to indent, while help text is indented an additional > two spaces. > > Applied to pci/misc, thanks! [1/1] PCI: endpoint: fix Kconfig indent style https://git.kernel.org/lpieralisi/pci/c/2759ddf7535d Thanks, Lorenzo
diff --git a/drivers/pci/endpoint/functions/Kconfig b/drivers/pci/endpoint/functions/Kconfig index 295a033ee9a2..9fd560886871 100644 --- a/drivers/pci/endpoint/functions/Kconfig +++ b/drivers/pci/endpoint/functions/Kconfig @@ -27,13 +27,13 @@ config PCI_EPF_NTB If in doubt, say "N" to disable Endpoint NTB driver. config PCI_EPF_VNTB - tristate "PCI Endpoint NTB driver" - depends on PCI_ENDPOINT - depends on NTB - select CONFIGFS_FS - help - Select this configuration option to enable the Non-Transparent - Bridge (NTB) driver for PCIe Endpoint. NTB driver implements NTB - between PCI Root Port and PCIe Endpoint. + tristate "PCI Endpoint NTB driver" + depends on PCI_ENDPOINT + depends on NTB + select CONFIGFS_FS + help + Select this configuration option to enable the Non-Transparent + Bridge (NTB) driver for PCIe Endpoint. NTB driver implements NTB + between PCI Root Port and PCIe Endpoint. - If in doubt, say "N" to disable Endpoint NTB driver. + If in doubt, say "N" to disable Endpoint NTB driver.
Change to follow the Kconfig style guide. This patch fixes to use tab rather than space to indent, while help text is indented an additional two spaces. Fixes: e35f56bb0330 ("PCI: endpoint: Support NTB transfer between RC and EP") Signed-off-by: Shunsuke Mie <mie@igel.co.jp> --- drivers/pci/endpoint/functions/Kconfig | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-)