| Message ID | 20220829111643.266866-1-cui.jinpeng2@zte.com.cn (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | [linux-next] wifi: cfg80211: remove redundant ret variable | expand |
On Mon, Aug 29, 2022 at 6:35 PM <cgel.zte@gmail.com> wrote: > From: Jinpeng Cui <cui.jinpeng2@zte.com.cn> > > Return value from cfg80211_rx_mgmt() directly instead of > taking this in another redundant variable. > > Reported-by: Zeal Robot <zealci@zte.com.cn> > Signed-off-by: Jinpeng Cui <cui.jinpeng2@zte.com.cn> Reviewed-by: Ammar Faizi <ammarfaizi2@gnuweeb.org>
cgel.zte@gmail.com writes: > From: Jinpeng Cui <cui.jinpeng2@zte.com.cn> > > Return value from cfg80211_rx_mgmt() directly instead of > taking this in another redundant variable. > > Reported-by: Zeal Robot <zealci@zte.com.cn> > Signed-off-by: Jinpeng Cui <cui.jinpeng2@zte.com.cn> > --- > drivers/net/wireless/microchip/wilc1000/cfg80211.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) The title should be: wifi: wilc1000: remove redundant ret variable Please read our documentation: https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#commit_title_is_wrong
diff --git a/drivers/net/wireless/microchip/wilc1000/cfg80211.c b/drivers/net/wireless/microchip/wilc1000/cfg80211.c index f810a56a7ff0..b89047965e78 100644 --- a/drivers/net/wireless/microchip/wilc1000/cfg80211.c +++ b/drivers/net/wireless/microchip/wilc1000/cfg80211.c @@ -997,12 +997,11 @@ bool wilc_wfi_mgmt_frame_rx(struct wilc_vif *vif, u8 *buff, u32 size) { struct wilc *wl = vif->wilc; struct wilc_priv *priv = &vif->priv; - int freq, ret; + int freq; freq = ieee80211_channel_to_frequency(wl->op_ch, NL80211_BAND_2GHZ); - ret = cfg80211_rx_mgmt(&priv->wdev, freq, 0, buff, size, 0); - return ret; + return cfg80211_rx_mgmt(&priv->wdev, freq, 0, buff, size, 0); } void wilc_wfi_p2p_rx(struct wilc_vif *vif, u8 *buff, u32 size)