| Message ID | 20220829111256.21923-1-liqiong@nfschina.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | [v2] wifi: brcmfmac: add error code in brcmf_notify_sched_scan_results() | expand |
Li Qiong <liqiong@nfschina.com> wrote: > The err code is 0 at the first two "out_err" paths, add error code > '-EINVAL' for these error paths. > > Signed-off-by: Li Qiong <liqiong@nfschina.com> Arend already commented v1: https://lore.kernel.org/netdev/a054ffb1-527b-836c-f43e-9f76058cc9ed@gmail.com/ Patch set to Changes Requested.
diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c index db45da33adfd..b965649bb0e4 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c @@ -3553,6 +3553,7 @@ brcmf_notify_sched_scan_results(struct brcmf_if *ifp, WARN_ON(status != BRCMF_PNO_SCAN_COMPLETE); brcmf_dbg(SCAN, "PFN NET FOUND event. count: %d\n", result_count); if (!result_count) { + err = -EINVAL; bphy_err(drvr, "FALSE PNO Event. (pfn_count == 0)\n"); goto out_err; } @@ -3560,6 +3561,7 @@ brcmf_notify_sched_scan_results(struct brcmf_if *ifp, netinfo_start = brcmf_get_netinfo_array(pfn_result); datalen = e->datalen - ((void *)netinfo_start - (void *)pfn_result); if (datalen < result_count * sizeof(*netinfo)) { + err = -EINVAL; bphy_err(drvr, "insufficient event data\n"); goto out_err; }
The err code is 0 at the first two "out_err" paths, add error code '-EINVAL' for these error paths. Signed-off-by: Li Qiong <liqiong@nfschina.com> --- v1->v2: - Modify subject. - Resend patch and CC to linux-wireless. --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c | 2 ++ 1 file changed, 2 insertions(+)