mbox series

[v1,0/4] drm/i915: Improvements to stolen memory setup

Message ID 20220915-stolen-v1-0-117c5f295bb2@intel.com (mailing list archive)
Headers show
Series drm/i915: Improvements to stolen memory setup | expand

Message

Lucas De Marchi Sept. 15, 2022, 8:39 p.m. UTC
Better split, document, and make the code paths for integrated and discrete
more similar.

Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>

---
Lucas De Marchi (4):
      drm/i915: Move dsm assignment to be after adjustment
      drm/i915: Add missing mask when reading GEN12_DSMBASE
      drm/i915: Split i915_gem_init_stolen()
      drm/i915/dgfx: Make failure to setup stolen non-fatal

 drivers/gpu/drm/i915/gem/i915_gem_stolen.c | 189 ++++++++++++++++-------------
 drivers/gpu/drm/i915/i915_reg.h            |   1 +
 2 files changed, 109 insertions(+), 81 deletions(-)
---
base-commit: bb4f6b2281b11b009210f62eecd291f7b75c1e85
change-id: 20220915-stolen-7aa0e407368f

Best regards,

Comments

Lucas De Marchi Sept. 15, 2022, 9:54 p.m. UTC | #1
On Thu, Sep 15, 2022 at 09:18:39PM +0000, Patchwork wrote:
>== Series Details ==
>
>Series: drm/i915: Improvements to stolen memory setup
>URL   : https://patchwork.freedesktop.org/series/108620/
>State : failure
>
>== Summary ==
>
>CI Bug Log - changes from CI_DRM_12143 -> Patchwork_108620v1
>====================================================
>
>Summary
>-------
>
>  **FAILURE**
>
>  Serious unknown changes coming with Patchwork_108620v1 absolutely need to be
>  verified manually.
>
>  If you think the reported changes have nothing to do with the changes
>  introduced in Patchwork_108620v1, please notify your bug team to allow them
>  to document this new failure mode, which will reduce false positives in CI.
>
>  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108620v1/index.html
>
>Participating hosts (42 -> 40)
>------------------------------
>
>  Additional (2): fi-rkl-11600 bat-dg2-9
>  Missing    (4): fi-kbl-soraka fi-ctg-p8600 fi-hsw-4200u fi-tgl-u2
>
>Possible new issues
>-------------------
>
>  Here are the unknown changes that may have been introduced in Patchwork_108620v1:
>
>### IGT changes ###
>
>#### Possible regressions ####
>
>  * igt@i915_selftest@live@gt_engines:
>    - fi-ilk-650:         [PASS][1] -> [DMESG-WARN][2] +40 similar issues
>   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12143/fi-ilk-650/igt@i915_selftest@live@gt_engines.html
>   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108620v1/fi-ilk-650/igt@i915_selftest@live@gt_engines.html

ha, thanks

<7> [175.357162] i915 0000:00:02.0: [drm:i915_gem_init_stolen [i915]] ELK_STOLEN_RESERVED = 00000000
<3> [175.357332] i915 0000:00:02.0: [drm] *ERROR* inconsistent reservation 0x00000000e0000000 + 0x0000000000000000; ignoring

looks like I screwed somewhere for the older platforms.

>
>  * igt@i915_selftest@live@guc_multi_lrc:
>    - fi-snb-2600:        [PASS][3] -> [DMESG-WARN][4] +40 similar issues
>   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12143/fi-snb-2600/igt@i915_selftest@live@guc_multi_lrc.html
>   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108620v1/fi-snb-2600/igt@i915_selftest@live@guc_multi_lrc.html
>
>  * igt@i915_selftest@live@reset:
>    - fi-snb-2520m:       [PASS][5] -> [DMESG-WARN][6] +40 similar issues
>   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12143/fi-snb-2520m/igt@i915_selftest@live@reset.html
>   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108620v1/fi-snb-2520m/igt@i915_selftest@live@reset.html

/me procures a ilk and snb for proper test next.

Lucas De Marchi

>
>
>#### Suppressed ####
>
>  The following results come from untrusted machines, tests, or statuses.
>  They do not affect the overall result.
>
>  * igt@fbdev@read:
>    - {fi-tgl-mst}:       [PASS][7] -> [FAIL][8]
>   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12143/fi-tgl-mst/igt@fbdev@read.html
>   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108620v1/fi-tgl-mst/igt@fbdev@read.html
>
>  * igt@gem_exec_suspend@basic-s0@smem:
>    - {fi-tgl-mst}:       [DMESG-WARN][9] ([i915#5122]) -> [DMESG-WARN][10]
>   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12143/fi-tgl-mst/igt@gem_exec_suspend@basic-s0@smem.html
>   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108620v1/fi-tgl-mst/igt@gem_exec_suspend@basic-s0@smem.html
>
>
>New tests
>---------
>
>  New tests have been introduced between CI_DRM_12143 and Patchwork_108620v1:
>
>### New IGT tests (1) ###
>
>  * igt@kms_pipe_crc_basic@suspend-read-crc@pipe-b-dp-7:
>    - Statuses : 1 pass(s)
>    - Exec time: [3.68] s
>
>
>
>Known issues
>------------
>
>  Here are the changes found in Patchwork_108620v1 that come from known issues:
>
>### IGT changes ###
>
>#### Issues hit ####
>
>  * igt@gem_huc_copy@huc-copy:
>    - fi-rkl-11600:       NOTRUN -> [SKIP][11] ([i915#2190])
>   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108620v1/fi-rkl-11600/igt@gem_huc_copy@huc-copy.html
>
>  * igt@gem_lmem_swapping@basic:
>    - fi-rkl-11600:       NOTRUN -> [SKIP][12] ([i915#4613]) +3 similar issues
>   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108620v1/fi-rkl-11600/igt@gem_lmem_swapping@basic.html
>
>  * igt@gem_tiled_pread_basic:
>    - fi-rkl-11600:       NOTRUN -> [SKIP][13] ([i915#3282])
>   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108620v1/fi-rkl-11600/igt@gem_tiled_pread_basic.html
>
>  * igt@i915_pm_backlight@basic-brightness:
>    - fi-rkl-11600:       NOTRUN -> [SKIP][14] ([i915#3012])
>   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108620v1/fi-rkl-11600/igt@i915_pm_backlight@basic-brightness.html
>
>  * igt@i915_selftest@live@client:
>    - fi-elk-e7500:       [PASS][15] -> [DMESG-WARN][16] ([i915#6836]) +40 similar issues
>   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12143/fi-elk-e7500/igt@i915_selftest@live@client.html
>   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108620v1/fi-elk-e7500/igt@i915_selftest@live@client.html
>
>  * igt@i915_selftest@live@gem:
>    - fi-blb-e6850:       [PASS][17] -> [DMESG-FAIL][18] ([i915#4528])
>   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12143/fi-blb-e6850/igt@i915_selftest@live@gem.html
>   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108620v1/fi-blb-e6850/igt@i915_selftest@live@gem.html
>
>  * igt@i915_suspend@basic-s3-without-i915:
>    - fi-rkl-11600:       NOTRUN -> [INCOMPLETE][19] ([i915#5982])
>   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108620v1/fi-rkl-11600/igt@i915_suspend@basic-s3-without-i915.html
>
>  * igt@kms_chamelium@hdmi-edid-read:
>    - fi-rkl-11600:       NOTRUN -> [SKIP][20] ([fdo#111827]) +7 similar issues
>   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108620v1/fi-rkl-11600/igt@kms_chamelium@hdmi-edid-read.html
>
>  * igt@kms_cursor_legacy@basic-busy-flip-before-cursor:
>    - fi-rkl-11600:       NOTRUN -> [SKIP][21] ([i915#4103])
>   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108620v1/fi-rkl-11600/igt@kms_cursor_legacy@basic-busy-flip-before-cursor.html
>
>  * igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions:
>    - fi-bsw-kefka:       [PASS][22] -> [FAIL][23] ([i915#6298])
>   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12143/fi-bsw-kefka/igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions.html
>   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108620v1/fi-bsw-kefka/igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions.html
>
>  * igt@kms_force_connector_basic@force-load-detect:
>    - fi-rkl-11600:       NOTRUN -> [SKIP][24] ([fdo#109285] / [i915#4098])
>   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108620v1/fi-rkl-11600/igt@kms_force_connector_basic@force-load-detect.html
>
>  * igt@kms_pipe_crc_basic@suspend-read-crc:
>    - fi-ivb-3770:        NOTRUN -> [SKIP][25] ([fdo#109271])
>   [25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108620v1/fi-ivb-3770/igt@kms_pipe_crc_basic@suspend-read-crc.html
>
>  * igt@kms_psr@primary_page_flip:
>    - fi-rkl-11600:       NOTRUN -> [SKIP][26] ([i915#1072]) +3 similar issues
>   [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108620v1/fi-rkl-11600/igt@kms_psr@primary_page_flip.html
>
>  * igt@kms_setmode@basic-clone-single-crtc:
>    - fi-rkl-11600:       NOTRUN -> [SKIP][27] ([i915#3555] / [i915#4098])
>   [27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108620v1/fi-rkl-11600/igt@kms_setmode@basic-clone-single-crtc.html
>
>  * igt@prime_vgem@basic-read:
>    - fi-rkl-11600:       NOTRUN -> [SKIP][28] ([fdo#109295] / [i915#3291] / [i915#3708]) +2 similar issues
>   [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108620v1/fi-rkl-11600/igt@prime_vgem@basic-read.html
>
>  * igt@prime_vgem@basic-userptr:
>    - fi-rkl-11600:       NOTRUN -> [SKIP][29] ([fdo#109295] / [i915#3301] / [i915#3708])
>   [29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108620v1/fi-rkl-11600/igt@prime_vgem@basic-userptr.html
>
>  * igt@runner@aborted:
>    - fi-blb-e6850:       NOTRUN -> [FAIL][30] ([fdo#109271] / [i915#2403] / [i915#4312])
>   [30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108620v1/fi-blb-e6850/igt@runner@aborted.html
>    - fi-bdw-5557u:       NOTRUN -> [FAIL][31] ([i915#4312])
>   [31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108620v1/fi-bdw-5557u/igt@runner@aborted.html
>
>
>  {name}: This element is suppressed. This means it is ignored when computing
>          the status of the difference (SUCCESS, WARNING, or FAILURE).
>
>  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
>  [fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
>  [fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
>  [fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
>  [i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
>  [i915#1155]: https://gitlab.freedesktop.org/drm/intel/issues/1155
>  [i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
>  [i915#2403]: https://gitlab.freedesktop.org/drm/intel/issues/2403
>  [i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
>  [i915#3012]: https://gitlab.freedesktop.org/drm/intel/issues/3012
>  [i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
>  [i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291
>  [i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301
>  [i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
>  [i915#3595]: https://gitlab.freedesktop.org/drm/intel/issues/3595
>  [i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
>  [i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
>  [i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
>  [i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
>  [i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
>  [i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
>  [i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212
>  [i915#4213]: https://gitlab.freedesktop.org/drm/intel/issues/4213
>  [i915#4215]: https://gitlab.freedesktop.org/drm/intel/issues/4215
>  [i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
>  [i915#4528]: https://gitlab.freedesktop.org/drm/intel/issues/4528
>  [i915#4579]: https://gitlab.freedesktop.org/drm/intel/issues/4579
>  [i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
>  [i915#4873]: https://gitlab.freedesktop.org/drm/intel/issues/4873
>  [i915#5122]: https://gitlab.freedesktop.org/drm/intel/issues/5122
>  [i915#5190]: https://gitlab.freedesktop.org/drm/intel/issues/5190
>  [i915#5274]: https://gitlab.freedesktop.org/drm/intel/issues/5274
>  [i915#5982]: https://gitlab.freedesktop.org/drm/intel/issues/5982
>  [i915#6298]: https://gitlab.freedesktop.org/drm/intel/issues/6298
>  [i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367
>  [i915#6621]: https://gitlab.freedesktop.org/drm/intel/issues/6621
>  [i915#6836]: https://gitlab.freedesktop.org/drm/intel/issues/6836
>
>
>Build changes
>-------------
>
>  * Linux: CI_DRM_12143 -> Patchwork_108620v1
>
>  CI-20190529: 20190529
>  CI_DRM_12143: bb4f6b2281b11b009210f62eecd291f7b75c1e85 @ git://anongit.freedesktop.org/gfx-ci/linux
>  IGT_6656: 24100c4e181c50e3678aeca9c641b8a43555ad73 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
>  Patchwork_108620v1: bb4f6b2281b11b009210f62eecd291f7b75c1e85 @ git://anongit.freedesktop.org/gfx-ci/linux
>
>
>### Linux commits
>
>d9b4c33384c5 drm/i915/dgfx: Make failure to setup stolen non-fatal
>fc192e2c02b6 drm/i915: Split i915_gem_init_stolen()
>f2b6dafac523 drm/i915: Add missing mask when reading GEN12_DSMBASE
>e22a03ddc301 drm/i915: Move dsm assignment to be after adjustment
>
>== Logs ==
>
>For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108620v1/index.html