| Message ID | 20220919231720.163121-3-shentey@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Deprecate sysbus_get_default() and get_system_memory() et. al | expand |
On 20/9/22 01:17, Bernhard Beschow wrote: > The next commit would not compile w/o the include directive. > > Signed-off-by: Bernhard Beschow <shentey@gmail.com> > --- > include/exec/hwaddr.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/include/exec/hwaddr.h b/include/exec/hwaddr.h > index 8f16d179a8..616255317c 100644 > --- a/include/exec/hwaddr.h > +++ b/include/exec/hwaddr.h > @@ -3,6 +3,7 @@ > #ifndef HWADDR_H > #define HWADDR_H > > +#include "qemu/osdep.h" NAck: This is an anti-pattern. "qemu/osdep.h" must not be included in .h, only in .c. Isn't including "hw/qdev-core.h" in "include/hw/boards.h" enough in the next patch?
Am 20. September 2022 04:50:51 UTC schrieb "Philippe Mathieu-Daudé" <f4bug@amsat.org>: >On 20/9/22 01:17, Bernhard Beschow wrote: >> The next commit would not compile w/o the include directive. >> >> Signed-off-by: Bernhard Beschow <shentey@gmail.com> >> --- >> include/exec/hwaddr.h | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/include/exec/hwaddr.h b/include/exec/hwaddr.h >> index 8f16d179a8..616255317c 100644 >> --- a/include/exec/hwaddr.h >> +++ b/include/exec/hwaddr.h >> @@ -3,6 +3,7 @@ >> #ifndef HWADDR_H >> #define HWADDR_H >> +#include "qemu/osdep.h" > >NAck: This is an anti-pattern. "qemu/osdep.h" must not be included >in .h, only in .c. > >Isn't including "hw/qdev-core.h" in "include/hw/boards.h" enough in >the next patch? Yes, this works just fine indeed! This patch could be dropped if in the next iteration, if any. Thanks, Bernhard
diff --git a/include/exec/hwaddr.h b/include/exec/hwaddr.h index 8f16d179a8..616255317c 100644 --- a/include/exec/hwaddr.h +++ b/include/exec/hwaddr.h @@ -3,6 +3,7 @@ #ifndef HWADDR_H #define HWADDR_H +#include "qemu/osdep.h" #define HWADDR_BITS 64 /* hwaddr is the type of a physical address (its size can
The next commit would not compile w/o the include directive. Signed-off-by: Bernhard Beschow <shentey@gmail.com> --- include/exec/hwaddr.h | 1 + 1 file changed, 1 insertion(+)