| Message ID | 20220921140524.3831101-18-yangyingliang@huawei.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 774b060debb189cb778fc195395dd24ea67bef5b |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | net: dsa: remove unnecessary set_drvdata() | expand |
On Wed, Sep 21, 2022 at 3:58 PM Yang Yingliang <yangyingliang@huawei.com> wrote: > Remove unnecessary set_drvdata(NULL) function in ->remove(), > the driver_data will be set to NULL in device_unbind_cleanup() > after calling ->remove(). > > Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> Acked-by: Linus Walleij <linus.walleij@linaro.org> Yours, Linus Walleij
diff --git a/drivers/net/dsa/vitesse-vsc73xx-platform.c b/drivers/net/dsa/vitesse-vsc73xx-platform.c index fe4b154a0a57..bd4206e8f9af 100644 --- a/drivers/net/dsa/vitesse-vsc73xx-platform.c +++ b/drivers/net/dsa/vitesse-vsc73xx-platform.c @@ -121,8 +121,6 @@ static int vsc73xx_platform_remove(struct platform_device *pdev) vsc73xx_remove(&vsc_platform->vsc); - platform_set_drvdata(pdev, NULL); - return 0; } diff --git a/drivers/net/dsa/vitesse-vsc73xx-spi.c b/drivers/net/dsa/vitesse-vsc73xx-spi.c index 97a92e6da60d..85b9a0f51dd8 100644 --- a/drivers/net/dsa/vitesse-vsc73xx-spi.c +++ b/drivers/net/dsa/vitesse-vsc73xx-spi.c @@ -167,8 +167,6 @@ static void vsc73xx_spi_remove(struct spi_device *spi) return; vsc73xx_remove(&vsc_spi->vsc); - - spi_set_drvdata(spi, NULL); } static void vsc73xx_spi_shutdown(struct spi_device *spi)
Remove unnecessary set_drvdata(NULL) function in ->remove(), the driver_data will be set to NULL in device_unbind_cleanup() after calling ->remove(). Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> --- drivers/net/dsa/vitesse-vsc73xx-platform.c | 2 -- drivers/net/dsa/vitesse-vsc73xx-spi.c | 2 -- 2 files changed, 4 deletions(-)