diff mbox series

[-next] RDMA/mana_ib: change mana_ib_dev_ops to static

Message ID 20220923144809.108030-1-yangyingliang@huawei.com (mailing list archive)
State Not Applicable
Headers show
Series [-next] RDMA/mana_ib: change mana_ib_dev_ops to static | expand

Commit Message

Yang Yingliang Sept. 23, 2022, 2:48 p.m. UTC
mana_ib_dev_ops is only used in device.c now, change it
to static.

Fixes: 6dce3468a04c ("RDMA/mana_ib: Add a driver for Microsoft Azure Network Adapter")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
 drivers/infiniband/hw/mana/device.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Jason Gunthorpe Sept. 23, 2022, 2:43 p.m. UTC | #1
On Fri, Sep 23, 2022 at 10:48:09PM +0800, Yang Yingliang wrote:
> mana_ib_dev_ops is only used in device.c now, change it
> to static.
> 
> Fixes: 6dce3468a04c ("RDMA/mana_ib: Add a driver for Microsoft Azure Network Adapter")
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> ---
>  drivers/infiniband/hw/mana/device.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Microsoft folks, you need to squash these sorts of patches into the
next version of your series and repost it after a few weeks. You will
probably get a few

Jason
Long Li Sept. 23, 2022, 6:08 p.m. UTC | #2
> Subject: Re: [PATCH -next] RDMA/mana_ib: change mana_ib_dev_ops to
> static
> 
> On Fri, Sep 23, 2022 at 10:48:09PM +0800, Yang Yingliang wrote:
> > mana_ib_dev_ops is only used in device.c now, change it to static.
> >
> > Fixes: 6dce3468a04c ("RDMA/mana_ib: Add a driver for Microsoft Azure
> > Network Adapter")
> > Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> > ---
> >  drivers/infiniband/hw/mana/device.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Microsoft folks, you need to squash these sorts of patches into the next
> version of your series and repost it after a few weeks. You will probably get a
> few
> 
> Jason

Thank you, will do.

Long
diff mbox series

Patch

diff --git a/drivers/infiniband/hw/mana/device.c b/drivers/infiniband/hw/mana/device.c
index c0a5a37583ff..4724af751f33 100644
--- a/drivers/infiniband/hw/mana/device.c
+++ b/drivers/infiniband/hw/mana/device.c
@@ -10,7 +10,7 @@  MODULE_DESCRIPTION("Microsoft Azure Network Adapter IB driver");
 MODULE_LICENSE("GPL");
 MODULE_IMPORT_NS(NET_MANA);
 
-const struct ib_device_ops mana_ib_dev_ops = {
+static const struct ib_device_ops mana_ib_dev_ops = {
 	.owner = THIS_MODULE,
 	.driver_id = RDMA_DRIVER_MANA,
 	.uverbs_abi_ver = MANA_IB_UVERBS_ABI_VERSION,