| Message ID | 20221017091201.199457-1-prabhakar.mahadev-lad.rj@bp.renesas.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | RZ/G2UL separate out SoC specific parts | expand |
On Mon, Oct 17, 2022 at 10:11:59AM +0100, Prabhakar wrote: > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > Hi All, > > This patch series aims to split up the RZ/G2UL SoC DTSI into common parts > so that this can be shared with the RZ/Five SoC. > > Implementation is based on the discussion [0] where I have used option#2. > > The Renesas RZ/G2UL (ARM64) and RZ/Five (RISC-V) have almost the same > identical blocks to avoid duplication a base SoC dtsi (r9a07g043.dtsi) is > created which will be used by the RZ/G2UL (r9a07g043u.dtsi) and RZ/Five > (r9a07g043F.dtsi) > > Sending this as an RFC to get some feedback. > > r9a07g043f.dtsi will look something like below: > > #include <dt-bindings/interrupt-controller/irq.h> > > #define SOC_PERIPHERAL_IRQ_NUMBER(nr) (nr + 32) > #define SOC_PERIPHERAL_IRQ(nr, na) SOC_PERIPHERAL_IRQ_NUMBER(nr) na It appears there's little interest in this conversation from a DT or an arch/soc maintainer PoV so far. I for one think this stuff is grand & better than duplicating the dts between archs. I know Geert likes the macros in theory, but I wonder what he thinks of the implemenation? Arnd, do you perhaps have an opinion? Thanks, Conor. > > #include <arm64/renesas/r9a07g043.dtsi> > > / { > ... > ... > }; > > Although patch#2 can be merged into patch#1 just wanted to keep them separated > for easier review. > > RFC-> RESEND RFC > * Patches rebased on [1] > > RFC: [2] > > [0] https://lore.kernel.org/linux-arm-kernel/Yyt8s5+pyoysVNeC@spud/T/ > [1] https://patchwork.kernel.org/project/linux-renesas-soc/cover/20221009230044.10961-1-prabhakar.mahadev-lad.rj@bp.renesas.com/ > [2] https://patchwork.kernel.org/project/linux-renesas-soc/cover/20220929172356.301342-1-prabhakar.mahadev-lad.rj@bp.renesas.com/ > > Cheers, > Prabhakar > > Lad Prabhakar (2): > arm64: dts: renesas: r9a07g043: Introduce SOC_PERIPHERAL_IRQ() macro > to specify interrupt property > arm64: dts: renesas: r9a07g043: Split out RZ/G2UL SoC specific parts > > arch/arm64/boot/dts/renesas/r9a07g043.dtsi | 347 ++++++++---------- > arch/arm64/boot/dts/renesas/r9a07g043u.dtsi | 72 ++++ > .../boot/dts/renesas/r9a07g043u11-smarc.dts | 2 +- > 3 files changed, 220 insertions(+), 201 deletions(-) > create mode 100644 arch/arm64/boot/dts/renesas/r9a07g043u.dtsi > > -- > 2.25.1 > >
Hi Prabhakar, (now replying to the latest version) On Mon, Oct 17, 2022 at 11:12 AM Prabhakar <prabhakar.csengg@gmail.com> wrote: > This patch series aims to split up the RZ/G2UL SoC DTSI into common parts > so that this can be shared with the RZ/Five SoC. > > Implementation is based on the discussion [0] where I have used option#2. > > The Renesas RZ/G2UL (ARM64) and RZ/Five (RISC-V) have almost the same > identical blocks to avoid duplication a base SoC dtsi (r9a07g043.dtsi) is > created which will be used by the RZ/G2UL (r9a07g043u.dtsi) and RZ/Five > (r9a07g043F.dtsi) Thanks for your series! > Sending this as an RFC to get some feedback. > > r9a07g043f.dtsi will look something like below: > > #include <dt-bindings/interrupt-controller/irq.h> > > #define SOC_PERIPHERAL_IRQ_NUMBER(nr) (nr + 32) > #define SOC_PERIPHERAL_IRQ(nr, na) SOC_PERIPHERAL_IRQ_NUMBER(nr) na Originally, when I assumed incorrectly that dtc does not support arithmetic, I used "nr" and "na" in the macro I proposed to mean RISC-V ("r") resp. ARM ("a") interrupt number. Apparently the names stuck, although the second parameter now has a completely different meaning ;-) However, as the NCEPLIC does support interrupt flags, unlike the SiFive PLIC, there is no need to have the flags parameter in the macro. Moreover, it looks like the SOC_PERIPHERAL_IRQ_NUMBER() intermediate is not needed, so you can just write: #define SOC_PERIPHERAL_IRQ(nr) (nr + 32) > #include <arm64/renesas/r9a07g043.dtsi> > > / { > ... > ... > }; Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
Hi Geert. Thank you for the review. On Tue, Oct 25, 2022 at 1:42 PM Geert Uytterhoeven <geert@linux-m68k.org> wrote: > > Hi Prabhakar, > > (now replying to the latest version) > > On Mon, Oct 17, 2022 at 11:12 AM Prabhakar <prabhakar.csengg@gmail.com> wrote: > > This patch series aims to split up the RZ/G2UL SoC DTSI into common parts > > so that this can be shared with the RZ/Five SoC. > > > > Implementation is based on the discussion [0] where I have used option#2. > > > > The Renesas RZ/G2UL (ARM64) and RZ/Five (RISC-V) have almost the same > > identical blocks to avoid duplication a base SoC dtsi (r9a07g043.dtsi) is > > created which will be used by the RZ/G2UL (r9a07g043u.dtsi) and RZ/Five > > (r9a07g043F.dtsi) > > Thanks for your series! > > > Sending this as an RFC to get some feedback. > > > > r9a07g043f.dtsi will look something like below: > > > > #include <dt-bindings/interrupt-controller/irq.h> > > > > #define SOC_PERIPHERAL_IRQ_NUMBER(nr) (nr + 32) > > #define SOC_PERIPHERAL_IRQ(nr, na) SOC_PERIPHERAL_IRQ_NUMBER(nr) na > > Originally, when I assumed incorrectly that dtc does not support > arithmetic, I used "nr" and "na" in the macro I proposed to mean RISC-V > ("r") resp. ARM ("a") interrupt number. Apparently the names stuck, > although the second parameter now has a completely different meaning ;-) > > However, as the NCEPLIC does support interrupt flags, unlike the SiFive > PLIC, there is no need to have the flags parameter in the macro. > > Moreover, it looks like the SOC_PERIPHERAL_IRQ_NUMBER() > intermediate is not needed, so you can just write: > > #define SOC_PERIPHERAL_IRQ(nr) (nr + 32) > Agreed, I'll change it as per your suggestion and send a v2. Cheers, Prabhakar
From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> Hi All, This patch series aims to split up the RZ/G2UL SoC DTSI into common parts so that this can be shared with the RZ/Five SoC. Implementation is based on the discussion [0] where I have used option#2. The Renesas RZ/G2UL (ARM64) and RZ/Five (RISC-V) have almost the same identical blocks to avoid duplication a base SoC dtsi (r9a07g043.dtsi) is created which will be used by the RZ/G2UL (r9a07g043u.dtsi) and RZ/Five (r9a07g043F.dtsi) Sending this as an RFC to get some feedback. r9a07g043f.dtsi will look something like below: #include <dt-bindings/interrupt-controller/irq.h> #define SOC_PERIPHERAL_IRQ_NUMBER(nr) (nr + 32) #define SOC_PERIPHERAL_IRQ(nr, na) SOC_PERIPHERAL_IRQ_NUMBER(nr) na #include <arm64/renesas/r9a07g043.dtsi> / { ... ... }; Although patch#2 can be merged into patch#1 just wanted to keep them separated for easier review. RFC-> RESEND RFC * Patches rebased on [1] RFC: [2] [0] https://lore.kernel.org/linux-arm-kernel/Yyt8s5+pyoysVNeC@spud/T/ [1] https://patchwork.kernel.org/project/linux-renesas-soc/cover/20221009230044.10961-1-prabhakar.mahadev-lad.rj@bp.renesas.com/ [2] https://patchwork.kernel.org/project/linux-renesas-soc/cover/20220929172356.301342-1-prabhakar.mahadev-lad.rj@bp.renesas.com/ Cheers, Prabhakar Lad Prabhakar (2): arm64: dts: renesas: r9a07g043: Introduce SOC_PERIPHERAL_IRQ() macro to specify interrupt property arm64: dts: renesas: r9a07g043: Split out RZ/G2UL SoC specific parts arch/arm64/boot/dts/renesas/r9a07g043.dtsi | 347 ++++++++---------- arch/arm64/boot/dts/renesas/r9a07g043u.dtsi | 72 ++++ .../boot/dts/renesas/r9a07g043u11-smarc.dts | 2 +- 3 files changed, 220 insertions(+), 201 deletions(-) create mode 100644 arch/arm64/boot/dts/renesas/r9a07g043u.dtsi