diff mbox series

wifi: rtw89: check if sta's mac_id is valid under AP/TDLS

Message ID 20221021091828.40157-1-pkshih@realtek.com (mailing list archive)
State Accepted
Commit 46245bc42aff5e67b0498fa365a4baeaaaaeda86
Delegated to: Kalle Valo
Headers show
Series wifi: rtw89: check if sta's mac_id is valid under AP/TDLS | expand

Commit Message

Ping-Ke Shih Oct. 21, 2022, 9:18 a.m. UTC 
From: Zong-Zhe Yang <kevin_yang@realtek.com>

Add boundary check of mac_id when adding sta under AP/TDLS.
And, return -ENOSPC if the acquired mac_id is invalid.

Signed-off-by: Zong-Zhe Yang <kevin_yang@realtek.com>
Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>
---
 drivers/net/wireless/realtek/rtw89/core.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Kalle Valo Nov. 1, 2022, 9:25 a.m. UTC | #1 
Ping-Ke Shih <pkshih@realtek.com> wrote:

> From: Zong-Zhe Yang <kevin_yang@realtek.com>
> 
> Add boundary check of mac_id when adding sta under AP/TDLS.
> And, return -ENOSPC if the acquired mac_id is invalid.
> 
> Signed-off-by: Zong-Zhe Yang <kevin_yang@realtek.com>
> Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>

Patch applied to wireless-next.git, thanks.

46245bc42aff wifi: rtw89: check if sta's mac_id is valid under AP/TDLS
diff mbox series

Patch

diff --git a/drivers/net/wireless/realtek/rtw89/core.c b/drivers/net/wireless/realtek/rtw89/core.c
index a0fa9639b5097..557a4dcde1e7d 100644
--- a/drivers/net/wireless/realtek/rtw89/core.c
+++ b/drivers/net/wireless/realtek/rtw89/core.c
@@ -2413,6 +2413,8 @@  int rtw89_core_sta_add(struct rtw89_dev *rtwdev,
 	} else if (vif->type == NL80211_IFTYPE_AP || sta->tdls) {
 		rtwsta->mac_id = rtw89_core_acquire_bit_map(rtwdev->mac_id_map,
 							    RTW89_MAX_MAC_ID_NUM);
+		if (rtwsta->mac_id == RTW89_MAX_MAC_ID_NUM)
+			return -ENOSPC;
 	}
 
 	return 0;