| Message ID | 20221106085034.12582-1-linux@fw-web.de (mailing list archive) |
|---|---|
| Headers | show |
| Series | Add BananaPi R3 | expand |
Hi Rob, can you please take Patches 1+3 of v1 into your tree? due to reordering in my tree i missed them in this version https://patchwork.kernel.org/project/linux-mediatek/list/?series=685798 pcie-bindings are here: https://patchwork.kernel.org/project/linux-mediatek/list/?series=690172 i found 1 error in bpi-r3 dts (properties from sfp1 not plural) which i will fix in next version and will drop the compile comment in dt overlays. also i've found this commit: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git/commit/?h=dt/next&id=363547d2191cbc32ca954ba75d72908712398ff2 so maybe i need to rename my overlay dts files to dtso? maybe the others can be applied (at least the mt7986 nodes)? regards Frank
On 10/11/2022 18:03, Frank Wunderlich wrote: > Hi Rob, > > can you please take Patches 1+3 of v1 into your tree? > due to reordering in my tree i missed them in this version > > https://patchwork.kernel.org/project/linux-mediatek/list/?series=685798 > They should go through the subsystem maintainers trees. I'd advise to resend, dropping the RFC prefix and add the corresponding maintainers. Regards, Matthias > pcie-bindings are here: > > https://patchwork.kernel.org/project/linux-mediatek/list/?series=690172 > > i found 1 error in bpi-r3 dts (properties from sfp1 not plural) which i will fix in next version and will drop > the compile comment in dt overlays. > > also i've found this commit: > > https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git/commit/?h=dt/next&id=363547d2191cbc32ca954ba75d72908712398ff2 > > so maybe i need to rename my overlay dts files to dtso? > > maybe the others can be applied (at least the mt7986 nodes)? > > regards Frank
Hi > Gesendet: Freitag, 11. November 2022 um 10:17 Uhr > Von: "Matthias Brugger" <matthias.bgg@gmail.com> > An: "Frank Wunderlich" <frank-w@public-files.de>, "Rob Herring" <robh+dt@kernel.org> > Cc: linux-mediatek@lists.infradead.org, "Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, "Frank Wunderlich" <linux@fw-web.de> > Betreff: Re: Aw: [RFC v3 00/11] Add BananaPi R3 > > > > On 10/11/2022 18:03, Frank Wunderlich wrote: > > Hi Rob, > > > > can you please take Patches 1+3 of v1 into your tree? > > due to reordering in my tree i missed them in this version > > > > https://patchwork.kernel.org/project/linux-mediatek/list/?series=685798 > > > > They should go through the subsystem maintainers trees. I'd advise to resend, > dropping the RFC prefix and add the corresponding maintainers. ok, wait for your push and i create v4 including the missing binding-patches and the reorder of wed-node together with my fixes. > Regards, > Matthias > > > pcie-bindings are here: > > > > https://patchwork.kernel.org/project/linux-mediatek/list/?series=690172 > > > > i found 1 error in bpi-r3 dts (properties from sfp1 not plural) which i will fix in next version and will drop > > the compile comment in dt overlays. > > > > also i've found this commit: > > > > https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git/commit/?h=dt/next&id=363547d2191cbc32ca954ba75d72908712398ff2 > > > > so maybe i need to rename my overlay dts files to dtso? > > > > maybe the others can be applied (at least the mt7986 nodes)? does this solve your question about dt-overlays? just to note for all...it is all 1 board having sd+emmc on 1 mmc-controller and nand+nor on one spi. it depends on hardware-switches which devices are accessable (1mmc+1 spi). Adding dts for all possible combinations will add more dts (sd+nor, sd+nand, emmc+nor, emmc+nand) than adding the 2 overlays or adds redundant config. or should i copy the emmc/sd dts and adding once nor or nand? so we have the dtsi and dts for combinations above (=5 total)? > > regards Frank >
On 11/11/2022 13:37, Frank Wunderlich wrote: > Hi > >> Gesendet: Freitag, 11. November 2022 um 10:17 Uhr >> Von: "Matthias Brugger" <matthias.bgg@gmail.com> >> An: "Frank Wunderlich" <frank-w@public-files.de>, "Rob Herring" <robh+dt@kernel.org> >> Cc: linux-mediatek@lists.infradead.org, "Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, "Frank Wunderlich" <linux@fw-web.de> >> Betreff: Re: Aw: [RFC v3 00/11] Add BananaPi R3 >> >> >> >> On 10/11/2022 18:03, Frank Wunderlich wrote: >>> Hi Rob, >>> >>> can you please take Patches 1+3 of v1 into your tree? >>> due to reordering in my tree i missed them in this version >>> >>> https://patchwork.kernel.org/project/linux-mediatek/list/?series=685798 >>> >> >> They should go through the subsystem maintainers trees. I'd advise to resend, >> dropping the RFC prefix and add the corresponding maintainers. > > ok, wait for your push and i create v4 including the missing binding-patches and the reorder of wed-node together with my fixes. > >> Regards, >> Matthias >> >>> pcie-bindings are here: >>> >>> https://patchwork.kernel.org/project/linux-mediatek/list/?series=690172 >>> >>> i found 1 error in bpi-r3 dts (properties from sfp1 not plural) which i will fix in next version and will drop >>> the compile comment in dt overlays. >>> >>> also i've found this commit: >>> >>> https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git/commit/?h=dt/next&id=363547d2191cbc32ca954ba75d72908712398ff2 >>> >>> so maybe i need to rename my overlay dts files to dtso? >>> >>> maybe the others can be applied (at least the mt7986 nodes)? > > does this solve your question about dt-overlays? > > just to note for all...it is all 1 board having sd+emmc on 1 mmc-controller and nand+nor on one spi. it depends on hardware-switches which devices are accessable (1mmc+1 spi). Adding dts for all possible combinations will add more dts (sd+nor, sd+nand, emmc+nor, emmc+nand) than adding the 2 overlays or adds redundant config. > I wonder if in the end that wouldn't be part of U-Boot to pass the correct DTB depending on the HW switches. Just one idea I had is, to create on DTS with sd+nor+nand+emmc if that's possible. And then leave the permutations to the boot firmware (U-Boot). Regards, Matthias > or should i copy the emmc/sd dts and adding once nor or nand? so we have the dtsi and dts for combinations above (=5 total)? > >>> regards Frank >>
From: Frank Wunderlich <frank-w@public-files.de> This Series adds some Nodes to mt7986 devicetree and the BananaPi R3 i included sams series for mt7986 DTS with small changes https://patchwork.kernel.org/project/linux-mediatek/cover/20220427124741.18245-1-sam.shih@mediatek.com/ this series need these Patches: i2c-support: https://patchwork.kernel.org/project/linux-mediatek/cover/20221009101631.82380-1-linux@fw-web.de/ mmc bindings: https://patchwork.kernel.org/project/linux-mediatek/list/?series=688675 update pinctrl-bindings: https://patchwork.kernel.org/project/linux-mediatek/list/?series=692462 hwrng and pinctrl (uart splitting) are already applied to next i had run full dtbs-check but i end up with some strange warnings in ethernet-node that should not come up as phy-handle and sfp/managed properties are already defined. phy-handle made optional https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/net/mediatek,net.yaml#n265 property sfp/managed (which is included for mac subnode in yaml above): https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/net/ethernet-controller.yaml#n137 changes: v3: - changed mmc pull-ups - added patch for board binding (sent separately before) - added pcie node in mt7986 (not yet again in r3) - added dt overlays Frank Wunderlich (5): arm64: dts: mt7986: add i2c node dt-bindings: arm64: dts: mediatek: add compatible for bananapi r3 arm64: dts: mt7986: add Bananapi R3 arm64: dts: mt7986: add PCIe nodes to BananaPi-R3 arm64: dts: mt7986: add BPI-R3 nand/nor overlays Sam Shih (6): arm64: dts: mt7986: harmonize device node order arm64: dts: mt7986: add spi related device nodes arm64: dts: mt7986: add usb related device nodes arm64: dts: mt7986: add crypto related device nodes arm64: dts: mt7986: add mmc related device nodes arm64: dts: mt7986: add pcie related device nodes .../devicetree/bindings/arm/mediatek.yaml | 1 + arch/arm64/boot/dts/mediatek/Makefile | 4 + .../mediatek/mt7986a-bananapi-bpi-r3-emmc.dts | 31 ++ .../mediatek/mt7986a-bananapi-bpi-r3-nand.dts | 53 ++ .../mediatek/mt7986a-bananapi-bpi-r3-nor.dts | 67 +++ .../mediatek/mt7986a-bananapi-bpi-r3-sd.dts | 25 + .../dts/mediatek/mt7986a-bananapi-bpi-r3.dtsi | 458 ++++++++++++++++++ arch/arm64/boot/dts/mediatek/mt7986a-rfb.dts | 264 ++++++++-- arch/arm64/boot/dts/mediatek/mt7986a.dtsi | 179 +++++++ arch/arm64/boot/dts/mediatek/mt7986b-rfb.dts | 83 +++- 10 files changed, 1110 insertions(+), 55 deletions(-) create mode 100644 arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3-emmc.dts create mode 100644 arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3-nand.dts create mode 100644 arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3-nor.dts create mode 100644 arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3-sd.dts create mode 100644 arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dtsi