| Message ID | 20221119051900.1192401-1-william.xuanziyang@huawei.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 895b3b06efc285c1245242e9638b9ae251dc13ec |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | [net] wifi: plfxlc: fix potential memory leak in __lf_x_usb_enable_rx() | expand |
Ziyang Xuan <william.xuanziyang@huawei.com> writes: > urbs does not be freed in exception paths in __lf_x_usb_enable_rx(). > That will trigger memory leak. To fix it, add kfree() for urbs within > "error" label. Compile tested only. > > Fixes: 68d57a07bfe5 ("wireless: add plfxlc driver for pureLiFi X, XL, XC devices") > Signed-off-by: Ziyang Xuan <william.xuanziyang@huawei.com> > --- > drivers/net/wireless/purelifi/plfxlc/usb.c | 1 + > 1 file changed, 1 insertion(+) plfxlc patches go to wireless tree, not net. But I think I'll take this to wireless-next actually.
> Ziyang Xuan <william.xuanziyang@huawei.com> writes: > >> urbs does not be freed in exception paths in __lf_x_usb_enable_rx(). >> That will trigger memory leak. To fix it, add kfree() for urbs within >> "error" label. Compile tested only. >> >> Fixes: 68d57a07bfe5 ("wireless: add plfxlc driver for pureLiFi X, XL, XC devices") >> Signed-off-by: Ziyang Xuan <william.xuanziyang@huawei.com> >> --- >> drivers/net/wireless/purelifi/plfxlc/usb.c | 1 + >> 1 file changed, 1 insertion(+) > > plfxlc patches go to wireless tree, not net. But I think I'll take this > to wireless-next actually. OK, thanks. >
Ziyang Xuan <william.xuanziyang@huawei.com> wrote: > urbs does not be freed in exception paths in __lf_x_usb_enable_rx(). > That will trigger memory leak. To fix it, add kfree() for urbs within > "error" label. Compile tested only. > > Fixes: 68d57a07bfe5 ("wireless: add plfxlc driver for pureLiFi X, XL, XC devices") > Signed-off-by: Ziyang Xuan <william.xuanziyang@huawei.com> Patch applied to wireless-next.git, thanks. 895b3b06efc2 wifi: plfxlc: fix potential memory leak in __lf_x_usb_enable_rx()
diff --git a/drivers/net/wireless/purelifi/plfxlc/usb.c b/drivers/net/wireless/purelifi/plfxlc/usb.c index 39e54b3787d6..76d0a778636a 100644 --- a/drivers/net/wireless/purelifi/plfxlc/usb.c +++ b/drivers/net/wireless/purelifi/plfxlc/usb.c @@ -247,6 +247,7 @@ static int __lf_x_usb_enable_rx(struct plfxlc_usb *usb) for (i = 0; i < RX_URBS_COUNT; i++) free_rx_urb(urbs[i]); } + kfree(urbs); return r; }
urbs does not be freed in exception paths in __lf_x_usb_enable_rx(). That will trigger memory leak. To fix it, add kfree() for urbs within "error" label. Compile tested only. Fixes: 68d57a07bfe5 ("wireless: add plfxlc driver for pureLiFi X, XL, XC devices") Signed-off-by: Ziyang Xuan <william.xuanziyang@huawei.com> --- drivers/net/wireless/purelifi/plfxlc/usb.c | 1 + 1 file changed, 1 insertion(+)