| Message ID | 202211301541270908055@zte.com.cn (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | [net-next] net/mlx5: remove NULL check before dev_{put, hold} | expand |
On Wed, Nov 30, 2022 at 03:41:27PM +0800, zhang.songyi@zte.com.cn wrote: > From: zhang songyi <zhang.songyi@zte.com.cn> > > The call netdev_{put, hold} of dev_{put, hold} will check NULL, > so there is no need to check before using dev_{put, hold}. > > Fix the following coccicheck warning: > /drivers/net/ethernet/mellanox/mlx5/core/lag/lag.c:1450:2-10: > WARNING: > WARNING NULL check before dev_{put, hold} functions is not needed. > > Signed-off-by: zhang songyi <zhang.songyi@zte.com.cn> > --- > drivers/net/ethernet/mellanox/mlx5/core/lag/lag.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) Please change all places in mlx5 in one patch. You can find these with the following command git grep -B 1 -E "dev_put|dev_hold" drivers/net/ethernet/mellanox/mlx5/ Thanks > > diff --git a/drivers/net/ethernet/mellanox/mlx5/core/lag/lag.c b/drivers/net/ethernet/mellanox/mlx5/core/lag/lag.c > index 32c3e0a649a7..6ab3a6b6dd8d 100644 > --- a/drivers/net/ethernet/mellanox/mlx5/core/lag/lag.c > +++ b/drivers/net/ethernet/mellanox/mlx5/core/lag/lag.c > @@ -1448,8 +1448,7 @@ struct net_device *mlx5_lag_get_roce_netdev(struct mlx5_core_dev *dev) > } else { > ndev = ldev->pf[MLX5_LAG_P1].netdev; > } > - if (ndev) > - dev_hold(ndev); > + dev_hold(ndev); > > unlock: > spin_unlock_irqrestore(&lag_lock, flags); > -- > 2.25.1
On Wed, 30 Nov 2022 11:00:34 +0200 Leon Romanovsky wrote: > On Wed, Nov 30, 2022 at 03:41:27PM +0800, zhang.songyi@zte.com.cn wrote: > > From: zhang songyi <zhang.songyi@zte.com.cn> > > > > The call netdev_{put, hold} of dev_{put, hold} will check NULL, > > so there is no need to check before using dev_{put, hold}. > > > > Fix the following coccicheck warning: > > /drivers/net/ethernet/mellanox/mlx5/core/lag/lag.c:1450:2-10: > > WARNING: > > WARNING NULL check before dev_{put, hold} functions is not needed. > > > > Signed-off-by: zhang songyi <zhang.songyi@zte.com.cn> > > --- > > drivers/net/ethernet/mellanox/mlx5/core/lag/lag.c | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > Please change all places in mlx5 in one patch. Your call as a mlx5 maintainer, but I'd say don't change them at all. All these trivial patches are such a damn waste of time.
On Wed, Nov 30, 2022 at 09:25:16AM -0800, Jakub Kicinski wrote: > On Wed, 30 Nov 2022 11:00:34 +0200 Leon Romanovsky wrote: > > On Wed, Nov 30, 2022 at 03:41:27PM +0800, zhang.songyi@zte.com.cn wrote: > > > From: zhang songyi <zhang.songyi@zte.com.cn> > > > > > > The call netdev_{put, hold} of dev_{put, hold} will check NULL, > > > so there is no need to check before using dev_{put, hold}. > > > > > > Fix the following coccicheck warning: > > > /drivers/net/ethernet/mellanox/mlx5/core/lag/lag.c:1450:2-10: > > > WARNING: > > > WARNING NULL check before dev_{put, hold} functions is not needed. > > > > > > Signed-off-by: zhang songyi <zhang.songyi@zte.com.cn> > > > --- > > > drivers/net/ethernet/mellanox/mlx5/core/lag/lag.c | 3 +-- > > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > Please change all places in mlx5 in one patch. > > Your call as a mlx5 maintainer, but I'd say don't change them at all. I'm fine with one patch per-driver, I'm not fine with one patch per-line :). > All these trivial patches are such a damn waste of time. IMHO, it is valuable changes for actively developed code. Thanks
On 30 Nov 09:25, Jakub Kicinski wrote: >On Wed, 30 Nov 2022 11:00:34 +0200 Leon Romanovsky wrote: >> On Wed, Nov 30, 2022 at 03:41:27PM +0800, zhang.songyi@zte.com.cn wrote: >> > From: zhang songyi <zhang.songyi@zte.com.cn> >> > >> > The call netdev_{put, hold} of dev_{put, hold} will check NULL, >> > so there is no need to check before using dev_{put, hold}. >> > >> > Fix the following coccicheck warning: >> > /drivers/net/ethernet/mellanox/mlx5/core/lag/lag.c:1450:2-10: >> > WARNING: >> > WARNING NULL check before dev_{put, hold} functions is not needed. >> > >> > Signed-off-by: zhang songyi <zhang.songyi@zte.com.cn> >> > --- >> > drivers/net/ethernet/mellanox/mlx5/core/lag/lag.c | 3 +-- >> > 1 file changed, 1 insertion(+), 2 deletions(-) >> >> Please change all places in mlx5 in one patch. > >Your call as a mlx5 maintainer, but I'd say don't change them at all. >All these trivial patches are such a damn waste of time. I agree, let's not waste more time on this, I will accept this patch as is since it's already marked awating-upstream.. Applied to net-next-mlx5
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/lag/lag.c b/drivers/net/ethernet/mellanox/mlx5/core/lag/lag.c index 32c3e0a649a7..6ab3a6b6dd8d 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/lag/lag.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/lag/lag.c @@ -1448,8 +1448,7 @@ struct net_device *mlx5_lag_get_roce_netdev(struct mlx5_core_dev *dev) } else { ndev = ldev->pf[MLX5_LAG_P1].netdev; } - if (ndev) - dev_hold(ndev); + dev_hold(ndev); unlock: spin_unlock_irqrestore(&lag_lock, flags);