diff mbox series

[1/3] wifi: rtw89: 8852c: rfk: correct DACK setting

Message ID 20221209020940.9573-2-pkshih@realtek.com (mailing list archive)
State Accepted
Commit b2bab7b14098dcf5d405fa8c76b2c3f6ce9184f9
Delegated to: Kalle Valo
Headers show
Series wifi: rtw89: 8852c: correct some RFK settings to improve RF performance | expand

Commit Message

Ping-Ke Shih Dec. 9, 2022, 2:09 a.m. UTC
After filling calibration parameters, set BIT(0) to enable the hardware
circuit, but original set incorrect bit that affects a little TX
performance.

Fixes: 76599a8d0b7d ("rtw89: 8852c: rfk: add DACK")
Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>
---
 drivers/net/wireless/realtek/rtw89/rtw8852c_rfk.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Kalle Valo Dec. 14, 2022, 12:26 p.m. UTC | #1
Ping-Ke Shih <pkshih@realtek.com> wrote:

> After filling calibration parameters, set BIT(0) to enable the hardware
> circuit, but original set incorrect bit that affects a little TX
> performance.
> 
> Fixes: 76599a8d0b7d ("rtw89: 8852c: rfk: add DACK")
> Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>

3 patches applied to wireless-next.git, thanks.

b2bab7b14098 wifi: rtw89: 8852c: rfk: correct DACK setting
21b5f159a2ee wifi: rtw89: 8852c: rfk: correct DPK settings
9c22d603e255 wifi: rtw89: 8852c: rfk: recover RX DCK failure
diff mbox series

Patch

diff --git a/drivers/net/wireless/realtek/rtw89/rtw8852c_rfk.c b/drivers/net/wireless/realtek/rtw89/rtw8852c_rfk.c
index 60cd676fe22c9..f5b0b57f33207 100644
--- a/drivers/net/wireless/realtek/rtw89/rtw8852c_rfk.c
+++ b/drivers/net/wireless/realtek/rtw89/rtw8852c_rfk.c
@@ -337,7 +337,7 @@  static void _dack_reload_by_path(struct rtw89_dev *rtwdev,
 		(dack->dadck_d[path][index] << 14);
 	addr = 0xc210 + offset;
 	rtw89_phy_write32(rtwdev, addr, val32);
-	rtw89_phy_write32_set(rtwdev, addr, BIT(1));
+	rtw89_phy_write32_set(rtwdev, addr, BIT(0));
 }
 
 static void _dack_reload(struct rtw89_dev *rtwdev, enum rtw89_rf_path path)