| Message ID | 20221214155943.15418-1-paul@crapouillou.net (mailing list archive) |
|---|---|
| State | Rejected |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | dt-bindings: bcm4329-fmac: Add ingenic,iw8103-fmac compatible string | expand |
On 14/12/2022 16:59, Paul Cercueil wrote: > The MIPS CI20 board has a Ingenic IW8103 chip, which is supposedly just > a rebranded Broadcom BCM4330. > > Signed-off-by: Paul Cercueil <paul@crapouillou.net> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On 12/14/2022 5:53 PM, Krzysztof Kozlowski wrote: > On 14/12/2022 16:59, Paul Cercueil wrote: >> The MIPS CI20 board has a Ingenic IW8103 chip, which is supposedly just >> a rebranded Broadcom BCM4330. >> >> Signed-off-by: Paul Cercueil <paul@crapouillou.net> > > > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> My guess is that Ingenic is not really a chip manufacturer, but this is actually a wifi module using BCM4330 as wifi chip. Personally, I would not add a compatible string for that and the commit message does not offer any arguments for having this. Regards, Arend
diff --git a/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml b/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml index fec1cc9b9a08..d092c1e7f3ef 100644 --- a/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml +++ b/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml @@ -40,6 +40,7 @@ properties: - brcm,bcm4359-fmac - cypress,cyw4373-fmac - cypress,cyw43012-fmac + - ingenic,iw8103-fmac - const: brcm,bcm4329-fmac - enum: - brcm,bcm4329-fmac
The MIPS CI20 board has a Ingenic IW8103 chip, which is supposedly just a rebranded Broadcom BCM4330. Signed-off-by: Paul Cercueil <paul@crapouillou.net> --- .../devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml | 1 + 1 file changed, 1 insertion(+)