diff mbox series

[v3,4/4] arm64: dts: qcom: sc7180: Add pazquel360 touschreen

Message ID 20221209091234.v3.4.Id132522bda31fd97684cb076a44a0907cd28097d@changeid (mailing list archive)
State Mainlined
Commit 335fe4b79838a7c722d21c15784f7ed1172a6c81
Headers show
Series arm64: dts: qcom: sc7180: Make pazquel360's touchscreen work | expand

Commit Message

Doug Anderson Dec. 9, 2022, 5:12 p.m. UTC
The touchscreen was supposed to have been added when pazquel360 first
was added upstream but was missed. Add it now.

Signed-off-by: Douglas Anderson <dianders@chromium.org>
Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
---

Changes in v3:
- Removed hid-descr-addr

 .../dts/qcom/sc7180-trogdor-pazquel360.dtsi   | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)

Comments

Bjorn Andersson Dec. 28, 2022, 3:32 a.m. UTC | #1
On Fri, Dec 09, 2022 at 09:12:40AM -0800, Douglas Anderson wrote:
> The touchscreen was supposed to have been added when pazquel360 first
> was added upstream but was missed. Add it now.
> 
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
> Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
> ---
> 
> Changes in v3:
> - Removed hid-descr-addr
> 
>  .../dts/qcom/sc7180-trogdor-pazquel360.dtsi   | 19 +++++++++++++++++++
>  1 file changed, 19 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel360.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel360.dtsi
> index 5702325d0c7b..ff9dd6857f8b 100644
> --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel360.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel360.dtsi
> @@ -14,6 +14,25 @@ &alc5682 {
>  	realtek,dmic-clk-rate-hz = <2048000>;
>  };
>  
> +ap_ts_pen_1v8: &i2c4 {
> +	status = "okay";

I'm told that we want status to be the last property, so I moved it
one step down as I applied the patch.

Thanks,
Bjorn

> +	clock-frequency = <400000>;
> +
> +	ap_ts: touchscreen@10 {
> +		compatible = "elan,ekth3915", "elan,ekth3500";
> +		reg = <0x10>;
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&ts_int_l>, <&ts_reset_l>;
> +
> +		interrupt-parent = <&tlmm>;
> +		interrupts = <9 IRQ_TYPE_LEVEL_LOW>;
> +
> +		vcc33-supply = <&pp3300_ts>;
> +		vccio-supply = <&pp1800_l10a>;
> +		reset-gpios = <&tlmm 8 GPIO_ACTIVE_LOW>;
> +	};
> +};
> +
>  &keyboard_controller {
>  	function-row-physmap = <
>  		MATRIX_KEY(0x00, 0x02, 0)	/* T1 */
> -- 
> 2.39.0.rc1.256.g54fd8350bd-goog
>
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel360.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel360.dtsi
index 5702325d0c7b..ff9dd6857f8b 100644
--- a/arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel360.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel360.dtsi
@@ -14,6 +14,25 @@  &alc5682 {
 	realtek,dmic-clk-rate-hz = <2048000>;
 };
 
+ap_ts_pen_1v8: &i2c4 {
+	status = "okay";
+	clock-frequency = <400000>;
+
+	ap_ts: touchscreen@10 {
+		compatible = "elan,ekth3915", "elan,ekth3500";
+		reg = <0x10>;
+		pinctrl-names = "default";
+		pinctrl-0 = <&ts_int_l>, <&ts_reset_l>;
+
+		interrupt-parent = <&tlmm>;
+		interrupts = <9 IRQ_TYPE_LEVEL_LOW>;
+
+		vcc33-supply = <&pp3300_ts>;
+		vccio-supply = <&pp1800_l10a>;
+		reset-gpios = <&tlmm 8 GPIO_ACTIVE_LOW>;
+	};
+};
+
 &keyboard_controller {
 	function-row-physmap = <
 		MATRIX_KEY(0x00, 0x02, 0)	/* T1 */