mbox series

[for-next,0/4] RDMA/irdma: Refactor irdma_reg_user_mr function

Message ID 20230109195402.1339737-1-yanjun.zhu@intel.com (mailing list archive)
Headers show
Series RDMA/irdma: Refactor irdma_reg_user_mr function | expand

Message

Zhu Yanjun Jan. 9, 2023, 7:53 p.m. UTC
From: Zhu Yanjun <yanjun.zhu@linux.dev>

Split the shared source codes into several new functions for future use.
No bug fix and new feature in this commit series.

The new functions are as below:

irdma_reg_user_mr_type_mem
irdma_alloc_iwmr
irdma_free_iwmr
irdma_reg_user_mr_type_qp
irdma_reg_user_mr_type_cq

These functions will be used in the dmabuf feature.

Zhu Yanjun (4):
  RDMA/irdma: Split MEM handler into irdma_reg_user_mr_type_mem
  RDMA/irdma: Split mr alloc and free into new functions
  RDMA/irdma: Split QP handler into irdma_reg_user_mr_type_qp
  RDMA/irdma: Split CQ handler into irdma_reg_user_mr_type_cq

 drivers/infiniband/hw/irdma/verbs.c | 260 +++++++++++++++++-----------
 1 file changed, 160 insertions(+), 100 deletions(-)

Comments

Shiraz Saleem Jan. 10, 2023, 4:14 a.m. UTC | #1
> Subject: [PATCH for-next 0/4] RDMA/irdma: Refactor irdma_reg_user_mr function
> 
> From: Zhu Yanjun <yanjun.zhu@linux.dev>
> 
> Split the shared source codes into several new functions for future use.
> No bug fix and new feature in this commit series.
> 
> The new functions are as below:
> 
> irdma_reg_user_mr_type_mem
> irdma_alloc_iwmr
> irdma_free_iwmr
> irdma_reg_user_mr_type_qp
> irdma_reg_user_mr_type_cq

Thanks! General direction is good. I provided some feedback.

> 
> These functions will be used in the dmabuf feature.

Do you want to add that dma buf patch to this series too? So that we can see it how it re-uses the new APIs you created.

So 1st 4 patches would be clean-up/refactor patches in preparation for patch #5 which is the dma buf API addition.

> 
> Zhu Yanjun (4):
>   RDMA/irdma: Split MEM handler into irdma_reg_user_mr_type_mem
>   RDMA/irdma: Split mr alloc and free into new functions
>   RDMA/irdma: Split QP handler into irdma_reg_user_mr_type_qp
>   RDMA/irdma: Split CQ handler into irdma_reg_user_mr_type_cq
> 
>  drivers/infiniband/hw/irdma/verbs.c | 260 +++++++++++++++++-----------
>  1 file changed, 160 insertions(+), 100 deletions(-)
> 
> --
> 2.31.1