mbox series

[0/8] btrfs: some log tree fixes and cleanups

Message ID cover.1673361215.git.fdmanana@suse.com (mailing list archive)
Headers show
Series btrfs: some log tree fixes and cleanups | expand

Message

Filipe Manana Jan. 10, 2023, 2:56 p.m. UTC
From: Filipe Manana <fdmanana@suse.com>

Some fixes mostly around directory logging and some cleanups (the last
three patches).

Filipe Manana (8):
  btrfs: fix missing error handling when logging directory items
  btrfs: fix directory logging due to race with concurrent index key deletion
  btrfs: add missing setup of log for full commit at add_conflicting_inode()
  btrfs: do not abort transaction on failure to write log tree when syncing log
  btrfs: do not abort transaction on failure to update log root
  btrfs: simplify update of last_dir_index_offset when logging a directory
  btrfs: use a negative value for BTRFS_LOG_FORCE_COMMIT
  btrfs: use a single variable to track return value for log_dir_items()

 fs/btrfs/disk-io.c  |  9 ++++-
 fs/btrfs/tree-log.c | 91 ++++++++++++++++++++++++++++-----------------
 fs/btrfs/tree-log.h | 11 ++++--
 3 files changed, 71 insertions(+), 40 deletions(-)

Comments

Josef Bacik Jan. 11, 2023, 9:24 p.m. UTC | #1
On Tue, Jan 10, 2023 at 02:56:33PM +0000, fdmanana@kernel.org wrote:
> From: Filipe Manana <fdmanana@suse.com>
> 
> Some fixes mostly around directory logging and some cleanups (the last
> three patches).
> 

You can add

Reviewed-by: Josef Bacik <josef@toxicpanda.com>

Thanks,

Josef
David Sterba Jan. 12, 2023, 2:45 p.m. UTC | #2
On Tue, Jan 10, 2023 at 02:56:33PM +0000, fdmanana@kernel.org wrote:
> From: Filipe Manana <fdmanana@suse.com>
> 
> Some fixes mostly around directory logging and some cleanups (the last
> three patches).
> 
> Filipe Manana (8):
>   btrfs: fix missing error handling when logging directory items
>   btrfs: fix directory logging due to race with concurrent index key deletion
>   btrfs: add missing setup of log for full commit at add_conflicting_inode()
>   btrfs: do not abort transaction on failure to write log tree when syncing log
>   btrfs: do not abort transaction on failure to update log root
>   btrfs: simplify update of last_dir_index_offset when logging a directory
>   btrfs: use a negative value for BTRFS_LOG_FORCE_COMMIT
>   btrfs: use a single variable to track return value for log_dir_items()

Added to misc-next, thanks. The first 5 patches will go to the next pull
request to fix the recently reported tree-log bugs.