| Message ID | 20230111172133.334735-1-dbarboza@ventanamicro.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | hw/mips/boston.c: rename MachineState 'mc' pointer to 'ms' | expand |
On 11/1/23 18:21, Daniel Henrique Barboza wrote: > Follow the QEMU convention of naming MachineState pointers as 'ms' by > renaming the instance in create_fdt() where we're calling it 'mc'. > > Cc: Paul Burton <paulburton@kernel.org> > Cc: Aleksandar Rikalo <aleksandar.rikalo@syrmia.com> > Suggested-by: Philippe Mathieu-Daudé <philmd@linaro.org> > Signed-off-by: Daniel Henrique Barboza <dbarboza@ventanamicro.com> > --- > hw/mips/boston.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
On Thu, Jan 12, 2023 at 1:27 AM Daniel Henrique Barboza <dbarboza@ventanamicro.com> wrote: > > Follow the QEMU convention of naming MachineState pointers as 'ms' by > renaming the instance in create_fdt() where we're calling it 'mc'. > > Cc: Paul Burton <paulburton@kernel.org> > Cc: Aleksandar Rikalo <aleksandar.rikalo@syrmia.com> > Suggested-by: Philippe Mathieu-Daudé <philmd@linaro.org> > Signed-off-by: Daniel Henrique Barboza <dbarboza@ventanamicro.com> > --- > hw/mips/boston.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
On 11/1/23 18:21, Daniel Henrique Barboza wrote: > Follow the QEMU convention of naming MachineState pointers as 'ms' by > renaming the instance in create_fdt() where we're calling it 'mc'. > > Cc: Paul Burton <paulburton@kernel.org> > Cc: Aleksandar Rikalo <aleksandar.rikalo@syrmia.com> > Suggested-by: Philippe Mathieu-Daudé <philmd@linaro.org> > Signed-off-by: Daniel Henrique Barboza <dbarboza@ventanamicro.com> > --- > hw/mips/boston.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Queued on mips-next, thanks!
diff --git a/hw/mips/boston.c b/hw/mips/boston.c index edda87e23c..6ef6b020a2 100644 --- a/hw/mips/boston.c +++ b/hw/mips/boston.c @@ -515,7 +515,7 @@ static const void *create_fdt(BostonState *s, { void *fdt; int cpu; - MachineState *mc = s->mach; + MachineState *ms = s->mach; uint32_t platreg_ph, gic_ph, clk_ph; char *name, *gic_name, *platreg_name, *stdout_name; static const char * const syscon_compat[2] = { @@ -542,7 +542,7 @@ static const void *create_fdt(BostonState *s, qemu_fdt_setprop_cell(fdt, "/cpus", "#size-cells", 0x0); qemu_fdt_setprop_cell(fdt, "/cpus", "#address-cells", 0x1); - for (cpu = 0; cpu < mc->smp.cpus; cpu++) { + for (cpu = 0; cpu < ms->smp.cpus; cpu++) { name = g_strdup_printf("/cpus/cpu@%d", cpu); qemu_fdt_add_subnode(fdt, name); qemu_fdt_setprop_string(fdt, name, "compatible", "img,mips");
Follow the QEMU convention of naming MachineState pointers as 'ms' by renaming the instance in create_fdt() where we're calling it 'mc'. Cc: Paul Burton <paulburton@kernel.org> Cc: Aleksandar Rikalo <aleksandar.rikalo@syrmia.com> Suggested-by: Philippe Mathieu-Daudé <philmd@linaro.org> Signed-off-by: Daniel Henrique Barboza <dbarboza@ventanamicro.com> --- hw/mips/boston.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)