diff mbox series

[v2] dt-bindings: PCI: qcom,pcie-ep: correct qcom,perst-regs

Message ID 20221109113202.74406-1-krzysztof.kozlowski@linaro.org (mailing list archive)
State Accepted
Delegated to: Lorenzo Pieralisi
Headers show
Series [v2] dt-bindings: PCI: qcom,pcie-ep: correct qcom,perst-regs | expand

Commit Message

Krzysztof Kozlowski Nov. 9, 2022, 11:32 a.m. UTC 
qcom,perst-regs is an phandle array of one item with a phandle and its
arguments.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Acked-by: Manivannan Sadhasivam <mani@kernel.org>
Reviewed-by: Rob Herring <robh@kernel.org>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>

---

Changes since v1:
1. Correct lang typo.
2. Add tags.
---
 Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

Comments

Lorenzo Pieralisi Dec. 30, 2022, 1:42 p.m. UTC | #1 
On Wed, 9 Nov 2022 12:32:02 +0100, Krzysztof Kozlowski wrote:
> qcom,perst-regs is an phandle array of one item with a phandle and its
> arguments.
> 
> 

Applied to pci/dt, thanks!

[1/1] dt-bindings: PCI: qcom,pcie-ep: correct qcom,perst-regs
      https://git.kernel.org/lpieralisi/pci/c/68909a813609

Thanks,
Lorenzo
Krzysztof Kozlowski Jan. 13, 2023, 9:02 a.m. UTC | #2 
On 30/12/2022 14:42, Lorenzo Pieralisi wrote:
> On Wed, 9 Nov 2022 12:32:02 +0100, Krzysztof Kozlowski wrote:
>> qcom,perst-regs is an phandle array of one item with a phandle and its
>> arguments.
>>
>>
> 
> Applied to pci/dt, thanks!
> 
> [1/1] dt-bindings: PCI: qcom,pcie-ep: correct qcom,perst-regs
>       https://git.kernel.org/lpieralisi/pci/c/68909a813609

It's still not in linux-next. Is you tree correctly included in the next?

Best regards,
Krzysztof
Bjorn Helgaas Jan. 13, 2023, 2:03 p.m. UTC | #3 
On Fri, Jan 13, 2023 at 10:02:27AM +0100, Krzysztof Kozlowski wrote:
> On 30/12/2022 14:42, Lorenzo Pieralisi wrote:
> > On Wed, 9 Nov 2022 12:32:02 +0100, Krzysztof Kozlowski wrote:
> >> qcom,perst-regs is an phandle array of one item with a phandle and its
> >> arguments.
> > 
> > Applied to pci/dt, thanks!
> > 
> > [1/1] dt-bindings: PCI: qcom,pcie-ep: correct qcom,perst-regs
> >       https://git.kernel.org/lpieralisi/pci/c/68909a813609
> 
> It's still not in linux-next. Is you tree correctly included in the next?

It's on Lorenzo's branch
(https://git.kernel.org/pub/scm/linux/kernel/git/lpieralisi/pci.git/)
but I haven't pulled it into my "next" branch yet.  Will try to do
that today.

Bjorn
Krzysztof Kozlowski Jan. 13, 2023, 2:23 p.m. UTC | #4 
On 13/01/2023 15:03, Bjorn Helgaas wrote:
> On Fri, Jan 13, 2023 at 10:02:27AM +0100, Krzysztof Kozlowski wrote:
>> On 30/12/2022 14:42, Lorenzo Pieralisi wrote:
>>> On Wed, 9 Nov 2022 12:32:02 +0100, Krzysztof Kozlowski wrote:
>>>> qcom,perst-regs is an phandle array of one item with a phandle and its
>>>> arguments.
>>>
>>> Applied to pci/dt, thanks!
>>>
>>> [1/1] dt-bindings: PCI: qcom,pcie-ep: correct qcom,perst-regs
>>>       https://git.kernel.org/lpieralisi/pci/c/68909a813609
>>
>> It's still not in linux-next. Is you tree correctly included in the next?
> 
> It's on Lorenzo's branch
> (https://git.kernel.org/pub/scm/linux/kernel/git/lpieralisi/pci.git/)
> but I haven't pulled it into my "next" branch yet.  Will try to do
> that today.

If Lorenzo picks up patches which at some point are merged by another
maintainer, his tree should be in linux-next as well (and in LKP tests).
Otherwise we loose some build and test coverage.

Best regards,
Krzysztof
Bjorn Helgaas Jan. 13, 2023, 10:47 p.m. UTC | #5 
On Fri, Jan 13, 2023 at 03:23:18PM +0100, Krzysztof Kozlowski wrote:
> On 13/01/2023 15:03, Bjorn Helgaas wrote:
> > On Fri, Jan 13, 2023 at 10:02:27AM +0100, Krzysztof Kozlowski wrote:
> >> On 30/12/2022 14:42, Lorenzo Pieralisi wrote:
> >>> On Wed, 9 Nov 2022 12:32:02 +0100, Krzysztof Kozlowski wrote:
> >>>> qcom,perst-regs is an phandle array of one item with a phandle and its
> >>>> arguments.
> >>>
> >>> Applied to pci/dt, thanks!
> >>>
> >>> [1/1] dt-bindings: PCI: qcom,pcie-ep: correct qcom,perst-regs
> >>>       https://git.kernel.org/lpieralisi/pci/c/68909a813609
> >>
> >> It's still not in linux-next. Is you tree correctly included in the next?
> > 
> > It's on Lorenzo's branch
> > (https://git.kernel.org/pub/scm/linux/kernel/git/lpieralisi/pci.git/)
> > but I haven't pulled it into my "next" branch yet.  Will try to do
> > that today.
> 
> If Lorenzo picks up patches which at some point are merged by another
> maintainer, his tree should be in linux-next as well (and in LKP tests).
> Otherwise we loose some build and test coverage.

Oh, I remember what happened.  I started the merge a while ago and
tripped over the conflict between these:

  dt-bindings: PCI: qcom: add MSM8998 specific compatible
  dt-bindings: PCI: qcom: Add sm8350 to bindings

I asked about splitting the first and if you did that, I missed it,
and in the meantime I got distracted by my E820/EfiMemoryMappedIO
regression.

In any event, I updated "next" with this.  Check my conflict
resolution because I'm not a DT expert:

https://git.kernel.org/cgit/linux/kernel/git/helgaas/pci.git/tree/Documentation/devicetree/bindings/pci/qcom,pcie.yaml?id=25cfdd48a4bd
Krzysztof Kozlowski Jan. 15, 2023, 11:27 a.m. UTC | #6 
On 13/01/2023 23:47, Bjorn Helgaas wrote:
>   dt-bindings: PCI: qcom: add MSM8998 specific compatible
>   dt-bindings: PCI: qcom: Add sm8350 to bindings
> 
> I asked about splitting the first and if you did that, I missed it,
> and in the meantime I got distracted by my E820/EfiMemoryMappedIO
> regression.
> 
> In any event, I updated "next" with this.  Check my conflict
> resolution because I'm not a DT expert:
> 
> https://git.kernel.org/cgit/linux/kernel/git/helgaas/pci.git/tree/Documentation/devicetree/bindings/pci/qcom,pcie.yaml?id=25cfdd48a4bd

Look good, thanks!

Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml
index 977c976ea799..8005ccd287c0 100644
--- a/Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml
+++ b/Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml
@@ -47,8 +47,10 @@  properties:
                  enable registers
     $ref: "/schemas/types.yaml#/definitions/phandle-array"
     items:
-      minItems: 3
-      maxItems: 3
+      - items:
+          - description: Syscon to TCSR system registers
+          - description: Perst enable offset
+          - description: Perst separation enable offset
 
   interrupts:
     items: